bug#15372: eshell gives environment variables high precedence

bug#15372: eshell gives environment variables high precedence

[Glenn Morris]

Package: emacs
Version: 24.3

I don't use eshell, so maybe this is how it is supposed to work, but
from the point of view of normal shells, this seems wrong:

foo=FOOBAR emacs -Q -f eshell
eshell> for foo in 5 { echo $foo }
        -> FOOBAR

Cf:

bash> export foo=FOOBAR
bash> for foo in 5; do echo $foo; done
      -> 5

bug#15372: eshell gives environment variables high precedence

[Stefan Monnier]

> I don't use eshell, so maybe this is how it is supposed to work, but
> from the point of view of normal shells, this seems wrong:
> foo=FOOBAR emacs -Q -f eshell
> eshell> for foo in 5 { echo $foo }
> -> FOOBAR

Sorry, I saw this email too late.  Yes, indeed, this should be a bug.


        Stefan

bug#15372: eshell gives environment variables high precedence

[Glenn Morris]

Stefan Monnier wrote:

> Sorry, I saw this email too late.  Yes, indeed, this should be a bug.

It's like that since at least 22.1; ie this is not related to your changes.

bug#15372: eshell gives environment variables high precedence

[Glenn Morris]

If you set eshell-prefer-lisp-variables non-nil, it works.

Re: bug#15372: eshell gives environment variables high precedence

[Aidan Gauland]

Glenn Morris <rgm@gnu.org> writes:

> If you set eshell-prefer-lisp-variables non-nil, it works.

I will add a mention of this in the manual, since users should not have
to hunt that variable down as you did.

bug#15372: eshell gives environment variables high precedence

[Glenn Morris]

Please don't post to bug-gnu-emacs via the newsgroup (it bypasses the
bug tracker).

Aidan Gauland wrote:

> Glenn Morris <rgm@gnu.org> writes:
>
>> If you set eshell-prefer-lisp-variables non-nil, it works.
>
> I will add a mention of this in the manual, since users should not have
> to hunt that variable down as you did.

Actually I believe I fixed the issue. But that variable can be mentioned
anyway, just not in this context.

bug#15372: eshell gives environment variables high precedence

[Aidan Gauland]

Glenn Morris <rgm@gnu.org> writes:

> Aidan Gauland wrote:
>
>> Glenn Morris <rgm@gnu.org> writes:
>>
>>> If you set eshell-prefer-lisp-variables non-nil, it works.
>>
>> I will add a mention of this in the manual, since users should not have
>> to hunt that variable down as you did.
>
> Actually I believe I fixed the issue. But that variable can be mentioned
> anyway, just not in this context.

So, to clarify, what behaviour did you change/fix?

bug#15372: eshell gives environment variables high precedence

[Glenn Morris]

Aidan Gauland wrote:

> So, to clarify, what behaviour did you change/fix?

foo=FOOBAR emacs -Q -f eshell
eshell>
echo $foo                    # -> FOOBAR
for foo in 5 { echo $foo }   # -> 5   [was FOOBAR, a bug]
echo $foo                    # -> FOOBAR