all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Environment variables in dynamic modules
@ 2024-01-11 16:03 Spencer Baugh
  2024-01-11 17:02 ` Eli Zaretskii
  2024-01-11 17:18 ` Andreas Schwab
  0 siblings, 2 replies; 5+ messages in thread
From: Spencer Baugh @ 2024-01-11 16:03 UTC (permalink / raw)
  To: emacs-devel


In Emacs, process-environment (read by Lisp getenv) is distinct from C
environment variables (read by C getenv).

This means that a dynamic module which links against a library which
reads environment variables will not be affected by changes to
process-environment.

For example, if a user calls (setenv "VAR" "value") or binds
process-environment to (cons (cons "VAR" "value" process-environment)),
a getenv("VAR") in the dynamic module library won't return "value".
Likewise, if a dynamic module spawns subprocesses, they will inherit the
environment that the Emacs process started with, not the current
environment in process-environment.

This is usually unexpected, and causes difficult-to-track-down bugs,
especially for dynamic modules that spawn subprocesses or for large
dynamic modules with lots of functionality.

There are a number of possible ways to solve it:

A. Carefully track down every place that a library reads environment
   variables or spawns subprocesses, and pass in the Emacs environment
   instead.
   (but this is intractable in modules which call other libraries)

B. Advise Elisp setenv to also change the C environment
   (but this doesn't work with let-bindings of process-environment)

C. Set all variables in the C environment to match process-environment
   every time we call into the dynamic module
   (but this is slow and hurts performance)

D. Use linker tricks to replace C getenv with a version which calls back
   into Emacs.
   (but this doesn't work on other threads, since we can only call into
   Emacs from the main thread)

None of these are particularly satisfying.  I have implemented D, but
since my module uses multiple threads, it doesn't really solve the
problem for me.

Any suggestions?

Personally, I think some variation on B or C would be nicest, if it
could be done in a performant way which also works with let-bindings of
process-environment.  But I don't know how to do that.




^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: Environment variables in dynamic modules
@ 2024-01-12  0:29 Psionic K
  0 siblings, 0 replies; 5+ messages in thread
From: Psionic K @ 2024-01-12  0:29 UTC (permalink / raw)
  To: sbaugh, Emacs developers

[-- Attachment #1: Type: text/plain, Size: 1039 bytes --]

>> C. Set all variables in the C environment to match process-environment
>>    every time we call into the dynamic module
>>    (but this is slow and hurts performance)

I'm going to preface a solution to excessive redundant passing by pointing
out that the provenance of a piece of data is a requisite but something we
don't have.

Encoding input provenance in vector clocks is a solution to avoiding
unnecessary passing and maintaining caller and callee input synchronization
even when the callee is performing asynchronous work.

While we can use watch-variable for updates from Elisp, such as those done
by a package like envrc that creates buffer local environments, updates
from C don't have this convenience.

Protecting inputs from arbitrary mutations is a requirement to implement
this technique conveniently.  More likely, there need to be interfaces that
permit a logical clock and the value it versions to remain consistent.
Since the data needs to be immutable or else requires locking, coordination
with the GC is required.

[-- Attachment #2: Type: text/html, Size: 1207 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-01-12  0:29 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-11 16:03 Environment variables in dynamic modules Spencer Baugh
2024-01-11 17:02 ` Eli Zaretskii
2024-01-11 17:53   ` Spencer Baugh
2024-01-11 17:18 ` Andreas Schwab
  -- strict thread matches above, loose matches on Subject: below --
2024-01-12  0:29 Psionic K

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.