From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#64428: [PATCH] Fix flymake mode line scrolling with pixel-scroll-precision-mode Date: Thu, 06 Jul 2023 09:16:41 -0400 Message-ID: References: <87zg4eq8xn.fsf@catern.com> <83ilaxij8c.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39919"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: sbaugh@catern.com, 64428@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 06 15:17:30 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qHOrS-000A84-B0 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Jul 2023 15:17:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qHOrB-0001JR-IA; Thu, 06 Jul 2023 09:17:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHOr1-0001Io-42 for bug-gnu-emacs@gnu.org; Thu, 06 Jul 2023 09:17:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qHOr0-0001tl-Qr for bug-gnu-emacs@gnu.org; Thu, 06 Jul 2023 09:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qHOr0-00083T-By for bug-gnu-emacs@gnu.org; Thu, 06 Jul 2023 09:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Jul 2023 13:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64428 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64428-submit@debbugs.gnu.org id=B64428.168864941530947 (code B ref 64428); Thu, 06 Jul 2023 13:17:02 +0000 Original-Received: (at 64428) by debbugs.gnu.org; 6 Jul 2023 13:16:55 +0000 Original-Received: from localhost ([127.0.0.1]:40390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHOqp-000831-7Q for submit@debbugs.gnu.org; Thu, 06 Jul 2023 09:16:55 -0400 Original-Received: from mxout5.mail.janestreet.com ([64.215.233.18]:37961) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHOqk-00082l-4Z for 64428@debbugs.gnu.org; Thu, 06 Jul 2023 09:16:50 -0400 In-Reply-To: <83ilaxij8c.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 06 Jul 2023 10:37:07 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264679 Archived-At: Eli Zaretskii writes: >> From: sbaugh@catern.com >> Date: Sun, 02 Jul 2023 21:51:01 +0000 (UTC) >> >> This patch is based on the patch in bug#64425 (since I noticed this >> unrelated issue while working on that, and they touch the same code). >> >> >> >> When pixel-scroll-precision-mode is enabled, scrolling the mouse wheel >> will yield wheel-{up,down} events. flymake now binds the new events >> in addition to the old mouse-wheel-{up,down}-event. >> >> * lisp/progmodes/flymake.el:(flymake--mode-line-counter-scroll-prev, >> flymake--mode-line-counter-scroll-next, >> flymake--mode-line-counter-map): Add. >> (flymake--mode-line-counter): Use new keymap and include 'type as a >> property in the mode-line. > > Thanks. Any reason you couldn't simply add more events to the > existing code? Two reasons: 1. I initially did that but it made the code uglier. Also, this code is run every time the mode-line is updated, and adding more of that seems bad. 2. This makes describe-key work better and makes it possible for users to configure the scroll direction or add more bindings for different things.