From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#68799: 30.0.50; emacs --fg-daemon fails silently if server-start fails Date: Tue, 13 Feb 2024 13:04:24 -0500 Message-ID: References: <865xysr17s.fsf@gnu.org> <86mss4p83n.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28157"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 68799@debbugs.gnu.org, monnier@iro.umontreal.ca, jasonr@gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 13 19:05:07 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rZx9W-00072p-Gl for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Feb 2024 19:05:06 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZx9E-0004zB-7H; Tue, 13 Feb 2024 13:04:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZx9C-0004yj-D6 for bug-gnu-emacs@gnu.org; Tue, 13 Feb 2024 13:04:46 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rZx9A-0005ZJ-Sk for bug-gnu-emacs@gnu.org; Tue, 13 Feb 2024 13:04:46 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rZx9R-0001bE-TM for bug-gnu-emacs@gnu.org; Tue, 13 Feb 2024 13:05:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Feb 2024 18:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68799 X-GNU-PR-Package: emacs Original-Received: via spool by 68799-submit@debbugs.gnu.org id=B68799.17078474906121 (code B ref 68799); Tue, 13 Feb 2024 18:05:01 +0000 Original-Received: (at 68799) by debbugs.gnu.org; 13 Feb 2024 18:04:50 +0000 Original-Received: from localhost ([127.0.0.1]:46880 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZx9G-0001ae-6Z for submit@debbugs.gnu.org; Tue, 13 Feb 2024 13:04:50 -0500 Original-Received: from mxout5.mail.janestreet.com ([64.215.233.18]:34131) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZx9C-0001aP-RT for 68799@debbugs.gnu.org; Tue, 13 Feb 2024 13:04:48 -0500 In-Reply-To: <86mss4p83n.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 13 Feb 2024 19:49:48 +0200") DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1707847464; bh=lJTldqkhPwWSja3Hw8JkXJ2tRLHsSUm4R5ViZ0WsSRY=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=y6ttI/AmJsDg7BxESQJHE5RF7CxQ/8U84SOxQ4BhZGsHfF29JjdHZukzSImdrBLTt 6So4mlDtvbiE1D0fZbdCZowZ7NkBYzJVNsxrYoSeuoIdhhfRNgyXQ9CQnKmj4Ax7kD vOY+WLPYPdtAc6yJgoReJIuAbdJptOOrXl4cPvaWPkBa7wZ8Y64SrKUUNKCKeanuHF anchgKhQBIn5x71FVaND+CQllljbGApJMm/eTyNj14zn8h+DkZTxMkn7G1+AYEFYFG pvcvUizdTMr+vzce2/IIXgRMcQXE32yxB7WARZobbL+eI109+uA+33nK5UMn+xkaSb v8eZ7I6HawJCw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279972 Archived-At: Eli Zaretskii writes: >> From: Spencer Baugh >> Cc: 68799@debbugs.gnu.org, monnier@iro.umontreal.ca, jasonr@gnu.org >> Date: Tue, 13 Feb 2024 12:37:30 -0500 >> >> >> So this check really wants to be something more like: >> >> || ( IS_DAEMON && [something to check if Emacs is starting up]) >> >> || (!IS_DAEMON && FRAME_INITIAL_P (sf)) >> >> >> >> Not sure what [something to check if Emacs is starting up] should be >> >> though. >> > >> > after-init-time, I guess. But note that this still leaves a window >> > between where that is set non-nil and starting the server. >> >> Oh, actually there is a DAEMON_RUNNING define which is exactly what we >> want here. DAEMON_RUNNING just didn't exist at the time the check on >> IS_DAEMON was added. Patch using DAEMON_RUNNING attached. > > Using DAEMON_RUNNING would mean any errors while starting the server > will fail to show the explicit error message about that. That's a > regression in my book. So I hope we can find a better solution. Could you be more specific about what would regress in this situation? Preferably with a step by step of something that behaves worse. Currently the error message doesn't get shown at all, so I'm not clear what could be regressing.