all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Spencer Baugh <sbaugh@janestreet.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Dmitry Gutov <dmitry@gutov.dev>, 71179@debbugs.gnu.org
Subject: bug#71179: [PATCH] In rgrep, check matching files before excluding files
Date: Sat, 25 May 2024 09:36:44 -0400	[thread overview]
Message-ID: <iermsoeqahf.fsf@janestreet.com> (raw)
In-Reply-To: <864jamyrzy.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 25 May 2024 15:51:13 +0300")

Eli Zaretskii <eliz@gnu.org> writes:
> The ones for whom the proposed change will affect the results.

To be clear, the proposed change will not affect the content of the
results returned by rgrep or any code in grep.el.  For them, this change
has no semantic effect at all, it only speeds things up.

The only user-observable difference besides the speedup is that it fixes
a bug: grep-find-ignored-files is documented to affect rgrep, and now
that variable affects rgrep even if grep-find-template is set to a
broken value (one which doesn't include <X>).

It's unlikely anyone is relying on this buggy behavior when <X> isn't
present; the much more obvious way and documented way to achieve this
behavior is to set grep-find-ignored-files to nil (which still works
fine).

I suppose we could preserve that bug by conditioning this optimization
on (string-search "<X>" grep-find-template), though.





  parent reply	other threads:[~2024-05-25 13:36 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-24 20:14 bug#71179: [PATCH] In rgrep, check matching files before excluding files Spencer Baugh
2024-05-24 20:45 ` Dmitry Gutov
2024-05-24 20:54   ` Spencer Baugh
2024-05-25 12:31     ` Dmitry Gutov
2024-05-26  6:50       ` Juri Linkov
2024-05-26 12:48         ` Spencer Baugh
2024-05-26 12:56         ` Dmitry Gutov
2024-05-25  6:36 ` Eli Zaretskii
2024-05-25 12:26   ` Dmitry Gutov
2024-05-25 12:51     ` Eli Zaretskii
2024-05-25 13:03       ` Dmitry Gutov
2024-05-25 13:45         ` Eli Zaretskii
2024-05-25 13:58           ` Dmitry Gutov
2024-05-25 13:36       ` Spencer Baugh [this message]
2024-05-25 13:56         ` Eli Zaretskii
2024-05-25 14:02           ` Spencer Baugh
2024-05-25 14:13             ` Eli Zaretskii
2024-05-25 14:47               ` Dmitry Gutov
2024-05-25 15:07                 ` Eli Zaretskii
2024-05-26 13:42                   ` Spencer Baugh
2024-06-01 14:15                     ` Eli Zaretskii
2024-06-02 10:46                       ` Stefan Kangas
2024-05-25 14:51               ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=iermsoeqahf.fsf@janestreet.com \
    --to=sbaugh@janestreet.com \
    --cc=71179@debbugs.gnu.org \
    --cc=dmitry@gutov.dev \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.