From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#64993: 29.1; scroll-other-window breaks global-hl-line-sticky-flag Date: Tue, 01 Aug 2023 13:32:55 -0400 Message-ID: References: <83h6pi21xu.fsf@gnu.org> <83cz061z1d.fsf@gnu.org> <83a5va1xxj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18737"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 64993@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 01 19:34:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qQtGD-0004gC-OY for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 01 Aug 2023 19:34:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qQtFz-0005fC-SV; Tue, 01 Aug 2023 13:34:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQtFy-0005ey-Gr for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2023 13:34:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qQtFy-00007o-6c for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2023 13:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qQtFx-0005B5-Qy for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2023 13:34:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Aug 2023 17:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 64993-submit@debbugs.gnu.org id=B64993.169091118319837 (code B ref 64993); Tue, 01 Aug 2023 17:34:01 +0000 Original-Received: (at 64993) by debbugs.gnu.org; 1 Aug 2023 17:33:03 +0000 Original-Received: from localhost ([127.0.0.1]:48283 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQtF1-00059t-Gz for submit@debbugs.gnu.org; Tue, 01 Aug 2023 13:33:03 -0400 Original-Received: from mxout5.mail.janestreet.com ([64.215.233.18]:38857) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQtEy-00059L-Fm for 64993@debbugs.gnu.org; Tue, 01 Aug 2023 13:33:01 -0400 In-Reply-To: <83a5va1xxj.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 01 Aug 2023 20:20:56 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266466 Archived-At: Eli Zaretskii writes: >> From: Spencer Baugh >> Cc: 64993@debbugs.gnu.org >> Date: Tue, 01 Aug 2023 13:13:36 -0400 >>=20 >> Eli Zaretskii writes: >>=20 >> > global-hl-line-sticky-flag non-nil means the >> > highlight in non-selected windows is not removed: >> > (defun global-hl-line-maybe-unhighlight () >> > "Maybe deactivate the Global-Hl-Line overlay on the current line. >> > Specifically, when `global-hl-line-sticky-flag' is nil deactivate >> > all such overlays in all buffers except the current one." >> > >> > So "C-x o" leaves the highlighting overlay in the window that was >> > selected, and it will remain at the same position until that window >> > becomes selected again, because highlighting is moved only in the >> > selected window. >>=20 >> Yes, this is the implementation, and you have explained how it is buggy. > > You may think it's "buggy", but the doc string describes the "buggy" > behavior ("deactivate the overlays in all buffers except the current > one only if the flag is nil"). So it's at least documented, and one > could argue that this is the intended behavior. global-hl-line-maybe-unhighlight is an internal function of global-hl-line-mode anyway, why and how would a user ever look at its docstring? They'd be more likely to look at global-hl-line-mode's docstring, which explicitly says: If =E2=80=98global-hl-line-sticky-flag=E2=80=99 is non-nil, Global Hl-Lin= e mode highlights the line about the current buffer=E2=80=99s point in all live windows. It says nothing about "but if point moves in a non-current buffer, the highlighting stops working". Arguing about this is rather pointless since I assume you would accept a patch which fixes the behavior to work even if point moves in a non-current buffer. I just want to remove the notabug marker on this bug, and I'll get to it eventually, maybe. > >> > If you don't like these effects of global-hl-line-sticky-flag, then >> > don't use it. It's off by default, presumably due to these effects. >>=20 >> Things which are off by default can still be buggy. > > They can, yes.