all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Spencer Baugh <sbaugh@janestreet.com>
To: 69189@debbugs.gnu.org
Cc: Eli Zaretskii <eliz@gnu.org>, Juri Linkov <juri@linkov.net>
Subject: bug#69189: 30.0.50; minibuffer-visible-completions doesn't work in completing-read-multiple
Date: Wed, 07 Aug 2024 11:19:40 -0400	[thread overview]
Message-ID: <ierikwc2wdv.fsf@janestreet.com> (raw)
In-Reply-To: <iero7chs7fy.fsf@igm-qws-u22796a.mail-host-address-is-not-set> (Spencer Baugh's message of "Thu, 15 Feb 2024 17:12:33 -0500")

[-- Attachment #1: Type: text/plain, Size: 134 bytes --]


Here's a patch to fix this.

Eli, is this OK for emacs-30?  Since this is fixing a bug in a
customization which is new in Emacs 30.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Support-minibuffer-visible-completions-in-completing.patch --]
[-- Type: text/x-patch, Size: 1229 bytes --]

From 6688344ce5ffb0738751d83a4a8acc4068b453e5 Mon Sep 17 00:00:00 2001
From: Spencer Baugh <sbaugh@janestreet.com>
Date: Wed, 7 Aug 2024 11:18:02 -0400
Subject: [PATCH] Support minibuffer-visible-completions in
 completing-read-multiple

All that's required is to add minibuffer-visible-completions-map on
top of the completing-read-multiple map; this is the same thing that
minibuffer-visible-completions does in completing-read-default.

* lisp/emacs-lisp/crm.el (completing-read-multiple): Add
minibuffer-visible-completions-map (bug#69189)
---
 lisp/emacs-lisp/crm.el | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lisp/emacs-lisp/crm.el b/lisp/emacs-lisp/crm.el
index 253dfc6237a..422a8d52dcf 100644
--- a/lisp/emacs-lisp/crm.el
+++ b/lisp/emacs-lisp/crm.el
@@ -238,6 +238,11 @@ completing-read-multiple
   (let* ((map (if require-match
                   crm-local-must-match-map
                 crm-local-completion-map))
+         (map (if minibuffer-visible-completions
+                  (make-composed-keymap
+                   (list minibuffer-visible-completions-map
+                         map))
+                map))
          input)
     (minibuffer-with-setup-hook
         (lambda ()
-- 
2.39.3


  reply	other threads:[~2024-08-07 15:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-15 22:12 bug#69189: 30.0.50; minibuffer-visible-completions doesn't work in completing-read-multiple Spencer Baugh
2024-08-07 15:19 ` Spencer Baugh [this message]
2024-08-07 15:29   ` Eli Zaretskii
2024-08-07 16:53     ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ierikwc2wdv.fsf@janestreet.com \
    --to=sbaugh@janestreet.com \
    --cc=69189@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.