From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#62958: [PATCH] Set PAGER=cat in comint.el Date: Tue, 16 May 2023 15:49:21 -0400 Message-ID: References: <83edof6oln.fsf@gnu.org> <83zg724kea.fsf@gnu.org> <835y97jnfd.fsf@gnu.org> <83pm7aay70.fsf@gnu.org> <874jol1rml.fsf@catern.com> <831qjpbj8j.fsf@gnu.org> <83wn1ha220.fsf@gnu.org> <83sfc5a1ag.fsf@gnu.org> <83pm79a103.fsf@gnu.org> <83mt2d9vsx.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13345"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: sbaugh@catern.com, 62958@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 16 21:58:44 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pz0ol-0003Ep-Pr for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 May 2023 21:58:43 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pz0gc-0007Fx-Pw; Tue, 16 May 2023 15:50:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pz0gM-0006vk-O4 for bug-gnu-emacs@gnu.org; Tue, 16 May 2023 15:50:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pz0gM-0004Wv-AD for bug-gnu-emacs@gnu.org; Tue, 16 May 2023 15:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pz0gL-0006Tc-VF for bug-gnu-emacs@gnu.org; Tue, 16 May 2023 15:50:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 May 2023 19:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62958 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 62958-submit@debbugs.gnu.org id=B62958.168426657024852 (code B ref 62958); Tue, 16 May 2023 19:50:01 +0000 Original-Received: (at 62958) by debbugs.gnu.org; 16 May 2023 19:49:30 +0000 Original-Received: from localhost ([127.0.0.1]:48138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pz0fq-0006Sm-Ap for submit@debbugs.gnu.org; Tue, 16 May 2023 15:49:30 -0400 Original-Received: from mxout5.mail.janestreet.com ([64.215.233.18]:57113) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pz0fm-0006SX-LZ for 62958@debbugs.gnu.org; Tue, 16 May 2023 15:49:28 -0400 In-Reply-To: <83mt2d9vsx.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 09 May 2023 21:58:06 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261812 Archived-At: Eli Zaretskii writes: >> From: Spencer Baugh >> Cc: sbaugh@catern.com, 62958@debbugs.gnu.org >> Date: Tue, 09 May 2023 13:13:56 -0400 >> >> Eli Zaretskii writes: >> >> >> From: Spencer Baugh >> >> Date: Tue, 9 May 2023 13:01:07 -0400 >> >> Cc: sbaugh@catern.com, 62958@debbugs.gnu.org >> >> >> >> I'm asking why this is not already obvious from the fact that this is >> >> a defcustom, by default off. All your addition says is "don't disable >> >> paging in all cases, sometimes it can be useful". But we already said >> >> that, in effect, by making the paging enabled by default. So there's >> >> no reason to have that text, as it isn't instrumental, and doesn't add >> >> anything. >> >> >> >> How does "this is a defcustom, by default off" communicate "you should use vc-print-log if you turn this >> >> on"? >> > >> > Why are we suddenly talking about vc-print-log when discussing a much >> > more general feature? >> >> Because disabling pagination effectively breaks the shell command "git >> log" and vc-print-log is one alternative to running "git log", and I >> don't know how else the user would realize that. (In my experience with >> talking to users about this, they usually don't) > > A doc string of a general option is not the proper place for talking > about some very specific case when that option is used. If the main > problem is vc-print-log, we should find another way of dealing with > it. OK, how about this doc string? "If non-nil, the program to use for pagination of program output. Some programs produce large amounts of output, and have provision for pagination of their output through a filter program, commonly known as a \"pager\". The pager limits the amount of output produced and allows the user to interactively browse the output one page at a time. Some programs paginate their output by default, by always starting a pager. The program they use as the pager is specified by the environment variable PAGER; if that variable is not defined, they use some fixed default, such as \"less\". The interactive browsing aspects of pagination are not needed, and get in the way, when the output of the program is directed to an Emacs buffer, so in those cases pagination might need to be disabled. Disabling pagination means that some programs will produce large amounts of output, but most such programs have other ways to limit their output, such as additional arguments or Emacs interfaces. To disable pagination, this variable's value should be a string that names a program, such as \"cat\", which passes through all of the output without any filtering or delays. Comint will then set the PAGER variable to name that program, when it invokes external programs."