From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#62663: 28.2; vc-hg-state returns incorrect results on directories in some repos Date: Tue, 04 Apr 2023 10:05:19 -0400 Message-ID: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27852"; mail-complaints-to="usenet@ciao.gmane.io" To: 62663@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 04 16:06:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pjhIe-0006nA-P6 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Apr 2023 16:06:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pjhIT-0007fP-8A; Tue, 04 Apr 2023 10:06:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjhIR-0007WK-9T for bug-gnu-emacs@gnu.org; Tue, 04 Apr 2023 10:06:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pjhIQ-0007kp-Tf for bug-gnu-emacs@gnu.org; Tue, 04 Apr 2023 10:06:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pjhIQ-0001ct-A3 for bug-gnu-emacs@gnu.org; Tue, 04 Apr 2023 10:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Apr 2023 14:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 62663 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16806171276202 (code B ref -1); Tue, 04 Apr 2023 14:06:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 4 Apr 2023 14:05:27 +0000 Original-Received: from localhost ([127.0.0.1]:49947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pjhHq-0001by-MS for submit@debbugs.gnu.org; Tue, 04 Apr 2023 10:05:27 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:49036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pjhHo-0001bn-2Z for submit@debbugs.gnu.org; Tue, 04 Apr 2023 10:05:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjhHn-0006Hy-Nk for bug-gnu-emacs@gnu.org; Tue, 04 Apr 2023 10:05:23 -0400 Original-Received: from mxout5.mail.janestreet.com ([64.215.233.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjhHl-0007Ni-1r for bug-gnu-emacs@gnu.org; Tue, 04 Apr 2023 10:05:23 -0400 Received-SPF: pass client-ip=64.215.233.18; envelope-from=sbaugh@janestreet.com; helo=mxout5.mail.janestreet.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259234 Archived-At: The problem is with vc-hg-state-fast, which parses Mercurial data structures instead of shelling out to hg. This is a great idea but our parsing seems to be wrong right now in some way. 1. Create a new hg repo with: hg init --config format.use_share_safe=false --config format.use-persistent-nodemap=false --config format.sparse-revlog=false --config format.revlog-compression=zlib (This is disabling some recent hg features which make vc-hg-state use the slow path. You can verify that vc-hg-state-fast is going to run by checking that .hg/requirements is a subset of vc-hg-supported-requirements) 2. touch foo && hg add foo && hg commit -m. 3. (vc-hg-state-slow ".") Returns 'up-to-date which is correct (because it shells out to hg) 4. (vc-hg-state ".") Returns 'unregistered which is wrong To a user, this manifests as various hg commands failing with errors, often something like "vc-find-backend-function: Cannot open load file: No such file or directory, vc-nil" This also happens on Emacs 29. (Note that this is independent of my other bug about lack of support for certain repo requirements. That bug is about expanding vc-hg-state-fast support to new repos; this bug is showing that the already existing support is buggy!) In GNU Emacs 28.2 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.15.12, Xaw scroll bars) of 2023-02-09 built on igm-qws-u12685a Repository revision: 739b5d0e52d83ec567bd61a5a49ac0e93e0eb469 Repository branch: HEAD Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: CentOS Linux 7 (Core) Configured using: 'configure --with-x-toolkit=lucid --without-gpm --without-gconf --without-selinux --without-imagemagick --with-modules --with-gif=no --with-cairo --with-rsvg --prefix=/j/office/app/emacs/builds/28.2-20230209-135825' Configured features: CAIRO DBUS FREETYPE GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM LUCID ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Dired by name Minor modes in effect: shell-dirtrack-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug sendmail dabbrev pp cl-print log-edit message rmc puny rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail rmail-loaddefs auth-source eieio eieio-core cl-macs eieio-loaddefs password-cache json map time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log shell pcomplete comint ansi-color ring misearch multi-isearch jka-compr find-func shortdoc text-property-search vc-annotate vc-filewise thingatpt help-fns radix-tree help-mode cl-seq vc-mtn vc-hg vc-git diff-mode easy-mmode vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs vc-dir seq byte-opt gv bytecomp byte-compile cconv ewoc vc vc-dispatcher dired-aux cl-loaddefs cl-lib dired dired-loaddefs iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 119456 11097) (symbols 48 13754 1) (strings 32 40872 1164) (string-bytes 1 1248921) (vectors 16 18713) (vector-slots 8 234707 16776) (floats 8 86 32) (intervals 56 1922 0) (buffers 992 25) (heap 1024 18673 1560))