bug#61857: 30.0.50; fido-mode breaks org-goto-location

bug#61857: 30.0.50; fido-mode breaks org-goto-location

[Spencer Baugh]

1. Create an org-mode buffer containing:
* foo
** bar
2. C-u C-c C-j (to run org-goto-location)
3. Completion of the full "foo/bar/" path works;
   i.e. one can input f TAB b TAB to input the path.
4. M-x fido-mode
5. C-u C-c C-j (to run org-goto-location)
6. Only "foo/" can be completed; once "foo/" is entered or completed,
  "bar/" cannot be subsequently completed.


In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.22.30, cairo version 1.15.12) of 2023-02-27 built on igm-qws-u22796a
Repository revision: af94369f90a5d3ad44dcc80d205665ccb2d41995
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: CentOS Linux 7 (Core)

Configured using:
 'configure --with-gif=ifavailable'

Configured features:
CAIRO DBUS FREETYPE GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
LIBSELINUX LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND
SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XINPUT2 XPM GTK3
ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
epg-config gnus-util text-property-search time-date subr-x mm-decode
mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader
cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric
uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-bar mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify
dynamic-setting system-font-setting font-render-setting cairo
move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process
emacs)

Memory information:
((conses 16 50069 5935)
 (symbols 48 7444 0)
 (strings 32 17714 1847)
 (string-bytes 1 502612)
 (vectors 16 9305)
 (vector-slots 8 148048 8276)
 (floats 8 35 18)
 (intervals 56 210 0)
 (buffers 976 10)
 (heap 1024 17034 3303))

bug#61857: 30.0.50; fido-mode breaks org-goto-location

[Eli Zaretskii]

> From: Spencer Baugh <sbaugh@janestreet.com>
> Date: Mon, 27 Feb 2023 16:16:25 -0500
> 
> 
> 1. Create an org-mode buffer containing:
> * foo
> ** bar
> 2. C-u C-c C-j (to run org-goto-location)
> 3. Completion of the full "foo/bar/" path works;
>    i.e. one can input f TAB b TAB to input the path.
> 4. M-x fido-mode
> 5. C-u C-c C-j (to run org-goto-location)
> 6. Only "foo/" can be completed; once "foo/" is entered or completed,
>   "bar/" cannot be subsequently completed.

Is it definitely a problem with fido-mode, not with org-goto-location?

bug#61857: 30.0.50; fido-mode breaks org-goto-location

[Ihor Radchenko]

Eli Zaretskii <eliz@gnu.org> writes:

>> 6. Only "foo/" can be completed; once "foo/" is entered or completed,
>>   "bar/" cannot be subsequently completed.
>
> Is it definitely a problem with fido-mode, not with org-goto-location?

I can reproduce and track things down to the call to
`org-olpath-completing-read'. I see nothing obviously wrong there on Org
side.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>