From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#68801: 30.0.50; minibuffer-visible-completions=t makes RET in completion-in-region a no-op with nothing selected Date: Mon, 29 Jan 2024 13:49:53 -0500 Message-ID: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26601"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Juri Linkov To: 68801@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 29 19:51:16 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rUWiy-0006gZ-9h for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 29 Jan 2024 19:51:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rUWih-000344-Kd; Mon, 29 Jan 2024 13:51:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUWic-00033m-4O for bug-gnu-emacs@gnu.org; Mon, 29 Jan 2024 13:50:54 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rUWib-0005iL-S2 for bug-gnu-emacs@gnu.org; Mon, 29 Jan 2024 13:50:53 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rUWik-0001pf-83 for bug-gnu-emacs@gnu.org; Mon, 29 Jan 2024 13:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Jan 2024 18:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 68801 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.17065542146985 (code B ref -1); Mon, 29 Jan 2024 18:51:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 29 Jan 2024 18:50:14 +0000 Original-Received: from localhost ([127.0.0.1]:33469 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUWhx-0001ob-CM for submit@debbugs.gnu.org; Mon, 29 Jan 2024 13:50:13 -0500 Original-Received: from lists.gnu.org ([2001:470:142::17]:33886) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUWhu-0001oL-Sm for submit@debbugs.gnu.org; Mon, 29 Jan 2024 13:50:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUWhg-0002wH-SM for bug-gnu-emacs@gnu.org; Mon, 29 Jan 2024 13:49:56 -0500 Original-Received: from mxout5.mail.janestreet.com ([64.215.233.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUWhe-0005GM-Ts for bug-gnu-emacs@gnu.org; Mon, 29 Jan 2024 13:49:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1706554193; bh=2i0xob/uXWEnczp1uTOMspE+GGEN3vXcTRr1su9MgH0=; h=From:To:Cc:Subject:Date; b=ObI1Us/VCE/5QVD3tD//spJlwrNHPc2/EU1MkKYdhveEnpSuXTqq/tSq+y9owlsST ltOrWEK9qy+wWQ5zXr3mA9U3xuMKdUDBxQcwcN80ywVZp5gjODsECnuOoaydCozQkX g3xgXKZYunhZIMf3vYcmtvDPKRmP2uMhcuyXkrrkbWKBNDusvVXjbXWH7noQHRmohS MU13CZtbzkL7NEs1cUg5mQtCVEYsJ1WpGngVjrJEWX4/Hw1OgNX7g1tZ+Eepj+R4AO chM6dI9Ml6tD3PT1ZZLeuxSf4FnQtsGP9vRLuq+FsaAbLqhGl3J5DjTdruQ5Rws++Q CQkTkyHZ4tUwQ== Received-SPF: pass client-ip=64.215.233.18; envelope-from=sbaugh@janestreet.com; helo=mxout5.mail.janestreet.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279140 Archived-At: 1. emacs -Q 2. In scratch: (current- M- 3. Observe *Completions* pops up. 4. RET 5. *Completions* goes away and a newline is inserted. Compare: 1. emacs -Q --eval '(setq minibuffer-visible-completions t)' 2. In scratch: (current- M- 3. Observe *Completions* pops up. 4. RET 5. *Completions* goes away but no newline is inserted, and "No match" is printed. I think the behavior with minibuffer-visible-completions=t is unintuitive. And it just duplicates what you can achieve with C-g (closes *Completions*), so it's not very useful. Even if I do: (current- M- buf RET which is sufficient to uniquely identify current-buffer, RET does not complete to current-buffer, instead it just says "No match". With minibuffer-visible-completions=t, I suggest RET with no completion selected in completion-in-region should exit completion and insert a newline. Or maybe, slightly more radically, RET with no completion selected in completion-in-region should select the first matching completion given the current completion region? At least one user expected that behavior. Another alternative is that RET doesn't close *Completions* at all, which would match minibuffer behavior better. I'm not a huge fan of that, but it's more useful than the current behavior of RET. Since there are a few alternatives, perhaps we could have a defcustom for the RET behavior in completion-in-region. I think the default should be closing *Completions* and inserting a newline, since that matches minibuffer-visible-completions=nil. If this sounds reasonable I can write a patch implementing these. In GNU Emacs 30.0.50 (build 24, x86_64-pc-linux-gnu, X toolkit, cairo version 1.15.12, Xaw scroll bars) of 2024-01-29 built on igm-qws-u22796a Repository revision: cbc8bdc1386a4bc9c420d8ab06b844c6f6928c35 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Rocky Linux 8.9 (Green Obsidian) Configured using: 'configure -C 'CFLAGS=-O0 -g3' --with-gif=ifavailable --with-x-toolkit=lucid' Configured features: CAIRO DBUS FREETYPE GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XINPUT2 XPM LUCID ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr dabbrev emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo x-toolkit xinput2 x multi-tty move-toolbar make-network-process emacs) Memory information: ((conses 16 65716 19738) (symbols 48 9598 0) (strings 32 22938 2513) (string-bytes 1 684815) (vectors 16 9358) (vector-slots 8 112024 10425) (floats 8 42 15) (intervals 56 264 0) (buffers 976 10))