From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#68514: 30.0.50; minibuffer-choose-completion + elisp-c-a-p delete next sexp when completing after open paren Date: Wed, 17 Jan 2024 13:10:36 -0500 Message-ID: References: <86ply1npno.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29234"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: dmitry@gutov.dev, 68514@debbugs.gnu.org, Juri Linkov To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 17 19:11:21 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rQANl-0007Po-Fl for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Jan 2024 19:11:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rQANU-0002i8-Mf; Wed, 17 Jan 2024 13:11:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQANR-0002hY-LZ for bug-gnu-emacs@gnu.org; Wed, 17 Jan 2024 13:11:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rQANR-0003ZN-Cu for bug-gnu-emacs@gnu.org; Wed, 17 Jan 2024 13:11:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rQANS-0005PQ-AJ for bug-gnu-emacs@gnu.org; Wed, 17 Jan 2024 13:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Jan 2024 18:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68514 X-GNU-PR-Package: emacs Original-Received: via spool by 68514-submit@debbugs.gnu.org id=B68514.170551504620758 (code B ref 68514); Wed, 17 Jan 2024 18:11:02 +0000 Original-Received: (at 68514) by debbugs.gnu.org; 17 Jan 2024 18:10:46 +0000 Original-Received: from localhost ([127.0.0.1]:53309 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rQANC-0005Ok-Gy for submit@debbugs.gnu.org; Wed, 17 Jan 2024 13:10:46 -0500 Original-Received: from mxout5.mail.janestreet.com ([64.215.233.18]:51587) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rQANA-0005OX-7M for 68514@debbugs.gnu.org; Wed, 17 Jan 2024 13:10:44 -0500 In-Reply-To: (Stefan Monnier's message of "Wed, 17 Jan 2024 12:53:39 -0500") DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1705515037; bh=dRvgiLPwgE6MkhSJgoEFxR4KQxDiNAI0aTINcJRQM8Y=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=B+cJ4YzVwZpIjq6x6yy3oNrlONGsiCJ3lOHjgXwVe+Tc1pSpkJfrigswapVcHcuex EEkXjPipvRgISF1lDCEtYqbB1DXMx82sorZm9cYlNmBrSlGE23QGQMgX1RXncKfW62 DpmOb8h1FVm6MDpq6tFabkjlureEvGcSEXX7xzbmjMKmZwCMpj69SwcRTQdXwlV7cZ Zb/8SSzL/lJRrPgSA499A/6mK1D38YfgJcL1ekUV3zalJzvx1sLK51rGLxwMxgP7fC cKEYYbNhcPqF5OZrAlGZDWaRAKdaeaQ5u83cbW/F737fdj7uZkYM4rSDWmBXh0bMUV Zwc3t8uAVpYVA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278401 Archived-At: Stefan Monnier writes: >> That doesn't seem like an improvement, and also it >> reverts 0db2126d7176b0bd1b13d4b0d1cd958c8cf55714 which explicitly did >> the opposite. > > Then maybe... > > > Stefan > > > diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el > index 00910fb67c7..da0cb96e1cf 100644 > --- a/lisp/progmodes/elisp-mode.el > +++ b/lisp/progmodes/elisp-mode.el > @@ -657,12 +657,13 @@ elisp-completion-at-point > (save-excursion > (backward-sexp 1) > (skip-chars-forward "`',=E2=80=98#") > - (point)) > + (min (point) pos)) > (scan-error pos))) > (end > - (unless (or (eq beg (point-max)) > - (member (char-syntax (char-after beg)) > - '(?\" ?\())) > + (cond > + ((and (< beg (point-max)) > + (memq (char-syntax (char-after beg)) > + '(?w ?\\ ?_))) > (condition-case nil > (save-excursion > (goto-char beg) > @@ -670,7 +671,11 @@ elisp-completion-at-point > (skip-chars-backward "'=E2=80=99") > (when (>=3D (point) pos) > (point))) > - (scan-error pos)))) > + (scan-error pos))) > + ((or (>=3D beg (point-max)) > + (memq (char-syntax (char-after beg)) > + '(?\) ?\s))) > + beg))) > ;; t if in function position. > (funpos (eq (char-before beg) ?\()) > (quoted (elisp--form-quoted-p beg)) Yes, seems great, that seems like what 0db2126d7176b0bd1b13d4b0d1cd958c8cf55714 should have done in the first place. Incidentally, are these (point-max) checks necessary? We're not doing anything that can cause us to leave the narrowed region, I think.