From: Dan Espen <despen@verizon.net>
To: help-gnu-emacs@gnu.org
Subject: Re: custom-themes BAD?
Date: Tue, 25 Feb 2014 14:48:31 -0500 [thread overview]
Message-ID: <iczjlfas8g.fsf@home.home> (raw)
In-Reply-To: mailman.16038.1393356841.10748.help-gnu-emacs@gnu.org
Rainer M Krug <Rainer@krugs.de> writes:
> Dan Espen <despen@verizon.net> writes:
>> If you use manoj-dark theme, then switch to another theme,
>> manoj will leave behind a huge number of it's customizations,
>> since other themes don't set as many fonts.
>
> Now this is an important point and raises one question: there is a
> load-theme function - but not an unload-theme which removes the
> customizations done by the package? An author of a theme can not be
> expected to undo all changes another theme might have done - but one
> could expect a package author to provide a function which unloads the
> theme and restores the theme used before, or simply reset to the default
> values.
>
> IMO, this is the problem with themes.
It should be a simple matter for all themes to run a hook that removes
the previous theme. Then have each theme define it's own hook function.
But removing a face won't revert to the prior face, so each theme would
have to query the current setting, then save it in the hook function
for removal.
I think it would be far easier to just have a set of about 20 or 30 faces
that a theme is expected to set so the next theme can override those
same 20 to 30 faces. Note, I'm not claiming 20 to 30 faces would be
sufficient, but manoj-dark is almost 800 lines long. Certainly no one
needs or wants 800 different faces.
--
Dan Espen
next prev parent reply other threads:[~2014-02-25 19:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 17:08 custom-themes BAD? Dan Espen
2014-02-25 17:22 ` Joost Kremers
2014-02-25 17:38 ` E Sabof
2014-02-25 17:54 ` Dan Espen
[not found] ` <mailman.16024.1393350344.10748.help-gnu-emacs@gnu.org>
2014-02-25 18:06 ` Dan Espen
2014-02-25 17:35 ` Drew Adams
[not found] ` <mailman.16021.1393349758.10748.help-gnu-emacs@gnu.org>
2014-02-25 18:03 ` Dan Espen
2014-02-25 19:33 ` Rainer M Krug
[not found] ` <mailman.16038.1393356841.10748.help-gnu-emacs@gnu.org>
2014-02-25 19:48 ` Dan Espen [this message]
2014-02-25 20:04 ` Rainer M Krug
2014-02-25 21:05 ` W. Greenhouse
2014-02-25 22:19 ` Drew Adams
[not found] <<ic1tyrdsrh.fsf@home.home>
[not found] ` <<slrnlgpkad.3j2.joost.m.kremers@j.kremers4.news.arnhem.chello.nl>
2014-02-25 17:45 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=iczjlfas8g.fsf@home.home \
--to=despen@verizon.net \
--cc=help-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.