Re: Reverting but keeping undo

[Dan Espen <despen@verizon.net>]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> I assume this change kills off the old confirmation about reverting.
>
> No, it doesn't.  I never made the connection between the two in
> my mind.  But I think you're on to something.
>
> FWIW, here's what I use for the revert-buffer confirmation:
>
> (advice-add 'revert-buffer :before
>             (lambda (&rest _)
>               (interactive (list (not current-prefix-arg)
>                                  ;; Don't request confirmation if the
>                                  ;; user just hit M-x revert-buffer RET.
>                                  (eq last-command-event ?\r)))
>               nil))

Sorry for the previous typo which I just noticed, I meant to type:

"First Stefan thanks for the explanation."

I just used:

(defun my-revert()
  (interactive)
  (message "Reverting buffer from %s" buffer-file-name)
  (revert-buffer nil 1)
  (message "Done"))

and bound it to a key.


With undo for reverts, I can't think of a good reason for the
confirmation.  Some kind of notice in the mini buffer is still
a good idea.


-- 
Dan Espen