From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Espen Newsgroups: gmane.emacs.help Subject: custom-themes BAD? Date: Tue, 25 Feb 2014 12:08:50 -0500 Organization: A noiseless patient Spider Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1393348211 30774 80.91.229.3 (25 Feb 2014 17:10:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 25 Feb 2014 17:10:11 +0000 (UTC) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Tue Feb 25 18:10:20 2014 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WILWN-0000NY-QG for geh-help-gnu-emacs@m.gmane.org; Tue, 25 Feb 2014 18:10:19 +0100 Original-Received: from localhost ([::1]:36090 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WILWN-0007vw-9e for geh-help-gnu-emacs@m.gmane.org; Tue, 25 Feb 2014 12:10:19 -0500 Original-Path: usenet.stanford.edu!news.kjsl.com!feeder.erje.net!us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!eternal-september.org!feeder.eternal-september.org!news.eternal-september.org!.POSTED!not-for-mail Original-Newsgroups: gnu.emacs.help Original-Lines: 66 Injection-Info: mx05.eternal-september.org; posting-host="189748f827f5005aa08ac3cba2786117"; logging-data="3696"; mail-complaints-to="abuse@eternal-september.org"; posting-account="U2FsdGVkX18gPNaad2ue1Om5WP0gDThVkPmBvzVMJuk=" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) Cancel-Lock: sha1:5hvUlOxXi9HN8sgeCASGx3aFDPU= sha1:SJlOdk5/dZB3BxlSw3TBktqyJPA= Original-Xref: usenet.stanford.edu gnu.emacs.help:203923 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:96192 Archived-At: Custom-themes look to me like they are BAD (Broken As Designed). I'm running Emacs 24.3.1 here and this is what I see in the themes directory: 5089 Jan 1 2013 adwaita-theme.el 6434 Jan 1 2013 deeper-blue-theme.el 6048 Jan 1 2013 dichromacy-theme.el 2885 Jan 1 2013 light-blue-theme.el 40948 Jan 1 2013 manoj-dark-theme.el 5167 Jan 1 2013 misterioso-theme.el 7720 Jan 1 2013 tango-dark-theme.el 7080 Jan 1 2013 tango-theme.el 3550 Jan 1 2013 tsdh-dark-theme.el 3357 Jan 1 2013 tsdh-light-theme.el 3680 Jan 1 2013 wheatgrass-theme.el 5165 Jan 1 2013 whiteboard-theme.el 5287 Jan 1 2013 wombat-theme.el Notice that one theme, (manoj-dark) is way bigger than any of the other themes. Looking in these files, I see that each theme designer decides which Emacs packages he's going to support. The more packages supported, the bigger the theme file. I think the fault lies with the base package for fonts Emacs defines. The basic faces were the font-lock faces, builtin, constant, preprocessor, etc. When we get to packages like gnus, gnus goes ahead and defines it's own faces: gnus-cite-attribution-face gnus-cite-face-1 gnus-cite-face-2 gnus-cite-face-3 gnus-cite-face-4 gnus-cite-face-5 gnus-cite-face-6 gnus-cite-face-7 gnus-cite-face-8 gnus-cite-face-9 gnus-cite-face-10 gnus-cite-face-11 gnus-emphasis-bold gnus-emphasis-bold-italic That's the problem, there should be font-lock faces like: font-lock-bold, font-lock-level-1 thru 12, font-lock-large-1,,, font-lock-blue... font-lock-reverse and so on. All the packages should be using font-lock-* faces as far as possible. Then the themes can all set the same set of faces much more easily. -- Dan Espen