From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#30431: 27.0.50; "Work even if libpng is install in /usr/local" causes build failure Date: Mon, 12 Feb 2018 14:13:02 -0500 Message-ID: References: <87y3jypw87.fsf@cochranmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1518463914 22508 195.159.176.226 (12 Feb 2018 19:31:54 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 12 Feb 2018 19:31:54 +0000 (UTC) User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Cc: Paul Eggert , 30431@debbugs.gnu.org To: Robert Cochran Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 12 20:31:50 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1elJpA-0004lv-Dn for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Feb 2018 20:31:36 +0100 Original-Received: from localhost ([::1]:43095 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elJrC-0005LU-5P for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Feb 2018 14:33:42 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elJZ9-0005dk-3q for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2018 14:15:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1elJZ8-0000Jx-2g for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2018 14:15:03 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60369) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1elJZ7-0000JL-UJ for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2018 14:15:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1elJZ7-0006bZ-LL for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2018 14:15:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Feb 2018 19:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30431 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30431-submit@debbugs.gnu.org id=B30431.151846284725317 (code B ref 30431); Mon, 12 Feb 2018 19:15:01 +0000 Original-Received: (at 30431) by debbugs.gnu.org; 12 Feb 2018 19:14:07 +0000 Original-Received: from localhost ([127.0.0.1]:40033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1elJYF-0006aH-9n for submit@debbugs.gnu.org; Mon, 12 Feb 2018 14:14:07 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:41236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1elJYE-0006Zs-62 for 30431@debbugs.gnu.org; Mon, 12 Feb 2018 14:14:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1elJY8-0006qE-2H for 30431@debbugs.gnu.org; Mon, 12 Feb 2018 14:14:00 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36258) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elJXE-0005Dm-Ut; Mon, 12 Feb 2018 14:13:05 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1elJXC-0006Qp-Pa; Mon, 12 Feb 2018 14:13:03 -0500 X-Spook: Tony Blair Mudslide BLU-97 A/B Bruxelles Biological Hugo X-Ran: Goo/D1N0]ojVACx (Robert Cochran's message of "Sun, 11 Feb 2018 22:18:00 -0800") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:143217 Archived-At: AFAICS, the issue is that the CHECK_MODULES method sets PNG_LIBS (and PNG_CFLAGS), whereas the old method sets LIBPNG (and PNG_CFLAGS). So revert the reversion, and then apply eg: --- a/configure.ac +++ b/configure.ac @@ -3613,7 +3613,9 @@ elif test "${with_png}" != no; then AC_CHECK_HEADER([png.h], [HAVE_PNG=yes]) elif test "${HAVE_X11}" = "yes" || test "${HAVE_W32}" = "yes"; then EMACS_CHECK_MODULES([PNG], [libpng >= 1.0.0]) - if test $HAVE_PNG = no; then + if test $HAVE_PNG = yes; then + LIBPNG="$PNG_LIBS" + else # Test old way in case pkg-config doesn't have it (older machines). AC_MSG_CHECKING([for libpng not configured by pkg-config]) (Might want to move the "append -lz to LIBPNG" to outside the conditional too.)