bug#17069: 24.4.50; HAVE_GLIB is not defined when gfilenotify is the only user

bug#17069: 24.4.50; HAVE_GLIB is not defined when gfilenotify is the only user

[YAMAMOTO Mitsuharu]

Steps to reproduce:

  1. Install glib.
  2. ./configure --with-x-toolkit=athena --without-rsvg

Result:

  In src/config.h, HAVE_GFILENOTIFY is defined, but not for HAVE_GLIB.
  (I guess the latter is necessary for proper gfilenotify support.)

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

In GNU Emacs 24.4.50.1 (i686-pc-linux-gnu, X toolkit, Xaw scroll bars)
 of 2014-03-23 on ubuntu
Repository revision: 116853 dancol@dancol.org-20140323060236-dtlsz33veq7asjfb
Windowing system distributor `The X.Org Foundation', version 11.0.11103000
System Description:	Ubuntu 12.04.4 LTS

Configured using:
 `configure --with-x-toolkit=athena --without-rsvg'

bug#17069: Fixed

[Daniel Colascione]

[-- Attachment #1: Type: text/plain, Size: 28 bytes --]

Fixed in trust r116856..


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]

bug#17069: Fixed

[Eli Zaretskii]

> Date: Sun, 23 Mar 2014 02:24:32 -0700
> From: Daniel Colascione <dancol@dancol.org>
> 
> Fixed in trust r116856..

Thanks, but why on the trunk?  The same problem exists on the release
branch, no?

bug#17069: Fixed

[Glenn Morris]

In any case, can I again prod people to put

Version: 24.5

(or whatever) at the start of their -done messages.
Because otherwise when someone looks at

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17069

a year from now, they have a hard time figuring out which Emacs release
the fix is supposed to be in.

bug#17069: Fixed

[Juanma Barranquero]

On Sun, Mar 23, 2014 at 7:34 PM, Glenn Morris <rgm@gnu.org> wrote:

> In any case, can I again prod people to put
>
> Version: 24.5
>
> (or whatever) at the start of their -done messages.

Does that work in all -done messages (I mean, not Bcc:ed to
control@debbugs.org)?

I'm asking because AFAICS, admin/notes/bugtracker only mentions
Version: in the context of reporting new bugs. Elsewhere it refers to
the "fixed BUGNO VERSION" control syntax, not pseudo-headers.

bug#17069: Fixed

[Glenn Morris]

Juanma Barranquero wrote:

> On Sun, Mar 23, 2014 at 7:34 PM, Glenn Morris <rgm@gnu.org> wrote:
>
>> In any case, can I again prod people to put
>>
>> Version: 24.5
>>
>> (or whatever) at the start of their -done messages.
>
> Does that work in all -done messages (I mean, not Bcc:ed to
> control@debbugs.org)?

Yes. In fact, only in such messages.

bug#17069: Fixed

[Juanma Barranquero]

On Mon, Mar 24, 2014 at 12:24 AM, Glenn Morris <rgm@gnu.org> wrote:

> Yes. In fact, only in such messages.

Good to know, thanks.

I'd suggest adding that info to admin/notes/bugtracker, BTW.

bug#17069: Fixed

[Glenn Morris]

Eli Zaretskii wrote:

>> Date: Sun, 23 Mar 2014 02:24:32 -0700
>> From: Daniel Colascione <dancol@dancol.org>
>> 
>> Fixed in trust r116856..
>
> Thanks, but why on the trunk?  The same problem exists on the release
> branch, no?

I also think this should be in emacs-24.
Please could someone backport it?