bug#956: In CVS Emacs, replace-regexp doesn't honor inhibit-read-only.

bug#956: In CVS Emacs, replace-regexp doesn't honor inhibit-read-only.

[Francis Litterio]

In CVS Emacs, replace-regexp doesn't honor inhibit-read-only.  To
reproduce, evaluate this form:

   (let ((inhibit-read-only t))
     (with-current-buffer (get-buffer-create "zzz")
       (insert "fooxxxbar")
       (replace-regexp "x+" "z" nil (point-min) (point-max))))

You will see this error: Buffer is read-only: #<buffer zzz>

This may be caused by this code in function perform-replace (in
lisp/replace.el):

   (let ((inhibit-read-only
          query-replace-skip-read-only))

The docstring for query-replace-skip-read-only says:

   *Non-nil means `query-replace' and friends ignore read-only matches.

which does not seem to match how it is used in that let form, especially
since replace-regexp is not interactive like query-replace.
--
Fran

bug#956: marked as done (In CVS Emacs, replace-regexp doesn't honor inhibit-read-only.)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 881 bytes --]


Your message dated Wed, 10 Sep 2008 18:20:31 -0400
with message-id <873ak78wy8.fsf@cyd.mit.edu>
and subject line Re: In CVS Emacs, replace-regexp doesn't honor inhibit-read-only.
has caused the Emacs bug report #956,
regarding In CVS Emacs, replace-regexp doesn't honor inhibit-read-only.
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
956: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=956
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 2708 bytes --]

From: Francis Litterio <flitterio@gmail.com>
To: bug-gnu-emacs@gnu.org
Subject: In CVS Emacs, replace-regexp doesn't honor inhibit-read-only.
Date: Wed, 10 Sep 2008 11:44:32 -0400
Message-ID: <i5i6fxo82dej.fsf@gmail.com>

In CVS Emacs, replace-regexp doesn't honor inhibit-read-only.  To
reproduce, evaluate this form:

   (let ((inhibit-read-only t))
     (with-current-buffer (get-buffer-create "zzz")
       (insert "fooxxxbar")
       (replace-regexp "x+" "z" nil (point-min) (point-max))))

You will see this error: Buffer is read-only: #<buffer zzz>

This may be caused by this code in function perform-replace (in
lisp/replace.el):

   (let ((inhibit-read-only
          query-replace-skip-read-only))

The docstring for query-replace-skip-read-only says:

   *Non-nil means `query-replace' and friends ignore read-only matches.

which does not seem to match how it is used in that let form, especially
since replace-regexp is not interactive like query-replace.
--
Fran




[-- Attachment #3: Type: message/rfc822, Size: 1085 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Francis Litterio <flitterio@gmail.com>
Cc: 956-done@emacsbugs.donarmstrong.com
Subject: Re: In CVS Emacs, replace-regexp doesn't honor inhibit-read-only.
Date: Wed, 10 Sep 2008 18:20:31 -0400
Message-ID: <873ak78wy8.fsf@cyd.mit.edu>

> In CVS Emacs, replace-regexp doesn't honor inhibit-read-only.

Thanks for spotting this.  I've checked in a fix.

bug#956: In CVS Emacs, replace-regexp doesn't honor inhibit-read-only.

[Francis Litterio]

I wrote:

> In CVS Emacs, replace-regexp doesn't honor inhibit-read-only.  To
> reproduce, evaluate this form:
>
>    (let ((inhibit-read-only t))
>      (with-current-buffer (get-buffer-create "zzz")
>        (insert "fooxxxbar")
>        (replace-regexp "x+" "z" nil (point-min) (point-max))))

Of course, that should have been:

     (let ((inhibit-read-only t))
       (with-current-buffer (get-buffer-create "zzz")

         (toggle-read-only 1)  ;; Forgot this in my original report!

         (insert "fooxxxbar")
         (replace-regexp "x+" "z" nil (point-min) (point-max))))

Chong Yidong wrote:

> Thanks for spotting this.  I've checked in a fix.

Thanks!
--
Fran

bug#956: In CVS Emacs, replace-regexp doesn't honor inhibit-read-only.

[Francis Litterio]

Francis Litterio wrote:

> I wrote:
>
>> In CVS Emacs, replace-regexp doesn't honor inhibit-read-only.  To
>> reproduce, evaluate this form:

>      (let ((inhibit-read-only t))
>        (with-current-buffer (get-buffer-create "zzz")
>
>          (toggle-read-only 1)  ;; Forgot this in my original report!
>
>          (insert "fooxxxbar")
>          (replace-regexp "x+" "z" nil (point-min) (point-max))))
>
> Chong Yidong wrote:
>
>> Thanks for spotting this.  I've checked in a fix.
>
> Thanks!

I updated from CVS after seeing your above message, and the bug is still
there.  What file did you change?
--
Fran

bug#956: In CVS Emacs, replace-regexp doesn't honor inhibit-read-only.

[Chong Yidong]

Francis Litterio <flitterio@gmail.com> writes:

> I updated from CVS after seeing your above message, and the bug is still
> there.  What file did you change?

I forgot to commit the file itself; please try again.