From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: flitterio@gmail.com (Francis Litterio) Newsgroups: gmane.emacs.devel Subject: Re: Patch to fix ERC mode's IRC protocol logging Date: Mon, 19 Jul 2010 22:55:37 -0400 Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1279594917 4033 80.91.229.12 (20 Jul 2010 03:01:57 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 20 Jul 2010 03:01:57 +0000 (UTC) Cc: deniz.a.m.dogan@gmail.com To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 20 05:01:56 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ob35c-0006F1-Hv for ged-emacs-devel@m.gmane.org; Tue, 20 Jul 2010 05:01:52 +0200 Original-Received: from localhost ([127.0.0.1]:34084 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ob35c-0002gr-6o for ged-emacs-devel@m.gmane.org; Mon, 19 Jul 2010 23:01:52 -0400 Original-Received: from [140.186.70.92] (port=39981 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ob35W-0002gm-Bn for emacs-devel@gnu.org; Mon, 19 Jul 2010 23:01:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ob35U-0007wh-UU for emacs-devel@gnu.org; Mon, 19 Jul 2010 23:01:46 -0400 Original-Received: from mail-qy0-f169.google.com ([209.85.216.169]:38815) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ob35U-0007wa-SU for emacs-devel@gnu.org; Mon, 19 Jul 2010 23:01:44 -0400 Original-Received: by qyk32 with SMTP id 32so2314883qyk.0 for ; Mon, 19 Jul 2010 20:01:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :x-random-quote:message-id:mime-version:content-type; bh=jJ8w2ImpXKKlFXtNQ9rRBi83sAjzk6odTQwl8iEqUbk=; b=iBsVJXR4YQqGTKU5LlXz+OcFuaQqDeb0cmOWg9g/jaOBSeW/+vewL0tk5WrugaRpGl fK2Qd46cM3pCmg7cf+pWFMsRy8lk0//VgTzwAdpF527LRr8LhVnX8h96SGRiKBC0C31n V+yHV7ITFy8HdCw+5LFFesSCyfffIF0tbM3A8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:x-random-quote:message-id:mime-version :content-type; b=u/QQrWGHPfSOoNM57ZKYaPGAKtraQ8e1HpMmDa1bTeR9w4LZV3185ig74S77+RdJcW QPwWFIgSjVRVqs+XpUMokPQbSQhJMCYZSBw1H49sMYwDmFDzAU3Fakglj03pIZQoZgiF PzGUu/Nb9g1wyNmPJstKi3L28OESISQTdG9sM= Original-Received: by 10.224.39.85 with SMTP id f21mr5021796qae.142.1279594902025; Mon, 19 Jul 2010 20:01:42 -0700 (PDT) Original-Received: from usenlittefl2c.gmail.com (li58-96.members.linode.com [97.107.128.96]) by mx.google.com with ESMTPS id q31sm27513293qcq.32.2010.07.19.20.01.40 (version=SSLv3 cipher=RC4-MD5); Mon, 19 Jul 2010 20:01:41 -0700 (PDT) X-Random-Quote: I am not one of those who in expressing opinions confine themselves to facts. -- Mark Twain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:127598 Archived-At: Deniz Dogan wrote: > 2010/7/19 Fran Litterio: > > The below patch fixes a problem in ERC where erc-toggle-debug-irc-protocol > > was not logging inbound protocol data. It also changes the key to interactively > > toggle protocol logging so that it doesn't interfere with View mode bindings. > Thank you! You should probably also send it to erc-discuss gnu.org in > case the ERC mantainer doesn't read emacs-devel. Do patches for ERC have to go into the upstream ERC source first in order to make it into Emacs? I thought that since ERC was now part of Emacs, patches can go directly into the Emacs source. -- Fran