* bug#7580: [PATCH] cc-mode bitfield fontification bug
@ 2010-12-07 12:34 Daniel Colascione
2011-01-22 3:06 ` Chong Yidong
[not found] ` <87fwslbpsd.fsf@stupidchicken.com>
0 siblings, 2 replies; 3+ messages in thread
From: Daniel Colascione @ 2010-12-07 12:34 UTC (permalink / raw)
To: 7580
[-- Attachment #1: Type: text/plain, Size: 688 bytes --]
struct test
{
/* Both should be fontified as bitfields; currently, only the former
is */
int bf1:5;
unsigned bf2:5;
};
@@ -5575,7 +5656,9 @@
;; a valid label. Otherwise the last one probably is the
;; declared identifier and we should back up to the previous
;; type, providing it isn't a cast.
- (if (eq (char-after) ?:)
+ (if (and (eq (char-after) ?:)
+ (not (and (eq backup-at-type 'prefix)
+ (eq at-type 'maybe))))
;; If we've found a specifier keyword then it's a
;; declaration regardless.
(throw 'at-decl-or-cast (eq at-decl-or-cast t))
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#7580: [PATCH] cc-mode bitfield fontification bug
2010-12-07 12:34 bug#7580: [PATCH] cc-mode bitfield fontification bug Daniel Colascione
@ 2011-01-22 3:06 ` Chong Yidong
[not found] ` <87fwslbpsd.fsf@stupidchicken.com>
1 sibling, 0 replies; 3+ messages in thread
From: Chong Yidong @ 2011-01-22 3:06 UTC (permalink / raw)
To: Alan Mackenzie; +Cc: Daniel Colascione, 7580
Hi Alan,
Could you please review this patch? Thanks!
Daniel Colascione <dan.colascione@gmail.com> writes:
> struct test
> {
> /* Both should be fontified as bitfields; currently, only the former
> is */
> int bf1:5;
> unsigned bf2:5;
> };
>
>
> @@ -5575,7 +5656,9 @@
> ;; a valid label. Otherwise the last one probably is the
> ;; declared identifier and we should back up to the previous
> ;; type, providing it isn't a cast.
> - (if (eq (char-after) ?:)
> + (if (and (eq (char-after) ?:)
> + (not (and (eq backup-at-type 'prefix)
> + (eq at-type 'maybe))))
> ;; If we've found a specifier keyword then it's a
> ;; declaration regardless.
> (throw 'at-decl-or-cast (eq at-decl-or-cast t))
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#7580: [PATCH] cc-mode bitfield fontification bug
[not found] ` <87fwslbpsd.fsf@stupidchicken.com>
@ 2011-10-03 20:35 ` Glenn Morris
0 siblings, 0 replies; 3+ messages in thread
From: Glenn Morris @ 2011-10-03 20:35 UTC (permalink / raw)
To: 7580-done
Version: 24.1
I see this in 23.3 but not in the current trunk, so it seems to have
been fixed.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-03 20:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-07 12:34 bug#7580: [PATCH] cc-mode bitfield fontification bug Daniel Colascione
2011-01-22 3:06 ` Chong Yidong
[not found] ` <87fwslbpsd.fsf@stupidchicken.com>
2011-10-03 20:35 ` Glenn Morris
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.