From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.devel Subject: Re: which-function => DEFUN? Date: Mon, 10 May 2010 17:56:32 +0200 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1273507126 27050 80.91.229.12 (10 May 2010 15:58:46 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 10 May 2010 15:58:46 +0000 (UTC) Cc: Emacs-Devel devel To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 10 17:58:45 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OBVNF-00028x-NG for ged-emacs-devel@m.gmane.org; Mon, 10 May 2010 17:58:42 +0200 Original-Received: from localhost ([127.0.0.1]:56986 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OBVND-00049y-4J for ged-emacs-devel@m.gmane.org; Mon, 10 May 2010 11:58:27 -0400 Original-Received: from [140.186.70.92] (port=45836 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OBVMj-0002jF-2r for emacs-devel@gnu.org; Mon, 10 May 2010 11:58:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OBVLh-0007SS-Qu for emacs-devel@gnu.org; Mon, 10 May 2010 11:57:00 -0400 Original-Received: from mail-fx0-f41.google.com ([209.85.161.41]:41077) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBVLh-0007S9-Lz for emacs-devel@gnu.org; Mon, 10 May 2010 11:56:53 -0400 Original-Received: by fxm9 with SMTP id 9so848128fxm.0 for ; Mon, 10 May 2010 08:56:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=16aoGwgU4f9ngVtDtGFvVlT8bHvC0cMSHr6QTkaKmpM=; b=CeBF4TOWiGRB08L5aZkqBktIFVQv34xG5otqfbZkHkMK5LqOSlbs7As3Mv1ZPA4srI Ud+sLlpSLULA2pcyYHfjOItgzF1uDhXh/sg6Lgza+8xs/FVlYbX5MJxVS78EjppMzx7o m/NPkdmbDnEJU3DR40kYmBpxCcokYygefg+ow= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=eHAJ2rBwnd6xFvFDRTKyt+qqE/uaQNcWotHD+sZvT3X/raoQxMDab8RMe8ojHhI4WC gq/yX1iq9RboCp+k1bSjlo55bH8JEjOD3+f3Vji7Zjo5pqpRRPc/3nDTGXiKJSyw2IkU y72pna1ZC2+hLjG7DImM4JGCJeyb46sKDLNx8= Original-Received: by 10.239.136.20 with SMTP id f20mr434307hbf.19.1273507012166; Mon, 10 May 2010 08:56:52 -0700 (PDT) Original-Received: by 10.239.164.81 with HTTP; Mon, 10 May 2010 08:56:32 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:124665 Archived-At: On Mon, May 10, 2010 at 5:09 PM, Juanma Barranquero wrot= e: > On Mon, May 10, 2010 at 16:39, Lennart Borgman > wrote: > >> =C2=A0 =C2=A0 =C2=A0 =C2=A0;; Check if we are at the beginning of the fu= nction already >> =C2=A0 =C2=A0 =C2=A0 =C2=A0(unless (eobp) (forward-char)) > > Yes, nice catch. Thanks. > >> =C2=A0 =C2=A0 =C2=A0 =C2=A0(beginning-of-defun) >> =C2=A0 =C2=A0 =C2=A0 =C2=A0(when (< here (point)) (beginning-of-defun)) > > What does this protect against? We might have stepped into the next function. > And, why did you go for (let ((here (point))) ...) instead of > `save-excursion'? Efficiency? Efficiency. And actually readability. > =C2=A0 =C2=A0Juanma >