From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: PATCH: Fix IDO interaction with uniquify.el Date: Wed, 5 May 2010 21:48:57 +0200 Message-ID: References: <87k4vf1zdh.fsf@telefonica.net> <87ockrz4eu.fsf@telefonica.net> <87pr57uw25.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: dough.gmane.org 1273102223 18601 80.91.229.12 (5 May 2010 23:30:23 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 5 May 2010 23:30:23 +0000 (UTC) Cc: =?UTF-8?Q?=C3=93scar_Fuentes?= , Chong Yidong , emacs-devel@gnu.org To: Leo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 06 01:30:19 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1O9o2i-00008F-QW for ged-emacs-devel@m.gmane.org; Thu, 06 May 2010 01:30:17 +0200 Original-Received: from localhost ([127.0.0.1]:39592 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O9npx-0001bi-Pi for ged-emacs-devel@m.gmane.org; Wed, 05 May 2010 19:17:05 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O9kie-0003J3-0V for emacs-devel@gnu.org; Wed, 05 May 2010 15:57:20 -0400 Original-Received: from [140.186.70.92] (port=54068 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O9kib-00039z-HT for emacs-devel@gnu.org; Wed, 05 May 2010 15:57:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O9kax-0000CW-Ig for emacs-devel@gnu.org; Wed, 05 May 2010 15:49:27 -0400 Original-Received: from mail-bw0-f225.google.com ([209.85.218.225]:61990) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9kax-0000CP-Dk for emacs-devel@gnu.org; Wed, 05 May 2010 15:49:23 -0400 Original-Received: by bwz25 with SMTP id 25so3306358bwz.8 for ; Wed, 05 May 2010 12:49:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type; bh=qQ8xOgPmGQBDnbpZ7NB3toJUxORozApsKw3To2AV3Xs=; b=HI20Bqdvjho6LaW+daDmCv/RHOmZErC8FymC1CofCDnJHCFb6K6JrQuSYwvOF/5ZXR RMo2NVVkYcU30/3SQDjxUdL7oZB3S4MFukwjLRr/0oKAtHc65ue3IUudINy5XBntbzHs SftQ97ogFp5hxXpUMZ4F/Y4sU/6bCxXQlkQkg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=XiEIn3fxd307lK56TjqpD7aItF1CoxSZK+SmizYGxKOviaynYylDEiewD4tyvQzdQ6 wsErRTtJp5ic7oMkqOFKb31sTR34Da238YppSC+qoGKTKjyyu9oOyKpginrBU0eS02uk qQp5VnNYaws8A4Uoyd8nXU/VRaSCjoyGMx1Aw= Original-Received: by 10.204.132.196 with SMTP id c4mr932027bkt.5.1273088958732; Wed, 05 May 2010 12:49:18 -0700 (PDT) Original-Received: by 10.204.84.81 with HTTP; Wed, 5 May 2010 12:48:57 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:124564 Archived-At: On Wed, May 5, 2010 at 21:12, Leo wrote: > The simplification was uncalled for and it didn't work. I had to use a > remote machine to generate the patches against trunk and must have > some mixups during testing. It still doesn't seem against the trunk. Your patch has: (when buf - (kill-buffer buf) - ;; Check if buffer still exists. - (if (get-buffer buf) + (if (null (kill-buffer buf)) but the code on trunk/lisp/ido.el is (when buf (ido-kill-buffer-internal buf) ;; Check if buffer still exists. (if (get-buffer buf) Juanma