From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kevin Rodgers Newsgroups: gmane.emacs.help Subject: Re: Print out my key-sequences Date: Wed, 21 Apr 2010 01:09:59 -0600 Message-ID: References: <4BC01100.6080602@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1271834396 8604 80.91.229.12 (21 Apr 2010 07:19:56 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 21 Apr 2010 07:19:56 +0000 (UTC) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Wed Apr 21 09:19:54 2010 connect(): No such file or directory Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1O4UDk-0003mI-Vg for geh-help-gnu-emacs@m.gmane.org; Wed, 21 Apr 2010 09:19:52 +0200 Original-Received: from localhost ([127.0.0.1]:54135 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O4UDg-0002er-8x for geh-help-gnu-emacs@m.gmane.org; Wed, 21 Apr 2010 03:19:36 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O4U57-0005oP-KF for help-gnu-emacs@gnu.org; Wed, 21 Apr 2010 03:10:45 -0400 Original-Received: from [140.186.70.92] (port=55171 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O4U50-0005lF-Ut for help-gnu-emacs@gnu.org; Wed, 21 Apr 2010 03:10:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O4U4q-0003Pc-9E for help-gnu-emacs@gnu.org; Wed, 21 Apr 2010 03:10:37 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:55136) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O4U4p-0003OA-J2 for help-gnu-emacs@gnu.org; Wed, 21 Apr 2010 03:10:28 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1O4U4f-0006cy-GJ for help-gnu-emacs@gnu.org; Wed, 21 Apr 2010 09:10:17 +0200 Original-Received: from c-71-237-24-138.hsd1.co.comcast.net ([71.237.24.138]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 21 Apr 2010 09:10:17 +0200 Original-Received: from kevin.d.rodgers by c-71-237-24-138.hsd1.co.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 21 Apr 2010 09:10:17 +0200 X-Injected-Via-Gmane: http://gmane.org/ connect(): No such file or directory Original-Lines: 74 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: c-71-237-24-138.hsd1.co.comcast.net User-Agent: Thunderbird 2.0.0.24 (Macintosh/20100228) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:72776 Archived-At: Andrea Crotti wrote: > Lennart Borgman writes: > >> On Sun, Apr 18, 2010 at 11:01 AM, Andrea Crotti >> >> last-command => this-command-keys, this-command-keys-vector >> >> You can find this information by searching in the elisp manual with >> isearch for "last-command". >> >> See also key-description. > > Great I think this is what I was looking for : (this-command-keys) > > Now I have this but I'm still getting an error > --8<---------------cut here---------------start------------->8--- > (defun growl-popup (msg) > "Show a popup using growl notification or say it, only working on OSX with growlnotify in the $PATH" > (interactive) > (if window-system > (shell-command (concat "growlnotify -a /Applications/Emacs.app/ -m " msg)) > (message msg))) > > (defun popup-last () > (interactive) > (growl-popup (this-command-keys))) > --8<---------------cut here---------------end--------------->8--- > > What doest that supposed to mean? > The function this-command-keys is returning a string, and growl-popup is > working just fine, so what could be the problem again? this-command-keys may return a string or a vector, but concat returns a string. > --8<---------------cut here---------------start------------->8--- > (Shell command killed by signal Trace/BPT trap) > --8<---------------cut here---------------end--------------->8--- this-command-keys can return a vector containing elements other than integers (characters) e.g. symbols for function keys and mouse events. And the vector can contain integers that cannot be put into a string. See the Strings of Events node of the Emacs Lisp manual. So first you have to find a robust way of converting the result of this-command-keys to a string, so it can incorporated into the COMMAND string argument to shell-command. As Lennart suggested, key-description is probably the way to go. And passing an arbitrary string as an argument to a program via shell-command is itself risky, if it may contain a shell metacharacters (which seems quite likely in this case). So the string should be escaped using shell-quote-argument, or you could use call-process instead of shell-command to avoid the quoting issue. So: (defun growl-popup (msg) "Pop up a growl notification with MSG, or display an Emacs message. The \"growlnotify\" program is used if `window-system' is non-nil and the program is found in `exec-path'; otherwise `message' is used." (interactive) (if (and window-system (executable-find "growlnotify")) (shell-command (concat "growlnotify -a /Applications/Emacs.app/ -m " (shell-quote-argument msg))) (message msg))) (defun popup-last () (interactive) (growl-popup (key-description (this-command-keys)))) -- Kevin Rodgers Denver, Colorado, USA