Add cedet/ede/shell.el to ELCFILES

Add cedet/ede/shell.el to ELCFILES

[Eli Zaretskii]

This is with the current CVS:

  Maintainer warning: $(lisp)/cedet/ede/shell.el missing from $ELCFILES?
  Compiling $(lisp)/cedet/ede/shell.el
  Wrote $(lisp)/cedet/ede/shell.elc

Re: Add cedet/ede/shell.el to ELCFILES

[Chong Yidong]

Eli Zaretskii <eliz@gnu.org> writes:

> This is with the current CVS:
>
>   Maintainer warning: $(lisp)/cedet/ede/shell.el missing from $ELCFILES?
>   Compiling $(lisp)/cedet/ede/shell.el
>   Wrote $(lisp)/cedet/ede/shell.elc

Fixed now, thanks.

One reason I missed this error is that each time I compile, I get the
errors about the unicode files, e.g.

Maintainer warning: $(lisp)/international/uni-bidi.el missing from $ELCFILES?
Compiling /home/cyd/emacs/lisp/international/uni-bidi.el
Maintainer warning: $(lisp)/international/uni-category.el missing from $ELCFILES?
Compiling /home/cyd/emacs/lisp/international/uni-category.el

Of course, these files don't end up being compiled, because
no-byte-compile is set to t locally.  I wonder if there's a way to
remove this warning.

Re: Add cedet/ede/shell.el to ELCFILES

[Eli Zaretskii]

> From: Chong Yidong <cyd@stupidchicken.com>
> Cc: emacs-devel@gnu.org
> Date: Sat, 17 Oct 2009 10:32:02 -0400
> 
> One reason I missed this error is that each time I compile, I get the
> errors about the unicode files, e.g.
> 
> Maintainer warning: $(lisp)/international/uni-bidi.el missing from $ELCFILES?
> Compiling /home/cyd/emacs/lisp/international/uni-bidi.el
> Maintainer warning: $(lisp)/international/uni-category.el missing from $ELCFILES?
> Compiling /home/cyd/emacs/lisp/international/uni-category.el

Is this during bootstrap?  I don't think I see it during a regular
build.  And since these files are modified only very rarely, they
shouldn't present a problem, unless I'm missing something.

Btw, there are 85 files under lisp/ that have "no-byte-compile: t", so
why these few are special?

Re: Add cedet/ede/shell.el to ELCFILES

[Glenn Morris]

Chong Yidong wrote:

> One reason I missed this error is that each time I compile, I get the
> errors about the unicode files, e.g.
>
> Maintainer warning: $(lisp)/international/uni-bidi.el missing from $ELCFILES?
> Compiling /home/cyd/emacs/lisp/international/uni-bidi.el

You need to figure out why this happens, because it does not for me.
These files have a no-byte-compile cookie that compile-last checks
for. Does

grep 'no-byte-compile: t'

work on your system with these files? Perhaps their encoding confuses
grep.

IIRC, you added a manual workaround to compile-last for these files, I
never understood why. Anyway, maybe the header format has changed now
and it needs updating.

Re: Add cedet/ede/shell.el to ELCFILES

[Glenn Morris]

Glenn Morris wrote:

> You need to figure out why this happens, because it does not for me.

Sorry, I think that came out as a bit abrupt. I should have said
something like: This works for me, can you figure out why it does not
work for you?

Re: Add cedet/ede/shell.el to ELCFILES

[Chong Yidong]

Glenn Morris <rgm@gnu.org> writes:

>> Maintainer warning: $(lisp)/international/uni-bidi.el missing from $ELCFILES?
>> Compiling /home/cyd/emacs/lisp/international/uni-bidi.el
>
> You need to figure out why this happens, because it does not for me.
> These files have a no-byte-compile cookie that compile-last checks
> for. Does
>
> grep 'no-byte-compile: t'
>
> work on your system with these files? Perhaps their encoding confuses
> grep.
>
> IIRC, you added a manual workaround to compile-last for these files, I
> never understood why. Anyway, maybe the header format has changed now
> and it needs updating.

Oh, interesting; I always assumed everyone else was seeing these
messages, since I've been seeing them since forever.  The elc files are
*not* present on my system.  The messages pop up during `make' in the
top (emacs/) directory.  I'll try to investigate further.

Re: Add cedet/ede/shell.el to ELCFILES

[Glenn Morris]

Chong Yidong wrote:

> Oh, interesting; I always assumed everyone else was seeing these
> messages, since I've been seeing them since forever.  The elc files are
> *not* present on my system.  The messages pop up during `make' in the
> top (emacs/) directory.  I'll try to investigate further.

Just in case there's confusion, I don't have the .elc files either for
these files. This is correct, because they are marked as no-byte-compile.

The warning message comes from compile-last in lisp/Makefile.in.
But for me, for example:

grep 'no-byte-compile: t' lisp/international/uni-bidi.el > /dev/null

returns 0, so compile-last does not warn me about such files. I can
only guess that for you it returns false for some reason.

Re: Add cedet/ede/shell.el to ELCFILES

[Glenn Morris]

Glenn Morris wrote:

> grep 'no-byte-compile: t' lisp/international/uni-bidi.el > /dev/null
>
> returns 0, so compile-last does not warn me about such files. I can
> only guess that for you it returns false for some reason.

I wonder if GREP_OPTIONS is set in your environment, so that your grep
defaults to '--binary-files=without-match'? I installed a change for
this.

Re: Add cedet/ede/shell.el to ELCFILES

[Chong Yidong]

Glenn Morris <rgm@gnu.org> writes:

> I wonder if GREP_OPTIONS is set in your environment, so that your grep
> defaults to '--binary-files=without-match'? I installed a change for
> this.

That was it, great guess!  (I had set it in my .bashrc so long ago that
I'd forgotten.)

Re: Add cedet/ede/shell.el to ELCFILES

[Miles Bader]

Glenn Morris <rgm@gnu.org> writes:
>> grep 'no-byte-compile: t' lisp/international/uni-bidi.el > /dev/null
>>
>> returns 0, so compile-last does not warn me about such files. I can
>> only guess that for you it returns false for some reason.
>
> I wonder if GREP_OPTIONS is set in your environment, so that your grep
> defaults to '--binary-files=without-match'? I installed a change for
> this.

Also in general many tools behave more sanely if LANG=C is used...

-Miles

-- 
Electricity, n. The cause of all natural phenomena not known to be caused by
something else.

Re: Add cedet/ede/shell.el to ELCFILES

[Andreas Schwab]

Miles Bader <miles@gnu.org> writes:

> Also in general many tools behave more sanely if LANG=C is used...

Actually LC_ALL=C.  LANG just sets the default that the other LC_FOO
variables can override.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: Add cedet/ede/shell.el to ELCFILES

[Glenn Morris]

Eli Zaretskii wrote:

> This is with the current CVS:
>
>   Maintainer warning: $(lisp)/cedet/ede/shell.el missing from $ELCFILES?
>   Compiling $(lisp)/cedet/ede/shell.el
>   Wrote $(lisp)/cedet/ede/shell.elc

When you see such a warning (which is completely harmless, BTW), just
run `make update-elclist' in the lisp directory, and commit
Makefile.in.

Re: Add cedet/ede/shell.el to ELCFILES

[Stefan Monnier]

>> This is with the current CVS:
>> 
>> Maintainer warning: $(lisp)/cedet/ede/shell.el missing from $ELCFILES?
>> Compiling $(lisp)/cedet/ede/shell.el
>> Wrote $(lisp)/cedet/ede/shell.elc

> When you see such a warning (which is completely harmless, BTW), just
> run `make update-elclist' in the lisp directory, and commit
> Makefile.in.

BTW, if someone can come up with a way to get rid of `elcfiles' in
lisp/Makefile.in that would be very welcome.  Its only purpose is to
allow parallel compilation of the .el files (which happens to be
unreliable anyway), so the pain it brings is fairly high compared to the
benefit.  A solution that doesn't requires something like
`update-elcfiles' would be much preferred.
A solution that only works for GNU make would be acceptable, as long as
it doesn't break building with non-GNU makes.


        Stefan

parallel bytecomp [was Re: Add cedet/ede/shell.el to ELCFILES]

[Glenn Morris]

Stefan Monnier wrote:

> allow parallel compilation of the .el files (which happens to be
> unreliable anyway)

Are you talking about this?

http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4196

Patches for this would also be good.

Re: Add cedet/ede/shell.el to ELCFILES

[Dan Nicolaescu]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

  > >> This is with the current CVS:
  > >> 
  > >> Maintainer warning: $(lisp)/cedet/ede/shell.el missing from $ELCFILES?
  > >> Compiling $(lisp)/cedet/ede/shell.el
  > >> Wrote $(lisp)/cedet/ede/shell.elc
  > 
  > > When you see such a warning (which is completely harmless, BTW), just
  > > run `make update-elclist' in the lisp directory, and commit
  > > Makefile.in.
  > 
  > BTW, if someone can come up with a way to get rid of `elcfiles' in
  > lisp/Makefile.in that would be very welcome.  Its only purpose is to
  > allow parallel compilation of the .el files (which happens to be
  > unreliable anyway), so the pain it brings is fairly high compared to the
  > benefit.  A solution that doesn't requires something like
  > `update-elcfiles' would be much preferred.

Wouldn't the parallel compilation problem go away if your idea of using
the .el files (rather than .elc) during compilation would be implemented?

Re: Add cedet/ede/shell.el to ELCFILES

[Stefan Monnier]

>> BTW, if someone can come up with a way to get rid of `elcfiles' in
>> lisp/Makefile.in that would be very welcome.  Its only purpose is to
>> allow parallel compilation of the .el files (which happens to be
>> unreliable anyway), so the pain it brings is fairly high compared to the
>> benefit.  A solution that doesn't requires something like
>> `update-elcfiles' would be much preferred.

> Wouldn't the parallel compilation problem go away if your idea of using
> the .el files (rather than .elc) during compilation would be implemented?

That would fix the "(which happens to be unreliable anyway)", but is
unrelated to the main point of my argument: the update-elcfiles and
related mess.


        Stefan