From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: Emacs-diffstrunk r117208: * lisp/files.el (locate-dominating-file): Expand file argument. Date: Sun, 01 Jun 2014 13:23:58 -0400 Message-ID: References: <87ha45vzkm.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1401643488 20100 80.91.229.3 (1 Jun 2014 17:24:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 1 Jun 2014 17:24:48 +0000 (UTC) Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 01 19:24:42 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Wr9Uu-0004Rg-95 for ged-emacs-devel@m.gmane.org; Sun, 01 Jun 2014 19:24:40 +0200 Original-Received: from localhost ([::1]:41550 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wr9Ut-000563-T4 for ged-emacs-devel@m.gmane.org; Sun, 01 Jun 2014 13:24:39 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43266) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wr9UF-0004Xn-Jh for emacs-devel@gnu.org; Sun, 01 Jun 2014 13:24:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wr9UE-0003Vl-Sq for emacs-devel@gnu.org; Sun, 01 Jun 2014 13:23:59 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59353) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wr9UE-0003Vh-QS for emacs-devel@gnu.org; Sun, 01 Jun 2014 13:23:58 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Wr9UE-0002D3-8l; Sun, 01 Jun 2014 13:23:58 -0400 X-Spook: Telex Venezuela DRM data haven CIDA MD5 AK-47 Operation X-Ran: 'P~N$1[P+iy6U8G.D+bYYcW[v+yFnL+{ X-Hue: black X-Attribution: GM In-Reply-To: <87ha45vzkm.fsf@gmx.de> (Michael Albinus's message of "Sun, 01 Jun 2014 09:50:01 +0200") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:172243 Archived-At: Michael Albinus wrote: >> BTW, I think that test should set the BZR_HOME environment variable, >> like test/automated/vc-bzr.el does. This will be good not just for >> hydra, but to stop tests writing to ~/.bzr.log in general. > > Yes. However, it's not guaranteed that tramp-test29-vc-registered > chooses bzr. It could also take git or hg, whatever it finds on the test > machine. It will be harmless to set BZR_HOME if something other than bzr is used. But you should be able to make the setting conditional on bzr being chosen, if you like. (I could not figure out if I needed to modify process-environment or tramp-remote-process-environment, and if the latter needed to be changed early on.) > A bzr only change will be good for hydra, but maybe we need some more > general consideration here. As I said, I think it will be good for everyone to set BZR_HOME to a temp value. > OTOH, it's not guaranteed that all people have set BZR_HOME. I don't understand. > Couldn't this setting hide problems, which would be detected otherwise > in the tests? It only hides the problem of a non-functioning bzr due to a missing HOME directory, which is not Emacs's problem IMO.