From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: Any exceptions for the 15-line rule? Date: Wed, 01 May 2013 14:06:13 -0400 Message-ID: References: <87d2tgu0ad.fsf@yandex.ru> <871u9wyxaz.fsf@yandex.ru> <517BD66C.8030906@yandex.ru> <8761z31dv4.fsf@yandex.ru> <518155CF.30202@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1367431584 24476 80.91.229.3 (1 May 2013 18:06:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 1 May 2013 18:06:24 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 01 20:06:20 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UXbQ3-00078d-UF for ged-emacs-devel@m.gmane.org; Wed, 01 May 2013 20:06:20 +0200 Original-Received: from localhost ([::1]:42146 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXbQ3-00085r-7C for ged-emacs-devel@m.gmane.org; Wed, 01 May 2013 14:06:19 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXbPz-00085T-Kc for emacs-devel@gnu.org; Wed, 01 May 2013 14:06:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UXbPx-0004Ob-Uw for emacs-devel@gnu.org; Wed, 01 May 2013 14:06:15 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43094) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXbPx-0004OX-Rz for emacs-devel@gnu.org; Wed, 01 May 2013 14:06:13 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1UXbPx-0001Sv-57; Wed, 01 May 2013 14:06:13 -0400 X-Spook: nitrate Mahmoud Ahmadinejad bluebird Osama Security X-Ran: ;z]KaQgFMmO)Bz{Eq[\jgUBZ1}?$-EJA,k%'r;X%>J*?L?O3\CUM&^^GeY?&\a%gsCTqX9 X-Hue: blue X-Attribution: GM In-Reply-To: <518155CF.30202@yandex.ru> (Dmitry Gutov's message of "Wed, 01 May 2013 21:50:07 +0400") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:159252 Archived-At: Dmitry Gutov wrote: > Thank you. I don't think I've seen a good definition of "tiny change" > anywhere, and there's no s/foo/bar in either of these patches, but if > you suggest to use my own judgment, that's fine by me. s/foo/bar was just an example. You need to look at the change and ask, "conceptually, how big is this"? Deleting says 15 lines of common code from two places and turning it into a separate function that those two places call only "counts" as a few lines IMO (the function definition part, the function body is the same code as before, just moved around). If in doubt, err on the side of getting an assignment. It also makes life easier when the same person contributes more in future.