From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 012487b: * lisp/display-line-numbers.el (display-line-numbers-type): Autoload it. Date: Mon, 24 Jul 2017 12:57:41 -0400 Message-ID: References: <20170723072843.23485.53761@vcs0.savannah.gnu.org> <20170723072844.877FD22EF0@vcs0.savannah.gnu.org> <87inijxnda.fsf@detlef> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1500915502 2234 195.159.176.226 (24 Jul 2017 16:58:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 24 Jul 2017 16:58:22 +0000 (UTC) User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Cc: Stefan Monnier , emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 24 18:58:18 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dZggQ-0000AN-1C for ged-emacs-devel@m.gmane.org; Mon, 24 Jul 2017 18:58:14 +0200 Original-Received: from localhost ([::1]:55935 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZggV-0003iw-Oe for ged-emacs-devel@m.gmane.org; Mon, 24 Jul 2017 12:58:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51762) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZgfz-0003iq-JQ for emacs-devel@gnu.org; Mon, 24 Jul 2017 12:57:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZgfy-0005r4-Q5 for emacs-devel@gnu.org; Mon, 24 Jul 2017 12:57:47 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44595) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZgfu-0005pR-53; Mon, 24 Jul 2017 12:57:42 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dZgft-0003t3-OS; Mon, 24 Jul 2017 12:57:41 -0400 X-Spook: Authorities Bruxelles illuminati Rule Psix Vaccine X-Ran: 23i?6\"?&f7q'j+^Fgva^c;9ZDuIcXU>@ll9:itEYbZ3\#V|<#3/0w@aj#c%`X^guNTT~- X-Hue: red X-Attribution: GM In-Reply-To: <87inijxnda.fsf@detlef> (Michael Albinus's message of "Sun, 23 Jul 2017 16:02:25 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216980 Archived-At: Michael Albinus wrote: > Stefan Monnier writes: > >>> * lisp/display-line-numbers.el (display-line-numbers-type): Autoload it. >> >> Why? > > Used in menu-bar.el. But not in any significant way? --- i/lisp/display-line-numbers.el +++ w/lisp/display-line-numbers.el @@ -38,7 +38,6 @@ display-line-numbers "Display line numbers in the buffer." :group 'display) -;;;###autoload (defcustom display-line-numbers-type t "The default type of line numbers to use in `display-line-numbers-mode'. See `display-line-numbers' for value options." diff --git i/lisp/menu-bar.el w/lisp/menu-bar.el index 05a336b..e02217f 100644 --- i/lisp/menu-bar.el +++ w/lisp/menu-bar.el @@ -1101,6 +1101,9 @@ menu-bar-showhide-tool-bar-menu-customize-enable-bottom :button (:radio . (eq tool-bar-mode nil)))) menu))) +;; Following function calls will autoload the library. +(defvar display-line-numbers-type) + (defun menu-bar-display-line-numbers-mode (type) (setq display-line-numbers-type type) (if global-display-line-numbers-mode This message brought to you by SAUNA: The Society Against UNnecessary Autoloads