From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kevin Rodgers Newsgroups: gmane.emacs.help Subject: Re: Problem advising nreverse. Date: Tue, 15 Dec 2009 01:19:34 -0700 Message-ID: References: <87skbg8jww.fsf@galatea.local> <87bpi1n1z7.fsf@galatea.local> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1260865235 24096 80.91.229.12 (15 Dec 2009 08:20:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 15 Dec 2009 08:20:35 +0000 (UTC) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Tue Dec 15 09:20:24 2009 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NKSdr-0003PX-FE for geh-help-gnu-emacs@m.gmane.org; Tue, 15 Dec 2009 09:20:23 +0100 Original-Received: from localhost ([127.0.0.1]:36278 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NKSdr-0007f1-CC for geh-help-gnu-emacs@m.gmane.org; Tue, 15 Dec 2009 03:20:23 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NKSdV-0007eo-0q for help-gnu-emacs@gnu.org; Tue, 15 Dec 2009 03:20:01 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NKSdQ-0007cr-2s for help-gnu-emacs@gnu.org; Tue, 15 Dec 2009 03:20:00 -0500 Original-Received: from [199.232.76.173] (port=54854 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NKSdP-0007co-Sp for help-gnu-emacs@gnu.org; Tue, 15 Dec 2009 03:19:55 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]:58057) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NKSdP-00023W-K5 for help-gnu-emacs@gnu.org; Tue, 15 Dec 2009 03:19:55 -0500 Original-Received: from list by lo.gmane.org with local (Exim 4.50) id 1NKSdN-0003Ez-6r for help-gnu-emacs@gnu.org; Tue, 15 Dec 2009 09:19:53 +0100 Original-Received: from c-71-237-24-138.hsd1.co.comcast.net ([71.237.24.138]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 15 Dec 2009 09:19:53 +0100 Original-Received: from kevin.d.rodgers by c-71-237-24-138.hsd1.co.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 15 Dec 2009 09:19:53 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 59 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: c-71-237-24-138.hsd1.co.comcast.net User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812) In-Reply-To: X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:70654 Archived-At: [I'm responding to this message, because subsequently the thread spun out of control beyond my comprehension.] Sergei Organov wrote: > pjb@informatimago.com (Pascal J. Bourguignon) writes: ... >> Redefining nreverse and reloading the ewoc-collect function would help >> as indicated... > > Yeah, but: > > 1. I don't really want `nreverse' to be always redefined. If you know the bug is in ewoc, you don't want nreverse redefined ever. > 2. I don't know how to reload `ewoc-collect' (from elisp) provided it's > already byte-compiled. Put the new defun in a file and explicitly reload it. > Here what I've actually originally tried (that didn't work): > > (defadvice ewoc-collect (around fix-ewoc-collect activate) > "Fix buggy `ewoc-collect' by reversing its result provided it > was altered by `nreverse'." > (let ((last-nreverse-result)) > (unwind-protect > (progn > (defadvice nreverse (after notice-nreverse activate) > (setq last-nreverse-result ad-return-value)) > ad-do-it) ad-do-it is not a variable: it is a form that can only be meaningfully referenced *within* a defadvice form. > (ad-unadvise 'nreverse)) > (if (eq last-nreverse-result ad-return-value) > (setq ad-return-value (nreverse ad-return-value))))) I don't understand: How can you determine whether any value "was altered by nreverse"? That is not Lispish thinking. > This starts to work as soon as I re-evaluate the (defun ewoc-collect > ...) in the ewoc.el file after the above defadvice is evaluated and > continues to work even if I byte-compile the (defun ewoc-collect...) > after that (though I still don't understand why it works after > byte-compiling), but then it's both easier and cleaner to just re-define > ewoc-collect to a correct version. > > -- Sergei. > > > > -- Kevin Rodgers Denver, Colorado, USA