From: Sergei Organov <osv@javad.com>
To: help-gnu-emacs@gnu.org
Subject: Re: Problem advising nreverse.
Date: Mon, 14 Dec 2009 22:59:02 +0300 [thread overview]
Message-ID: <hg65e6$47j$1@ger.gmane.org> (raw)
In-Reply-To: 87pr6hl9s4.fsf@galatea.local
pjb@informatimago.com (Pascal J. Bourguignon) writes:
> Sergei Organov <osv@javad.com> writes:
>
>> You see, I wanted automatic elisp-only solution to "fixing"
>> ewoc-collect, but only if it indeed happens to be buggy. Manual
>> reloading is not an option then. Alternate approach would be to execute
>> simple test-case to determine if ewoc-collect is indeed buggy and then
>> re-define it to the correct version if so. That's what I'm going to
>> implement now, provided there doesn't seem to be a way to do what I want
>> by means of advising ewoc-collect and nreverse.
>
> I see.
>
[...]
> or else, if you can detect the broken version with a test:
>
> (require 'ewoc)
> (unless (equal 'expected-result
> (ewoc-collect 'test-arguments))
> (defun ewoc-collect (...)
> ...))
>
> (you can add a (byte-compile 'ewoc-collect) after the defun in either
> case if you need it fast).
Exactly. After realizing with your help that I'll have no luck with
defadvicing nreverse, I finally ended up with the following simple
solution:
;; Fix buggy `ewoc-collect' by reversing its result. Nothing will be
;; changed if `ewoc-collect' is fine.
(require 'ewoc)
(with-temp-buffer
(let ((ewoc (ewoc-create (lambda (elem) ()))))
(ewoc-enter-last ewoc 0) (ewoc-enter-last ewoc 1)
(if (equal 1 (car (ewoc-collect ewoc (lambda (elem) t))))
(defadvice ewoc-collect (after ewoc-collect-reverse activate compile)
"Reverse the result to compensate for buggy implementation."
(setq ad-return-value (nreverse ad-return-value))))))
I still wonder if it's documented somewhere in some manual when
defadvice doesn't actually work. It seems it is not there in the Elisp
manual, or did I miss it?
--
Sergei.
next prev parent reply other threads:[~2009-12-14 19:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.12764.1260538816.2239.help-gnu-emacs@gnu.org>
2009-12-12 12:18 ` Problem advising nreverse Pascal J. Bourguignon
2009-12-14 11:07 ` Sergei Organov
[not found] ` <mailman.12932.1260788943.2239.help-gnu-emacs@gnu.org>
2009-12-14 13:01 ` Pascal J. Bourguignon
2009-12-14 15:05 ` Sergei Organov
2009-12-15 8:19 ` Kevin Rodgers
2009-12-15 12:02 ` Sergei Organov
[not found] ` <mailman.12940.1260803316.2239.help-gnu-emacs@gnu.org>
2009-12-14 15:23 ` Pascal J. Bourguignon
2009-12-14 16:01 ` Sergei Organov
[not found] ` <mailman.12941.1260806509.2239.help-gnu-emacs@gnu.org>
2009-12-14 17:56 ` Pascal J. Bourguignon
2009-12-14 19:59 ` Sergei Organov [this message]
[not found] ` <mailman.12952.1260820780.2239.help-gnu-emacs@gnu.org>
2009-12-15 1:47 ` Pascal J. Bourguignon
2009-12-15 12:06 ` Sergei Organov
[not found] ` <mailman.13009.1260879016.2239.help-gnu-emacs@gnu.org>
2009-12-15 19:54 ` Pascal J. Bourguignon
2009-12-15 20:38 ` Sergei Organov
[not found] ` <mailman.13027.1260909564.2239.help-gnu-emacs@gnu.org>
2009-12-15 21:12 ` Barry Margolin
2009-12-16 11:27 ` Sergei Organov
[not found] ` <mailman.13051.1260962896.2239.help-gnu-emacs@gnu.org>
2009-12-17 16:52 ` Barry Margolin
2009-12-11 13:22 Sergei Organov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='hg65e6$47j$1@ger.gmane.org' \
--to=osv@javad.com \
--cc=help-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.