Org-mode version 6.31trans; Problem with new 'away time' feature

Org-mode version 6.31trans; Problem with new 'away time' feature

[Kai Tetzlaff]

Hi,

since the new resolve 'away time' feature has been integrated i'm having
problems when restarting emacs after exiting with a running clock. When
i'm starting org-mode after the emacs restart by entering agenda mode i
get the new prompt which is asking about how to deal with the unresolved
clock time. I'm confirming the prompt with 'k' to keep (and clocking in
again on) the previous task. I also confirm that the complete open time
should be used for the current task. But then what happens is that
org-mode complains that there are no unfinished clocks:

'Cannot restart clock because task does not contain unfinished clock'

When i look at the corresponding clock line the previously running clock
has now indeed been stopped (with a time stamp corresponding to the
current time).

Below is a *Message* buffer transcript of the output i get during emacs
startup when i have an open clock in one of my org files.

BR,
Kai

Press key for agenda command:
OVERVIEW
Restoring clock data
Loading c:/kt/.org-clock-save.el (source)...done
OVERVIEW
CONTENTS...done
Loading vc-hg...done
OVERVIEW
Clock stopped at [2009-10-22 Do 11:03] after HH:MM = 0:18
Cannot restart clock because task does not contain unfinished clock
OVERVIEW [2 times]
CONTENTS...done
OVERVIEW [4 times]
CONTENTS...done
OVERVIEW [2 times]
CONTENTS...done
Rebuilding agenda buffer...done
Log mode is on
Saving file c:/kt/.emacs.d/org/agenda/prg_wp.org...
Mark set
Replaced 0 occurrences
Wrote c:/kt/.emacs.d/org/agenda/prg_wp.org
Rebuilding agenda buffer...done
Clock stopped at [2009-10-22 Do 11:03] after HH:MM = 0:18
Clock starts at [2009-10-22 Do 11:03] - showing entire task time.

Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     http://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org-mode mailing list.
------------------------------------------------------------------------



Emacs  : GNU Emacs 23.1.50.1 (i386-mingw-nt5.1.2600)
 of 2009-10-14 on LENNART-69DE564 (patched)
Package: Org-mode version 6.31trans

current state:
==============
(setq
 org-empty-line-terminates-plain-lists t
 org-log-done 'time
 org-file-apps '((auto-mode . emacs) ("\\.x?html?\\'" . default)
("\\.pdf\\'" . default)
		 (directory dired-other-frame file))
 org-link-frame-setup '((vm . vm-visit-folder-other-frame) (gnus .
gnus-other-frame) (file . find-file-other-frame))
 org-special-ctrl-a/e 'reversed
 org-agenda-clockreport-parameter-plist '(:link nil :maxlevel 4)
 org-agenda-files '("~/.emacs.d/org/agenda")
 org-clock-persist-query-resume nil
 org-blocker-hook '(org-block-todo-from-children-or-siblings-or-parent)
 org-publish-timestamp-directory "~/.emacs.d/tmp/org-timestamps/"
 org-export-with-sub-superscripts '{}
 org-hide-leading-stars t
 org-after-todo-state-change-hook '(org-clock-out-if-current)
 org-clock-out-when-done nil
 org-clock-history-length 25
 org-odd-levels-only t
 org-special-ctrl-k t
 org-publish-use-timestamps-flag nil
 org-support-shift-select t
 org-clock-in-resume t
 org-export-preprocess-hook '(org-export-blocks-preprocess)
 org-tags-exclude-from-inheritance '("cmm" "cmn" "cmr")
 org-tab-first-hook '(org-hide-block-toggle-maybe)
 org-src-mode-hook '(org-src-mode-configure-edit-buffer)
 org-confirm-shell-link-function 'yes-or-no-p
 org-clock-persist t
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-M-RET-may-split-line '((default . t) (headline))
 org-default-notes-file "~/.emacs.d/org/notes.org"
 org-cycle-hook '(org-cycle-hide-archived-subtrees
org-cycle-hide-drawers org-cycle-show-empty-lines
		  org-optimize-window-after-visibility-change)
 org-publish-project-alist '(("NasTCs-org" :base-directory
"~/.emacs.d/org/agenda/STF160" :base-extension "org"
			      :exclude "\\(org\\|html\\|css\\)" :include ("index.org"
"NasTestcases.org")
			      :publishing-directory "~/NasTcOverview" :publishing-function
			      (kt:publish-html org-publish-org-to-org) :plain-source t
:htmlized-source t
			      :link-validation-function kt:copy-and-validate-link :title "NAS
Testcase Overview"
			      :style
			      "<link rel=\"StyleSheet\"\n
href=\"css/nas.css\"\n                       type=\"text/css\">"
			      :table-of-contents t :section-numbers nil :headline-levels 3
:sub-superscript nil
			      :todo-keywords t :drawers t :tags not-in-toc :timestamps t
:auto-index nil :exclude-tags
			      ("mdesc" "limpl"))
			     ("NasTCs-other" :base-directory "~/.emacs.d/org/agenda/STF160"
:recursive t
			      :no-timestamps t :base-extension "css\\|js" :include
(".htaccess") :publishing-directory
			      "~/NasTcOverview" :publishing-function org-publish-attachment)
			     ("NasTCs" :components ("NasTCs-other" "NasTCs-org"))
			     ("CMerge" :base-directory "~/.emacs.d/org/agenda/STF160"
:exclude ".*" :include
			      ("NasTestcases.org") :publishing-directory "~/NasTcMerge"
:publishing-function
			      (kt:publish-html org-publish-org-to-org) :link-validation-function
			      kt:copy-and-validate-link :title "Merge/Align EPS-only/Combined
NAS TCs"
			      :table-of-contents nil :section-numbers nil :headline-levels 3
:sub-superscript nil
			      :todo-keywords t :drawers ("PROPERTIES") :tags nil :timestamps
nil :auto-index nil
			      :select-tags ("cmm" "cmn" "cmr") :exclude-tags ("limpl" "tci"))
			     )
 org-replace-disputed-keys t
 org-mode-hook '(org-clock-load
		 #[nil "\300\301\302\303\304$\207"
		   [org-add-hook change-major-mode-hook org-show-block-all append
local] 5]
		 )
 org-clock-out-remove-zero-time-clocks t
 org-refile-targets '((org-agenda-files :maxlevel . 3) (nil :maxlevel . 3))
 org-return-follows-link t
 org-confirm-elisp-link-function 'yes-or-no-p
 org-refile-use-outline-path 'file
 org-log-into-drawer t
 org-enforce-todo-dependencies t
 org-insert-heading-respect-content t
 org-insert-mode-line-in-empty-file t
 org-publish-after-export-hook '(kt:org-publish)
 org-occur-hook '(org-first-headline-recenter)
 org-yank-adjusted-subtrees t
 org-agenda-log-mode-items '(clock)
 org-remember-templates '(("Bug" 98 "* BUG %?\n  %i\n  %a"
"agenda/bugs.org" "Bugs")
			  ("Todo" 116 "* TODO %?\n  %i\n  %a" "agenda/todo.org" "Tasks")
			  ("Testcase" 99 "* TODO-TC %?\n  %i\n  %a" "agenda/todo.org"
"Testcase Issues")
			  ("Note" 110 "* %U %?\n\n  %i\n  %a" "agenda/notes.org" "Notes")
			  ("Idea" 105 "* %^{Title}\n  %i\n  %a" "agenda/journal.org" "New
Ideas"))
 org-clock-persist-file "~/.org-clock-save.el"
 )

Re: Org-mode version 6.31trans; Problem with new 'away time' feature

[John Wiegley]

On Oct 22, 2009, at 6:32 PM, Kai Tetzlaff wrote:

> 'Cannot restart clock because task does not contain unfinished clock'
>
> When i look at the corresponding clock line the previously running  
> clock
> has now indeed been stopped (with a time stamp corresponding to the
> current time).

This is an interesting bug.  It sounds like the point is not being  
moved to the correct location to perform the clock-in.  I'll take a  
look.

John

Re: Org-mode version 6.31trans; Problem with new 'away time' feature

[Kai Tetzlaff]

John Wiegley wrote:
> On Oct 22, 2009, at 6:32 PM, Kai Tetzlaff wrote:
> 
>> 'Cannot restart clock because task does not contain unfinished clock'
>>
>> When i look at the corresponding clock line the previously running clock
>> has now indeed been stopped (with a time stamp corresponding to the
>> current time).
> 
> This is an interesting bug.  It sounds like the point is not being moved
> to the correct location to perform the clock-in.  I'll take a look. 

I did some additional investigation and found that if i'm clocking into
an item with an unresolved inactive clock from the agenda (created by
deleting the end time in its most recent CLOCK: line) a similar thing
happens. I'm actually getting clocked out of the current clock and a new
CLOCK line gets added which is then the running clock.

Don't know if this helps but stepping through the code in the debugger i
get to the following code in org-clock-resolve-clock:

((eq resolve-to 'now)
 (if restart-p
     (error "RESTART-P is not valid here"))
 (if (or close-p org-clock-clocking-in)       <-- org-close: nil,
org-clock-clocking-in: t
     (org-clock-clock-out clock fail-quietly) <-- clock-out done here
   (unless (org-is-active-clock clock)
     (org-clock-clock-in clock t))))

Re: Re: Org-mode version 6.31trans; Problem with new 'away time' feature

[Carsten Dominik]

On Oct 23, 2009, at 10:20 AM, Kai Tetzlaff wrote:

> John Wiegley wrote:
>> On Oct 22, 2009, at 6:32 PM, Kai Tetzlaff wrote:
>>
>>> 'Cannot restart clock because task does not contain unfinished  
>>> clock'
>>>
>>> When i look at the corresponding clock line the previously running  
>>> clock
>>> has now indeed been stopped (with a time stamp corresponding to the
>>> current time).
>>
>> This is an interesting bug.  It sounds like the point is not being  
>> moved
>> to the correct location to perform the clock-in.  I'll take a look.
>
> I did some additional investigation and found that if i'm clocking  
> into
> an item with an unresolved inactive clock from the agenda (created by
> deleting the end time in its most recent CLOCK: line) a similar thing
> happens. I'm actually getting clocked out of the current clock and a  
> new
> CLOCK line gets added which is then the running clock.

I think this is what sould happen, no?

The other problem you reported, where I said this is a conflict with  
James' code, should be fixed now.  Please verify.

- Carsten

>
> Don't know if this helps but stepping through the code in the  
> debugger i
> get to the following code in org-clock-resolve-clock:
>
> ((eq resolve-to 'now)
> (if restart-p
>     (error "RESTART-P is not valid here"))
> (if (or close-p org-clock-clocking-in)       <-- org-close: nil,
> org-clock-clocking-in: t
>     (org-clock-clock-out clock fail-quietly) <-- clock-out done here
>   (unless (org-is-active-clock clock)
>     (org-clock-clock-in clock t))))
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten

Re: Org-mode version 6.31trans; Problem with new 'away time' feature

[Kai Tetzlaff]

Carsten Dominik wrote:
> 
> On Oct 23, 2009, at 10:20 AM, Kai Tetzlaff wrote:
> 
>> John Wiegley wrote:
>>> On Oct 22, 2009, at 6:32 PM, Kai Tetzlaff wrote:
>>>
>>>> 'Cannot restart clock because task does not contain unfinished clock'
>>>>
>>>> When i look at the corresponding clock line the previously running
>>>> clock
>>>> has now indeed been stopped (with a time stamp corresponding to the
>>>> current time).
>>>
>>> This is an interesting bug.  It sounds like the point is not being moved
>>> to the correct location to perform the clock-in.  I'll take a look.
>>
>> I did some additional investigation and found that if i'm clocking into
>> an item with an unresolved inactive clock from the agenda (created by
>> deleting the end time in its most recent CLOCK: line) a similar thing
>> happens. I'm actually getting clocked out of the current clock and a new
>> CLOCK line gets added which is then the running clock.
> 
> I think this is what sould happen, no?
Maybe i wasn't clear. The task i'm clocking in to is the same which has
the unresolved clock. After confirming that all pending time should be
resolved to this same task i would have thought that the unresolved
clock would then just be reactivated. But no problem if that's not how
it works.

> 
> The other problem you reported, where I said this is a conflict with
> James' code, should be fixed now.  Please verify.
Yes, it's fixed. Thanks!

> 
> - Carsten
> 
>>
>> Don't know if this helps but stepping through the code in the debugger i
>> get to the following code in org-clock-resolve-clock:
>>
>> ((eq resolve-to 'now)
>> (if restart-p
>>     (error "RESTART-P is not valid here"))
>> (if (or close-p org-clock-clocking-in)       <-- org-close: nil,
>> org-clock-clocking-in: t
>>     (org-clock-clock-out clock fail-quietly) <-- clock-out done here
>>   (unless (org-is-active-clock clock)
>>     (org-clock-clock-in clock t))))
>>
>>
>>
>> _______________________________________________
>> Emacs-orgmode mailing list
>> Remember: use `Reply All' to send replies to the list.
>> Emacs-orgmode@gnu.org
>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
> 
> - Carsten
> 
> 
> 
> 
> 
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>