bug#931: marked as done (23.0.60; Bug in bytecomp.el: displaying warnings)

[don@donarmstrong.com (Emacs bug Tracking System)]

[-- Attachment #1: Type: text/plain, Size: 885 bytes --]


Your message dated Fri, 12 Sep 2008 15:51:59 -0400
with message-id <jwvljxxgn4j.fsf-monnier+emacsbugreports@gnu.org>
and subject line Re: bug#931: 23.0.60; Bug in bytecomp.el: displaying warnings
has caused the Emacs bug report #931,
regarding 23.0.60; Bug in bytecomp.el: displaying warnings
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
931: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=931
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3127 bytes --]

From: Michael Heerdegen <michael_heerdegen@web.de>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.60; Bug in bytecomp.el: displaying warnings
Date: Mon, 8 Sep 2008 21:35:23 +0200
Message-ID: <1220902523.951243.11457@green>

When pop-up-windows is nil, the byte compiler sometimes aborts with
the error message

  End of file during parsing

after displaying warnings, although the source file is ok.


You can reproduce this with CVS Gnu Emacs as follows:

1. Create a file test.el with the following contents:

    (setq a 1)

2. emacs -Q

3. M-: (setq pop-up-windows nil) RET

4. Byte compile test.el


The reason for the bug is an error in `byte-compile-from-buffer'. Its
definition looks like that:

(defun byte-compile-from-buffer (inbuffer &optional filename)
  ...
  (let ...
    (byte-compile-close-variables
     ...
     (displaying-byte-compile-warnings
      ...
      (with-current-buffer inbuffer
        ...
	(while ...
	 ...)
        ...)
      ...))
    ...))

If pop-up-windows is nil, and warnings have to be displayed,
`byte-compile-report-error' is called, and after that,
(current-buffer) will be the Compile Log buffer, and the current
buffer is not restored for further iterations of the while loop.






[-- Attachment #3: Type: message/rfc822, Size: 2289 bytes --]

From: Stefan Monnier <monnier@iro.umontreal.ca>
To: martin rudalics <rudalics@gmx.at>
Cc: 931-close@emacsbugs.donarmstrong.com, michael_heerdegen@web.de
Subject: Re: bug#931: 23.0.60; Bug in bytecomp.el: displaying warnings
Date: Fri, 12 Sep 2008 15:51:59 -0400
Message-ID: <jwvljxxgn4j.fsf-monnier+emacsbugreports@gnu.org>

>> I've fixed this so set-window-buffer should never change
>> current-buffer now.  Does it fix the OP's original problem?
> Keeping my fingers still crossed for that change, so I can't type much
> today ;-)

> FWIW it fixes the original problem

Good, thanks.

> but we should show *Compile-Log* instead of the original buffer when
> compilation finishes.

That's a separate problem.  And I'm not even sure if that's really what
should happen anyway.

> This could be a wishlist item.

Indeed.


        Stefan