bug#868: [PATCH] Make url-basic-auth support non-ascii passwords

bug#868: [PATCH] Make url-basic-auth support non-ascii passwords

[Magnus Henoch]

[-- Attachment #1: Type: text/plain, Size: 91 bytes --]

Package: emacs,url

Just making sure that this doesn't get lost.  Will get to it later...


[-- Attachment #2: Type: message/rfc822, Size: 4209 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 264 bytes --]

Hi,

url-basic-auth uses base64-encode-string but the password string can
contain non-ascii characters. In which case encode-coding-string
should be used. Attached patch fixes the issue.

Regards,
ismail

-- 
Programmer Excuse #26: I suspect it's a bus collision.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2.1.2: url-basic-auth-utf8.patch --]
[-- Type: text/x-diff; name=url-basic-auth-utf8.patch, Size: 498 bytes --]

diff --git a/lisp/url/url-auth.el b/lisp/url/url-auth.el
index ce730ce..d089b18 100644
--- a/lisp/url/url-auth.el
+++ b/lisp/url/url-auth.el
@@ -93,7 +93,7 @@ instead of the filename inheritance method."
 		       (cons file
 			     (setq retval
 				   (base64-encode-string
-				    (format "%s:%s" user pass)))))
+				    (format "%s:%s" user (encode-coding-string pass 'utf-8))))))
 		 (symbol-value url-basic-auth-storage))))
      (byserv
       (setq retval (cdr-safe (assoc file byserv)))

bug#868: marked as done ([PATCH] Make url-basic-auth support non-ascii passwords)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 876 bytes --]


Your message dated Thu, 30 Oct 2008 18:05:00 -0400
with message-id <gc1vxxu4c3.fsf@fencepost.gnu.org>
and subject line Re: Bug#868: Make url-basic-auth support non-ascii passwords
has caused the Emacs bug report #868,
regarding [PATCH] Make url-basic-auth support non-ascii passwords
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
868: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=868
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 5936 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 91 bytes --]

Package: emacs,url

Just making sure that this doesn't get lost.  Will get to it later...


[-- Attachment #2.1.2: Type: message/rfc822, Size: 4209 bytes --]

[-- Attachment #2.1.2.1.1: Type: text/plain, Size: 264 bytes --]

Hi,

url-basic-auth uses base64-encode-string but the password string can
contain non-ascii characters. In which case encode-coding-string
should be used. Attached patch fixes the issue.

Regards,
ismail

-- 
Programmer Excuse #26: I suspect it's a bus collision.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2.1.2.1.2: url-basic-auth-utf8.patch --]
[-- Type: text/x-diff; name=url-basic-auth-utf8.patch, Size: 498 bytes --]

diff --git a/lisp/url/url-auth.el b/lisp/url/url-auth.el
index ce730ce..d089b18 100644
--- a/lisp/url/url-auth.el
+++ b/lisp/url/url-auth.el
@@ -93,7 +93,7 @@ instead of the filename inheritance method."
 		       (cons file
 			     (setq retval
 				   (base64-encode-string
-				    (format "%s:%s" user pass)))))
+				    (format "%s:%s" user (encode-coding-string pass 'utf-8))))))
 		 (symbol-value url-basic-auth-storage))))
      (byserv
       (setq retval (cdr-safe (assoc file byserv)))

[-- Attachment #3: Type: message/rfc822, Size: 1447 bytes --]

From: Glenn Morris <rgm@gnu.org>
To: 868-done@emacsbugs.donarmstrong.com
Subject: Re: Bug#868: Make url-basic-auth support non-ascii passwords
Date: Thu, 30 Oct 2008 18:05:00 -0400
Message-ID: <gc1vxxu4c3.fsf@fencepost.gnu.org>

This was installed:

2008-10-20  Ismail Donmez  <ismail@namtrac.org>  (tiny change)

    * url-auth.el (url-basic-auth): Encode password string.