bug#823: marked as done (23.0.60; uninitialised variable gidx in nsfont.m)

[don@donarmstrong.com (Emacs bug Tracking System)]

[-- Attachment #1: Type: text/plain, Size: 901 bytes --]


Your message dated Fri, 3 Oct 2008 14:03:20 -0400
with message-id <66A91CA5-0AFE-42F4-B27F-3F24BE8626A6@gmail.com>
and subject line #823 - 23.0.60; uninitialised variable gidx in nsfont.m - Emacs bug report logs
has caused the Emacs bug report #823,
regarding 23.0.60; uninitialised variable gidx in nsfont.m
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
823: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=823
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 2957 bytes --]

From: Peter Dyballa <Peter_Dyballa@Freenet.DE>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.60; uninitialised variable gidx in nsfont.m
Date: Fri, 29 Aug 2008 20:50:27 +0200
Message-ID: <1E07482B-CB0C-4EEA-ACA1-6092AFCED8BA@Freenet.DE>

Hello!

This error is reported when I try to compile Emacs.app:

	nsfont.m: In function ‘nsfont_draw’:
	nsfont.m:907: error: ‘struct glyph_string’ has no member named ‘gidx’
	nsfont.m:908: error: ‘struct glyph_string’ has no member named ‘gidx’
	nsfont.m:914: error: ‘struct glyph_string’ has no member named ‘gidx’
	nsfont.m:1097: error: ‘struct glyph_string’ has no member named ‘gidx’
	nsfont.m:1103: error: ‘struct glyph_string’ has no member named ‘gidx’
	make[1]: *** [nsfont.o] Error 1

Obviously a line like this from ftfont.c:1517 is missing:

	int i, j, gidx;

--
Greetings

   Pete

There's no place like ~
		– (UNIX Guru)






[-- Attachment #3: Type: message/rfc822, Size: 2871 bytes --]

From: Adrian Robert <adrian.b.robert@gmail.com>
To: 823-done@emacsbugs.donarmstrong.com
Subject: #823 - 23.0.60; uninitialised variable gidx in nsfont.m - Emacs bug report logs
Date: Fri, 3 Oct 2008 14:03:20 -0400
Message-ID: <66A91CA5-0AFE-42F4-B27F-3F24BE8626A6@gmail.com>

Summary: the variable gidx was removed during Kenichi Handa's update  
of composition handling and it took some time to update all of the  
code using it:


On 2008-08-29  Kenichi Handa changed the glyph_string data structure,  
composition-related portion

On 2008-09-07  Teodor Zlatanov fixed the compiler error by changing  
glyph_string.gidx to glyph_string.cmp_from

On 2008-09-27 Adrian Robert updated this patch to approximate the  
behavior before Handa's changes