From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: don@donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#795: marked as done (Artist: patch 1 (of 2): Cut/copy menu selection bugfix) Date: Wed, 27 Aug 2008 10:30:07 -0700 Message-ID: References: <87y72iz7v8.fsf@cyd.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1219858207-19363-0" X-Trace: ger.gmane.org 1219859336 7742 80.91.229.12 (27 Aug 2008 17:48:56 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 27 Aug 2008 17:48:56 +0000 (UTC) To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 27 19:49:48 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KYP8m-000398-CT for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Aug 2008 19:49:08 +0200 Original-Received: from localhost ([127.0.0.1]:36983 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KYP7o-0006Lk-1t for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Aug 2008 13:48:08 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KYP7G-00063M-6o for bug-gnu-emacs@gnu.org; Wed, 27 Aug 2008 13:47:34 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KYP7F-00062r-AM for bug-gnu-emacs@gnu.org; Wed, 27 Aug 2008 13:47:33 -0400 Original-Received: from [199.232.76.173] (port=34407 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KYP7E-00062e-Ra for bug-gnu-emacs@gnu.org; Wed, 27 Aug 2008 13:47:32 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:54525) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KYP7D-0006Oi-JC for bug-gnu-emacs@gnu.org; Wed, 27 Aug 2008 13:47:32 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m7RHlTFf025198; Wed, 27 Aug 2008 10:47:29 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m7RHU7mA019410; Wed, 27 Aug 2008 10:30:07 -0700 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: don@donarmstrong.com X-Emacs-PR-Message: closed 795 X-Emacs-PR-Package: emacs X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:19776 Archived-At: This is a multi-part message in MIME format... ------------=_1219858207-19363-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Wed, 27 Aug 2008 13:27:07 -0400 with message-id <87y72iz7v8.fsf@cyd.mit.edu> and subject line Re: Artist: patch 2 (of 2): Fix for args-out-of-range error has caused the Emacs bug report #795, regarding Artist: patch 1 (of 2): Cut/copy menu selection bugfix to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact don@donarmstrong.com immediately.) --=20 795: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D795 Emacs Bug Tracking System Contact don@donarmstrong.com with problems ------------=_1219858207-19363-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-5.0 required=4.0 tests=BAYES_00,MURPHY_DRUGS_REL8, RCVD_IN_DNSWL_LOW autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 27 Aug 2008 12:50:12 +0000 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m7RCo28D023447 for ; Wed, 27 Aug 2008 05:50:04 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KYKTK-0006Xm-6F for bug-gnu-emacs@gnu.org; Wed, 27 Aug 2008 08:50:02 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KYKTI-0006WJ-Kc for bug-gnu-emacs@gnu.org; Wed, 27 Aug 2008 08:50:01 -0400 Received: from [199.232.76.173] (port=35858 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KYKTI-0006Vz-42 for bug-gnu-emacs@gnu.org; Wed, 27 Aug 2008 08:50:00 -0400 Received: from mail.lysator.liu.se ([130.236.254.3]:42916) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KYKTH-0006Ky-7t for bug-gnu-emacs@gnu.org; Wed, 27 Aug 2008 08:49:59 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 9E3B62246D38 for ; Wed, 27 Aug 2008 14:49:51 +0200 (CEST) Received: from mail.lysator.liu.se ([127.0.0.1]) by localhost (lenin.lysator.liu.se [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 30260-01-14 for ; Wed, 27 Aug 2008 14:49:51 +0200 (CEST) Received: from sellafield.lysator.liu.se (sellafield.lysator.liu.se [130.236.254.103]) by mail.lysator.liu.se (Postfix) with ESMTP id 3C54C2246D31 for ; Wed, 27 Aug 2008 14:49:51 +0200 (CEST) To: bug-gnu-emacs@gnu.org Subject: Artist: patch 1 (of 2): Cut/copy menu selection bugfix From: Tomas Abrahamsson Date: Wed, 27 Aug 2008 14:49:51 +0200 Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at lysator.liu.se X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) Hi, This is the first of two patches for emacs/lisp/textmodes/artist.el. The patches do not depend on each other. They fix different bugs, but they apply to the same file. The patch is against 1.40 of artist.el as checked out from :pserver:anonymous@cvs.savannah.gnu.org:/sources/emacs The patch is written entirely by me. Bug was found by me. As far as I know, the bug has not been reported anywhere. The bug that this patch fixes is: with the mouse, it was impossible to select the copy and cut operations in the menu. This patch makes it possible to do that. Below is a ChangeLog entry and the patch itself. For the ChangeLog entry, I looked at emacs/lisp/ChangeLog and tried to follow the style therein. (I don't know what's the common practice with the first line (date and name), though since I assume it will be someone else but me who will check this in.) If anythning is unclear or needs more work, please contact me. BRs Tomas The ChangeLog entry: 2008-08-27 Tomas Abrahamsson * textmodes/artist.el (artist-mt): Fixed structures for cut and copy operations. The patch: Index: artist.el =================================================================== RCS file: /sources/emacs/emacs/lisp/textmodes/artist.el,v retrieving revision 1.40 diff -u -r1.40 artist.el --- artist.el 12 Jun 2008 03:56:20 -0000 1.40 +++ artist.el 26 Aug 2008 23:34:05 -0000 @@ -723,14 +723,14 @@ 2 artist-draw-rect (artist-undraw-rect - artist-t artist-cut-rect) + artist-t artist-cut-rect)) ("cut square" cut-s "cut-s" artist-no-arrows nil nil nil nil 2 artist-draw-square (artist-undraw-square - artist-t artist-cut-square)))))) + artist-t artist-cut-square))))) (graphics-operation ("Copy" (("copy rectangle" copy-r "copy-r" @@ -739,14 +739,14 @@ 2 artist-draw-rect (artist-undraw-rect - artist-t artist-copy-rect) + artist-t artist-copy-rect)) ("copy square" copy-s "copy-s" artist-no-arrows nil nil nil nil 2 artist-draw-square (artist-undraw-square - artist-t artist-copy-square)))))) + artist-t artist-copy-square))))) (graphics-operation ("Paste" (("paste" paste "paste" ------------=_1219858207-19363-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-3.6 required=4.0 tests=AWL,BAYES_00, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 795-done) by emacsbugs.donarmstrong.com; 27 Aug 2008 17:25:27 +0000 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m7RHPIqJ018352; Wed, 27 Aug 2008 10:25:19 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id 8A8C057E32E; Wed, 27 Aug 2008 13:27:07 -0400 (EDT) To: Tomas Abrahamsson Cc: 794-done@emacsbugs.donarmstrong.com, 795-done@emacsbugs.donarmstrong.com Subject: Re: Artist: patch 2 (of 2): Fix for args-out-of-range error From: Chong Yidong Date: Wed, 27 Aug 2008 13:27:07 -0400 Message-ID: <87y72iz7v8.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-CrossAssassin-Score: 2 > This is the second of two patches for emacs/lisp/textmodes/artist.el. > The patches do not depend on each other. They fix different bugs, but > they apply to the same file. I've checked in both patches into CVS trunk. Thanks very much. ------------=_1219858207-19363-0--