bug#780: marked as done (Compiler warning in widget.c)

bug#780: marked as done (Compiler warning in widget.c)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 815 bytes --]


Your message dated Tue, 26 Aug 2008 13:13:49 -0400
with message-id <87ljyju2b6.fsf@cyd.mit.edu>
and subject line Re: Compiler warning in widget.c
has caused the Emacs bug report #780,
regarding Compiler warning in widget.c
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
780: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=780
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 2115 bytes --]

From: Glenn Morris <rgm@gnu.org>
To: quiet <quiet@emacsbugs.donarmstrong.com>
Subject: Compiler warning in widget.c
Date: Mon, 25 Aug 2008 21:19:31 -0400
Message-ID: <no7ia47eu4.fsf@fencepost.gnu.org>


Package: emacs
Version: 23.0.60
Severity: normal

Filing a bug so this does not get forgotten about:

http://lists.gnu.org/archive/html/emacs-devel/2008-05/msg01383.html

Eli Zaretskii wrote:

> When compiling widget.c, GCC produces this warning:
>
>     widget.c: In function 'update_from_various_frame_slots':
>     widget.c:662: warning: assignment from incompatible pointer type
>
> This is a real problem, IMO, because the offending line
>
>     ew->emacs_frame.font = x->font;
>
> assigns x->font, which is of type `struct font *' (defined on font.h) to
> ew->emacs_frame.font, whose type is `XFontStruct *' (see widgetpriv.h).
>
> Looks like another fallout of the recent font-related changes?



[-- Attachment #3: Type: message/rfc822, Size: 1019 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Glenn Morris <rgm@gnu.org>
Cc: 780-done@emacsbugs.donarmstrong.com
Subject: Re: Compiler warning in widget.c
Date: Tue, 26 Aug 2008 13:13:49 -0400
Message-ID: <87ljyju2b6.fsf@cyd.mit.edu>

I've checked in a fix (making the EmacsFramePart use `struct font').
Thanks for the reminder.