* bug#698: regexp problem in ldap.el @ 2008-08-12 4:04 ` 中川誠 2008-08-12 18:50 ` bug#698: marked as done (regexp problem in ldap.el) Emacs bug Tracking System 2008-08-24 4:30 ` Emacs bug Tracking System 0 siblings, 2 replies; 9+ messages in thread From: 中川誠 @ 2008-08-12 4:04 UTC (permalink / raw) To: bug-gnu-emacs According to the rfc4512, \w is not good to match against attribute type and options. With the attached patch, options containing hyphens are successfully parsed. P.S. I submitted a bug report about regexp in ldap-search-internal last December, but now I understand that it was a mistake. ---- patch from here ---- --- ldap.orig.el 2008-08-09 08:04:07.000000000 +0900 +++ ldap.el 2008-08-09 22:37:05.000000000 +0900 @@ -582,9 +582,9 @@ (end-of-line) (point)))) (forward-line 1) - (while (looking-at "^\\(\\w*\\)\\(;\\w*\\)?[=:\t ]+\\(<[\t ]*file :\ //\\)\\(.*\\)$") + (while (looking-at "^\\([A-Za-z][-A-Za-z0-9]*\\|[0-9]+\\(\\.[0-9]+\\ )\ *\\)\\(;[-A-Za-z0-9]+\\)*[=:\t ]+\\(<[\t ]*file://\\)\\(.*\\)$") (setq name (match-string 1) - value (match-string 4)) + value (match-string 5)) ;; Need to handle <a href="file:///D:/...">file:///D:/...</a> as g\ enerated by OpenLDAP ;; on DOS/Windows as local files. (if (and (memq system-type '(windows-nt ms-dos)) ---- patch ends here ---- ^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#698: marked as done (regexp problem in ldap.el) 2008-08-12 4:04 ` bug#698: regexp problem in ldap.el 中川誠 @ 2008-08-12 18:50 ` Emacs bug Tracking System 2008-08-24 4:30 ` Emacs bug Tracking System 1 sibling, 0 replies; 9+ messages in thread From: Emacs bug Tracking System @ 2008-08-12 18:50 UTC (permalink / raw) To: Chong Yidong [-- Attachment #1: Type: text/plain, Size: 815 bytes --] Your message dated Tue, 12 Aug 2008 14:42:04 -0400 with message-id <8763q6vzwj.fsf@stupidchicken.com> and subject line Re: regexp problem in ldap.el has caused the Emacs bug report #678, regarding regexp problem in ldap.el to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact don@donarmstrong.com immediately.) -- 678: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=678 Emacs Bug Tracking System Contact don@donarmstrong.com with problems [-- Attachment #2: Type: message/rfc822, Size: 3256 bytes --] From: 中川誠 <gha03025@nifty.ne.jp> To: bug-gnu-emacs@gnu.org Subject: Re: regexp problem in ldap.el Date: Tue, 12 Aug 2008 13:04:40 +0900 (JST) Message-ID: <31147069.79401218513880311.gha03025@nifty.ne.jp> According to the rfc4512, \w is not good to match against attribute type and options. With the attached patch, options containing hyphens are successfully parsed. P.S. I submitted a bug report about regexp in ldap-search-internal last December, but now I understand that it was a mistake. ---- patch from here ---- --- ldap.orig.el 2008-08-09 08:04:07.000000000 +0900 +++ ldap.el 2008-08-09 22:37:05.000000000 +0900 @@ -582,9 +582,9 @@ (end-of-line) (point)))) (forward-line 1) - (while (looking-at "^\\(\\w*\\)\\(;\\w*\\)?[=:\t ]+\\(<[\t ]*file :\ //\\)\\(.*\\)$") + (while (looking-at "^\\([A-Za-z][-A-Za-z0-9]*\\|[0-9]+\\(\\.[0-9]+\\ )\ *\\)\\(;[-A-Za-z0-9]+\\)*[=:\t ]+\\(<[\t ]*file://\\)\\(.*\\)$") (setq name (match-string 1) - value (match-string 4)) + value (match-string 5)) ;; Need to handle <a href="file:///D:/...">file:///D:/...</a> as g\ enerated by OpenLDAP ;; on DOS/Windows as local files. (if (and (memq system-type '(windows-nt ms-dos)) ---- patch ends here ---- [-- Attachment #3: Type: message/rfc822, Size: 1236 bytes --] From: Chong Yidong <cyd@stupidchicken.com> To: manakagawa@manakagawa-debian2.asiapacific.hpqcorp.net Cc: 678-done@emacsbugs.donarmstrong.com, gha03025@nifty.ne.jp Subject: Re: regexp problem in ldap.el Date: Tue, 12 Aug 2008 14:42:04 -0400 Message-ID: <8763q6vzwj.fsf@stupidchicken.com> > According to the rfc4512, \w is not good to match against attribute > type and options. With the attached patch, options containing hyphens > are successfully parsed. I've checked in a slightly altered version of your patch into CVS. Thanks very much. ^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#698: marked as done (regexp problem in ldap.el) 2008-08-12 4:04 ` bug#698: regexp problem in ldap.el 中川誠 2008-08-12 18:50 ` bug#698: marked as done (regexp problem in ldap.el) Emacs bug Tracking System @ 2008-08-24 4:30 ` Emacs bug Tracking System 1 sibling, 0 replies; 9+ messages in thread From: Emacs bug Tracking System @ 2008-08-24 4:30 UTC (permalink / raw) To: Chong Yidong [-- Attachment #1: Type: text/plain, Size: 809 bytes --] Your message dated Sun, 24 Aug 2008 00:23:33 -0400 with message-id <87bpzjvy62.fsf@cyd.mit.edu> and subject line Re: regexp problem in ldap.el has caused the Emacs bug report #698, regarding regexp problem in ldap.el to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact don@donarmstrong.com immediately.) -- 698: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=698 Emacs Bug Tracking System Contact don@donarmstrong.com with problems [-- Attachment #2: Type: message/rfc822, Size: 3256 bytes --] From: 中川誠 <gha03025@nifty.ne.jp> To: bug-gnu-emacs@gnu.org Subject: Re: regexp problem in ldap.el Date: Tue, 12 Aug 2008 13:04:40 +0900 (JST) Message-ID: <31147069.79401218513880311.gha03025@nifty.ne.jp> According to the rfc4512, \w is not good to match against attribute type and options. With the attached patch, options containing hyphens are successfully parsed. P.S. I submitted a bug report about regexp in ldap-search-internal last December, but now I understand that it was a mistake. ---- patch from here ---- --- ldap.orig.el 2008-08-09 08:04:07.000000000 +0900 +++ ldap.el 2008-08-09 22:37:05.000000000 +0900 @@ -582,9 +582,9 @@ (end-of-line) (point)))) (forward-line 1) - (while (looking-at "^\\(\\w*\\)\\(;\\w*\\)?[=:\t ]+\\(<[\t ]*file :\ //\\)\\(.*\\)$") + (while (looking-at "^\\([A-Za-z][-A-Za-z0-9]*\\|[0-9]+\\(\\.[0-9]+\\ )\ *\\)\\(;[-A-Za-z0-9]+\\)*[=:\t ]+\\(<[\t ]*file://\\)\\(.*\\)$") (setq name (match-string 1) - value (match-string 4)) + value (match-string 5)) ;; Need to handle <a href="file:///D:/...">file:///D:/...</a> as g\ enerated by OpenLDAP ;; on DOS/Windows as local files. (if (and (memq system-type '(windows-nt ms-dos)) ---- patch ends here ---- [-- Attachment #3: Type: message/rfc822, Size: 2389 bytes --] From: Chong Yidong <cyd@stupidchicken.com> To: gha03025@nifty.ne.jp (中川 誠) Cc: 698-done@emacsbugs.donarmstrong.com, makoto.nakagawa@hp.com Subject: Re: regexp problem in ldap.el Date: Sun, 24 Aug 2008 00:23:33 -0400 Message-ID: <87bpzjvy62.fsf@cyd.mit.edu> gha03025@nifty.ne.jp (中川 誠) writes: > What I mean by garbage is backslash and LF at the end of lines. > Shouldn't it be like the following? > > --- from here --- > --- ldap.1.26.2.3.el 2008-08-24 06:40:45.000000000 +0900 > +++ ldap.el 2008-08-24 06:46:27.000000000 +0900 > @@ -584,9 +584,7 @@ > (end-of-line) > (point)))) > (forward-line 1) > - (while (looking-at "^\\([A-Za-z][-A-Za-z0-9]*\ > -\\|[0-9]+\\(?:\\.[0-9]+\\)*\\)\\(;[-A-Za-z0-9]+\\)*[=:\t ]+\ > -\\(<[\t ]*file://\\)\\(.*\\)$") > + (while (looking-at "^\\([A-Za-z][-A-Za-z0-9]*\\|[0-9]+\\(?:\\.[0-9]+\\)*\\)\\(;[-A-Za-z0-9]+\\)*[=:\t ]+\\(<[\t ]*file://\\)\\(.*\\)$") > (setq name (match-string 1) > value (match-string 4)) > ;; Need to handle file:///D:/... as generated by OpenLDAP That's just to break up the long string into lines so it is easier to read. It shouldn't affect the functioning of the lisp code. ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <1820-Sat09Aug2008170612+0900-manakagawa@manakagawa-debian2.asiapacific.hpqcorp.net>]
* bug#678: marked as done (regexp problem in ldap.el) [not found] ` <1820-Sat09Aug2008170612+0900-manakagawa@manakagawa-debian2.asiapacific.hpqcorp.net> @ 2008-08-12 18:50 ` Emacs bug Tracking System 2008-08-24 4:30 ` Emacs bug Tracking System 1 sibling, 0 replies; 9+ messages in thread From: Emacs bug Tracking System @ 2008-08-12 18:50 UTC (permalink / raw) To: Chong Yidong [-- Attachment #1: Type: text/plain, Size: 815 bytes --] Your message dated Tue, 12 Aug 2008 14:42:04 -0400 with message-id <8763q6vzwj.fsf@stupidchicken.com> and subject line Re: regexp problem in ldap.el has caused the Emacs bug report #678, regarding regexp problem in ldap.el to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact don@donarmstrong.com immediately.) -- 678: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=678 Emacs Bug Tracking System Contact don@donarmstrong.com with problems [-- Attachment #2: Type: message/rfc822, Size: 5470 bytes --] [-- Attachment #2.1.1.1: Type: text/plain, Size: 646 bytes --] Hi, According to the rfc4512, \w is not good to match aginst attribuite type and options. Wtith the attached patch, options containing hyphens are sucessfully parsed. P.S. I submitted a bug report about regexp in ldap-search-internal last December, but it was a mistake. -- /*** Hewlett-Packard Japan, Ltd. ***/ /*** Consulting & Integration ***/ /*** PC-CW-SOL#1 Professional Center ***/ /*** Nakagawa, Makoto（中川 誠） 050 3158 4747 (Dial-In) ***/ /*** PGP: 0B33 EAC3 F2F6 3D10 D9E9 AE7F 8EDA 44F9 1D29 D44A ***/ [-- Attachment #2.1.1.2: Type: application/octet-stream, Size: 720 bytes --] --- ldap.orig.el 2008-08-09 08:04:07.000000000 +0900 +++ ldap.el 2008-08-09 08:04:20.000000000 +0900 @@ -582,9 +582,9 @@ (end-of-line) (point)))) (forward-line 1) - (while (looking-at "^\\(\\w*\\)\\(;\\w*\\)?[=:\t ]+\\(<[\t ]*file://\\)\\(.*\\)$") + (while (looking-at "^\\([A-Za-z][-A-Za-z0-9]*\\|[0-9]\\(\\.[0-9]\\)*\\)\\(;[-A-Za-z0-9]*\\)?[=:\t ]+\\(<[\t ]*file://\\)\\(.*\\)$") (setq name (match-string 1) - value (match-string 4)) + value (match-string 5)) ;; Need to handle <a href="file:///D:/...">file:///D:/...</a> as generated by OpenLDAP ;; on DOS/Windows as local files. (if (and (memq system-type '(windows-nt ms-dos)) [-- Attachment #2.1.2: Type: application/pgp-signature, Size: 307 bytes --] [-- Attachment #3: Type: message/rfc822, Size: 1236 bytes --] From: Chong Yidong <cyd@stupidchicken.com> To: manakagawa@manakagawa-debian2.asiapacific.hpqcorp.net Cc: 678-done@emacsbugs.donarmstrong.com, gha03025@nifty.ne.jp Subject: Re: regexp problem in ldap.el Date: Tue, 12 Aug 2008 14:42:04 -0400 Message-ID: <8763q6vzwj.fsf@stupidchicken.com> > According to the rfc4512, \w is not good to match against attribute > type and options. With the attached patch, options containing hyphens > are successfully parsed. I've checked in a slightly altered version of your patch into CVS. Thanks very much. ^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#678: marked as done (regexp problem in ldap.el) [not found] ` <1820-Sat09Aug2008170612+0900-manakagawa@manakagawa-debian2.asiapacific.hpqcorp.net> 2008-08-12 18:50 ` bug#678: " Emacs bug Tracking System @ 2008-08-24 4:30 ` Emacs bug Tracking System 1 sibling, 0 replies; 9+ messages in thread From: Emacs bug Tracking System @ 2008-08-24 4:30 UTC (permalink / raw) To: Chong Yidong [-- Attachment #1: Type: text/plain, Size: 809 bytes --] Your message dated Sun, 24 Aug 2008 00:23:33 -0400 with message-id <87bpzjvy62.fsf@cyd.mit.edu> and subject line Re: regexp problem in ldap.el has caused the Emacs bug report #698, regarding regexp problem in ldap.el to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact don@donarmstrong.com immediately.) -- 698: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=698 Emacs Bug Tracking System Contact don@donarmstrong.com with problems [-- Attachment #2: Type: message/rfc822, Size: 5470 bytes --] [-- Attachment #2.1.1.1: Type: text/plain, Size: 646 bytes --] Hi, According to the rfc4512, \w is not good to match aginst attribuite type and options. Wtith the attached patch, options containing hyphens are sucessfully parsed. P.S. I submitted a bug report about regexp in ldap-search-internal last December, but it was a mistake. -- /*** Hewlett-Packard Japan, Ltd. ***/ /*** Consulting & Integration ***/ /*** PC-CW-SOL#1 Professional Center ***/ /*** Nakagawa, Makoto（中川 誠） 050 3158 4747 (Dial-In) ***/ /*** PGP: 0B33 EAC3 F2F6 3D10 D9E9 AE7F 8EDA 44F9 1D29 D44A ***/ [-- Attachment #2.1.1.2: Type: application/octet-stream, Size: 720 bytes --] --- ldap.orig.el 2008-08-09 08:04:07.000000000 +0900 +++ ldap.el 2008-08-09 08:04:20.000000000 +0900 @@ -582,9 +582,9 @@ (end-of-line) (point)))) (forward-line 1) - (while (looking-at "^\\(\\w*\\)\\(;\\w*\\)?[=:\t ]+\\(<[\t ]*file://\\)\\(.*\\)$") + (while (looking-at "^\\([A-Za-z][-A-Za-z0-9]*\\|[0-9]\\(\\.[0-9]\\)*\\)\\(;[-A-Za-z0-9]*\\)?[=:\t ]+\\(<[\t ]*file://\\)\\(.*\\)$") (setq name (match-string 1) - value (match-string 4)) + value (match-string 5)) ;; Need to handle <a href="file:///D:/...">file:///D:/...</a> as generated by OpenLDAP ;; on DOS/Windows as local files. (if (and (memq system-type '(windows-nt ms-dos)) [-- Attachment #2.1.2: Type: application/pgp-signature, Size: 307 bytes --] [-- Attachment #3: Type: message/rfc822, Size: 2389 bytes --] From: Chong Yidong <cyd@stupidchicken.com> To: gha03025@nifty.ne.jp (中川 誠) Cc: 698-done@emacsbugs.donarmstrong.com, makoto.nakagawa@hp.com Subject: Re: regexp problem in ldap.el Date: Sun, 24 Aug 2008 00:23:33 -0400 Message-ID: <87bpzjvy62.fsf@cyd.mit.edu> gha03025@nifty.ne.jp (中川 誠) writes: > What I mean by garbage is backslash and LF at the end of lines. > Shouldn't it be like the following? > > --- from here --- > --- ldap.1.26.2.3.el 2008-08-24 06:40:45.000000000 +0900 > +++ ldap.el 2008-08-24 06:46:27.000000000 +0900 > @@ -584,9 +584,7 @@ > (end-of-line) > (point)))) > (forward-line 1) > - (while (looking-at "^\\([A-Za-z][-A-Za-z0-9]*\ > -\\|[0-9]+\\(?:\\.[0-9]+\\)*\\)\\(;[-A-Za-z0-9]+\\)*[=:\t ]+\ > -\\(<[\t ]*file://\\)\\(.*\\)$") > + (while (looking-at "^\\([A-Za-z][-A-Za-z0-9]*\\|[0-9]+\\(?:\\.[0-9]+\\)*\\)\\(;[-A-Za-z0-9]+\\)*[=:\t ]+\\(<[\t ]*file://\\)\\(.*\\)$") > (setq name (match-string 1) > value (match-string 4)) > ;; Need to handle file:///D:/... as generated by OpenLDAP That's just to break up the long string into lines so it is easier to read. It shouldn't affect the functioning of the lisp code. ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <2817-Tue12Aug2008043902+0900-manakagawa@manakagawa-debian2.asiapacific.hpqcorp.net>]
* bug#696: marked as done (regexp problem in ldap.el) [not found] ` <2817-Tue12Aug2008043902+0900-manakagawa@manakagawa-debian2.asiapacific.hpqcorp.net> @ 2008-08-12 18:50 ` Emacs bug Tracking System 2008-08-24 4:30 ` Emacs bug Tracking System 1 sibling, 0 replies; 9+ messages in thread From: Emacs bug Tracking System @ 2008-08-12 18:50 UTC (permalink / raw) To: Chong Yidong [-- Attachment #1: Type: text/plain, Size: 815 bytes --] Your message dated Tue, 12 Aug 2008 14:42:04 -0400 with message-id <8763q6vzwj.fsf@stupidchicken.com> and subject line Re: regexp problem in ldap.el has caused the Emacs bug report #678, regarding regexp problem in ldap.el to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact don@donarmstrong.com immediately.) -- 678: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=678 Emacs Bug Tracking System Contact don@donarmstrong.com with problems [-- Attachment #2: Type: message/rfc822, Size: 4579 bytes --] From: manakagawa@manakagawa-debian2.asiapacific.hpqcorp.net (中川 誠) To: "bug-gnu-emacs@gnu.org" <bug-gnu-emacs@gnu.org> Subject: Re: regexp problem in ldap.el Date: Tue, 12 Aug 2008 04:39:02 +0900 Message-ID: <2817-Tue12Aug2008043902+0900-manakagawa@manakagawa-debian2.asiapacific.hpqcorp.net> Hi, According to the rfc4512, \w is not good to match aginst attribuite type and options. Wtith the attached patch, options containing hyphens are sucessfully parsed. P.S. I submitted a bug report about regexp in ldap-search-internal last December, but now I understand that it was a mistake. -- /*** Hewlett-Packard Japan, Ltd. ***/ /*** Consulting & Integration ***/ /*** PC-CW-SOL#1 Professional Center ***/ /*** Nakagawa, Makoto（中川 誠） 050 3158 4747 (Dial-In) ***/ /*** PGP: 0B33 EAC3 F2F6 3D10 D9E9 AE7F 8EDA 44F9 1D29 D44A ***/ --[[application/octet-stream; type=patch]「7bit]] --- ldap.orig.el 2008-08-09 08:04:07.000000000 +0900 +++ ldap.el 2008-08-09 22:37:05.000000000 +0900 @@ -582,9 +582,9 @@ (end-of-line) (point)))) (forward-line 1) - (while (looking-at "^\\(\\w*\\)\\(;\\w*\\)?[=:\t ]+\\(<[\t ]*file://\\)\\(.*\\)$") + (while (looking-at "^\\([A-Za-z][-A-Za-z0-9]*\\|[0-9]+\\(\\.[0-9]+\\)*\\)\\(;[-A-Za-z0-9]+\\)*[=:\t ]+\\(<[\t ]*file://\\)\\(.*\\)$") (setq name (match-string 1) - value (match-string 4)) + value (match-string 5)) ;; Need to handle <a href="file:///D:/...">file:///D:/...</a> as generated by OpenLDAP ;; on DOS/Windows as local files. (if (and (memq system-type '(windows-nt ms-dos)) [-- Attachment #3: Type: message/rfc822, Size: 1236 bytes --] From: Chong Yidong <cyd@stupidchicken.com> To: manakagawa@manakagawa-debian2.asiapacific.hpqcorp.net Cc: 678-done@emacsbugs.donarmstrong.com, gha03025@nifty.ne.jp Subject: Re: regexp problem in ldap.el Date: Tue, 12 Aug 2008 14:42:04 -0400 Message-ID: <8763q6vzwj.fsf@stupidchicken.com> > According to the rfc4512, \w is not good to match against attribute > type and options. With the attached patch, options containing hyphens > are successfully parsed. I've checked in a slightly altered version of your patch into CVS. Thanks very much. ^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#696: marked as done (regexp problem in ldap.el) [not found] ` <2817-Tue12Aug2008043902+0900-manakagawa@manakagawa-debian2.asiapacific.hpqcorp.net> 2008-08-12 18:50 ` bug#696: " Emacs bug Tracking System @ 2008-08-24 4:30 ` Emacs bug Tracking System 1 sibling, 0 replies; 9+ messages in thread From: Emacs bug Tracking System @ 2008-08-24 4:30 UTC (permalink / raw) To: Chong Yidong [-- Attachment #1: Type: text/plain, Size: 809 bytes --] Your message dated Sun, 24 Aug 2008 00:23:33 -0400 with message-id <87bpzjvy62.fsf@cyd.mit.edu> and subject line Re: regexp problem in ldap.el has caused the Emacs bug report #698, regarding regexp problem in ldap.el to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact don@donarmstrong.com immediately.) -- 698: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=698 Emacs Bug Tracking System Contact don@donarmstrong.com with problems [-- Attachment #2: Type: message/rfc822, Size: 4579 bytes --] From: manakagawa@manakagawa-debian2.asiapacific.hpqcorp.net (中川 誠) To: "bug-gnu-emacs@gnu.org" <bug-gnu-emacs@gnu.org> Subject: Re: regexp problem in ldap.el Date: Tue, 12 Aug 2008 04:39:02 +0900 Message-ID: <2817-Tue12Aug2008043902+0900-manakagawa@manakagawa-debian2.asiapacific.hpqcorp.net> Hi, According to the rfc4512, \w is not good to match aginst attribuite type and options. Wtith the attached patch, options containing hyphens are sucessfully parsed. P.S. I submitted a bug report about regexp in ldap-search-internal last December, but now I understand that it was a mistake. -- /*** Hewlett-Packard Japan, Ltd. ***/ /*** Consulting & Integration ***/ /*** PC-CW-SOL#1 Professional Center ***/ /*** Nakagawa, Makoto（中川 誠） 050 3158 4747 (Dial-In) ***/ /*** PGP: 0B33 EAC3 F2F6 3D10 D9E9 AE7F 8EDA 44F9 1D29 D44A ***/ --[[application/octet-stream; type=patch]「7bit]] --- ldap.orig.el 2008-08-09 08:04:07.000000000 +0900 +++ ldap.el 2008-08-09 22:37:05.000000000 +0900 @@ -582,9 +582,9 @@ (end-of-line) (point)))) (forward-line 1) - (while (looking-at "^\\(\\w*\\)\\(;\\w*\\)?[=:\t ]+\\(<[\t ]*file://\\)\\(.*\\)$") + (while (looking-at "^\\([A-Za-z][-A-Za-z0-9]*\\|[0-9]+\\(\\.[0-9]+\\)*\\)\\(;[-A-Za-z0-9]+\\)*[=:\t ]+\\(<[\t ]*file://\\)\\(.*\\)$") (setq name (match-string 1) - value (match-string 4)) + value (match-string 5)) ;; Need to handle <a href="file:///D:/...">file:///D:/...</a> as generated by OpenLDAP ;; on DOS/Windows as local files. (if (and (memq system-type '(windows-nt ms-dos)) [-- Attachment #3: Type: message/rfc822, Size: 2389 bytes --] From: Chong Yidong <cyd@stupidchicken.com> To: gha03025@nifty.ne.jp (中川 誠) Cc: 698-done@emacsbugs.donarmstrong.com, makoto.nakagawa@hp.com Subject: Re: regexp problem in ldap.el Date: Sun, 24 Aug 2008 00:23:33 -0400 Message-ID: <87bpzjvy62.fsf@cyd.mit.edu> gha03025@nifty.ne.jp (中川 誠) writes: > What I mean by garbage is backslash and LF at the end of lines. > Shouldn't it be like the following? > > --- from here --- > --- ldap.1.26.2.3.el 2008-08-24 06:40:45.000000000 +0900 > +++ ldap.el 2008-08-24 06:46:27.000000000 +0900 > @@ -584,9 +584,7 @@ > (end-of-line) > (point)))) > (forward-line 1) > - (while (looking-at "^\\([A-Za-z][-A-Za-z0-9]*\ > -\\|[0-9]+\\(?:\\.[0-9]+\\)*\\)\\(;[-A-Za-z0-9]+\\)*[=:\t ]+\ > -\\(<[\t ]*file://\\)\\(.*\\)$") > + (while (looking-at "^\\([A-Za-z][-A-Za-z0-9]*\\|[0-9]+\\(?:\\.[0-9]+\\)*\\)\\(;[-A-Za-z0-9]+\\)*[=:\t ]+\\(<[\t ]*file://\\)\\(.*\\)$") > (setq name (match-string 1) > value (match-string 4)) > ;; Need to handle file:///D:/... as generated by OpenLDAP That's just to break up the long string into lines so it is easier to read. It shouldn't affect the functioning of the lisp code. ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <8409-Mon11Aug2008191737+0900-manakagawa@manakagawa-debian2.asiapacific.hpqcorp.net>]
* bug#693: marked as done (regexp problem in ldap.el) [not found] ` <8409-Mon11Aug2008191737+0900-manakagawa@manakagawa-debian2.asiapacific.hpqcorp.net> @ 2008-08-12 18:50 ` Emacs bug Tracking System 2008-08-24 4:30 ` Emacs bug Tracking System 1 sibling, 0 replies; 9+ messages in thread From: Emacs bug Tracking System @ 2008-08-12 18:50 UTC (permalink / raw) To: Chong Yidong [-- Attachment #1: Type: text/plain, Size: 815 bytes --] Your message dated Tue, 12 Aug 2008 14:42:04 -0400 with message-id <8763q6vzwj.fsf@stupidchicken.com> and subject line Re: regexp problem in ldap.el has caused the Emacs bug report #678, regarding regexp problem in ldap.el to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact don@donarmstrong.com immediately.) -- 678: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=678 Emacs Bug Tracking System Contact don@donarmstrong.com with problems [-- Attachment #2: Type: message/rfc822, Size: 5332 bytes --] [-- Attachment #2.1.1.1: Type: text/plain, Size: 668 bytes --] Hi, According to the rfc4512, \w is not good to match aginst attribuite type and options. Wtith the attached patch, options containing hyphens are sucessfully parsed. P.S. I submitted a bug report about regexp in ldap-search-internal last December, but now I understand that it was a mistake. -- /*** Hewlett-Packard Japan, Ltd. ***/ /*** Consulting & Integration ***/ /*** PC-CW-SOL#1 Professional Center ***/ /*** Nakagawa, Makoto（中川 誠） 050 3158 4747 (Dial-In) ***/ /*** PGP: 0B33 EAC3 F2F6 3D10 D9E9 AE7F 8EDA 44F9 1D29 D44A ***/ [-- Attachment #2.1.1.2: Type: application/octet-stream, Size: 722 bytes --] --- ldap.orig.el 2008-08-09 08:04:07.000000000 +0900 +++ ldap.el 2008-08-09 22:37:05.000000000 +0900 @@ -582,9 +582,9 @@ (end-of-line) (point)))) (forward-line 1) - (while (looking-at "^\\(\\w*\\)\\(;\\w*\\)?[=:\t ]+\\(<[\t ]*file://\\)\\(.*\\)$") + (while (looking-at "^\\([A-Za-z][-A-Za-z0-9]*\\|[0-9]+\\(\\.[0-9]+\\)*\\)\\(;[-A-Za-z0-9]+\\)*[=:\t ]+\\(<[\t ]*file://\\)\\(.*\\)$") (setq name (match-string 1) - value (match-string 4)) + value (match-string 5)) ;; Need to handle <a href="file:///D:/...">file:///D:/...</a> as generated by OpenLDAP ;; on DOS/Windows as local files. (if (and (memq system-type '(windows-nt ms-dos)) [-- Attachment #2.1.2: Type: application/pgp-signature, Size: 307 bytes --] [-- Attachment #3: Type: message/rfc822, Size: 1236 bytes --] From: Chong Yidong <cyd@stupidchicken.com> To: manakagawa@manakagawa-debian2.asiapacific.hpqcorp.net Cc: 678-done@emacsbugs.donarmstrong.com, gha03025@nifty.ne.jp Subject: Re: regexp problem in ldap.el Date: Tue, 12 Aug 2008 14:42:04 -0400 Message-ID: <8763q6vzwj.fsf@stupidchicken.com> > According to the rfc4512, \w is not good to match against attribute > type and options. With the attached patch, options containing hyphens > are successfully parsed. I've checked in a slightly altered version of your patch into CVS. Thanks very much. ^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#693: marked as done (regexp problem in ldap.el) [not found] ` <8409-Mon11Aug2008191737+0900-manakagawa@manakagawa-debian2.asiapacific.hpqcorp.net> 2008-08-12 18:50 ` bug#693: " Emacs bug Tracking System @ 2008-08-24 4:30 ` Emacs bug Tracking System 1 sibling, 0 replies; 9+ messages in thread From: Emacs bug Tracking System @ 2008-08-24 4:30 UTC (permalink / raw) To: Chong Yidong [-- Attachment #1: Type: text/plain, Size: 809 bytes --] Your message dated Sun, 24 Aug 2008 00:23:33 -0400 with message-id <87bpzjvy62.fsf@cyd.mit.edu> and subject line Re: regexp problem in ldap.el has caused the Emacs bug report #698, regarding regexp problem in ldap.el to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact don@donarmstrong.com immediately.) -- 698: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=698 Emacs Bug Tracking System Contact don@donarmstrong.com with problems [-- Attachment #2: Type: message/rfc822, Size: 5332 bytes --] [-- Attachment #2.1.1.1: Type: text/plain, Size: 668 bytes --] Hi, According to the rfc4512, \w is not good to match aginst attribuite type and options. Wtith the attached patch, options containing hyphens are sucessfully parsed. P.S. I submitted a bug report about regexp in ldap-search-internal last December, but now I understand that it was a mistake. -- /*** Hewlett-Packard Japan, Ltd. ***/ /*** Consulting & Integration ***/ /*** PC-CW-SOL#1 Professional Center ***/ /*** Nakagawa, Makoto（中川 誠） 050 3158 4747 (Dial-In) ***/ /*** PGP: 0B33 EAC3 F2F6 3D10 D9E9 AE7F 8EDA 44F9 1D29 D44A ***/ [-- Attachment #2.1.1.2: Type: application/octet-stream, Size: 722 bytes --] --- ldap.orig.el 2008-08-09 08:04:07.000000000 +0900 +++ ldap.el 2008-08-09 22:37:05.000000000 +0900 @@ -582,9 +582,9 @@ (end-of-line) (point)))) (forward-line 1) - (while (looking-at "^\\(\\w*\\)\\(;\\w*\\)?[=:\t ]+\\(<[\t ]*file://\\)\\(.*\\)$") + (while (looking-at "^\\([A-Za-z][-A-Za-z0-9]*\\|[0-9]+\\(\\.[0-9]+\\)*\\)\\(;[-A-Za-z0-9]+\\)*[=:\t ]+\\(<[\t ]*file://\\)\\(.*\\)$") (setq name (match-string 1) - value (match-string 4)) + value (match-string 5)) ;; Need to handle <a href="file:///D:/...">file:///D:/...</a> as generated by OpenLDAP ;; on DOS/Windows as local files. (if (and (memq system-type '(windows-nt ms-dos)) [-- Attachment #2.1.2: Type: application/pgp-signature, Size: 307 bytes --] [-- Attachment #3: Type: message/rfc822, Size: 2389 bytes --] From: Chong Yidong <cyd@stupidchicken.com> To: gha03025@nifty.ne.jp (中川 誠) Cc: 698-done@emacsbugs.donarmstrong.com, makoto.nakagawa@hp.com Subject: Re: regexp problem in ldap.el Date: Sun, 24 Aug 2008 00:23:33 -0400 Message-ID: <87bpzjvy62.fsf@cyd.mit.edu> gha03025@nifty.ne.jp (中川 誠) writes: > What I mean by garbage is backslash and LF at the end of lines. > Shouldn't it be like the following? > > --- from here --- > --- ldap.1.26.2.3.el 2008-08-24 06:40:45.000000000 +0900 > +++ ldap.el 2008-08-24 06:46:27.000000000 +0900 > @@ -584,9 +584,7 @@ > (end-of-line) > (point)))) > (forward-line 1) > - (while (looking-at "^\\([A-Za-z][-A-Za-z0-9]*\ > -\\|[0-9]+\\(?:\\.[0-9]+\\)*\\)\\(;[-A-Za-z0-9]+\\)*[=:\t ]+\ > -\\(<[\t ]*file://\\)\\(.*\\)$") > + (while (looking-at "^\\([A-Za-z][-A-Za-z0-9]*\\|[0-9]+\\(?:\\.[0-9]+\\)*\\)\\(;[-A-Za-z0-9]+\\)*[=:\t ]+\\(<[\t ]*file://\\)\\(.*\\)$") > (setq name (match-string 1) > value (match-string 4)) > ;; Need to handle file:///D:/... as generated by OpenLDAP That's just to break up the long string into lines so it is easier to read. It shouldn't affect the functioning of the lisp code. ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2008-08-24 4:30 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <8763q6vzwj.fsf@stupidchicken.com>
2008-08-12 4:04 ` bug#698: regexp problem in ldap.el 中川誠
2008-08-12 18:50 ` bug#698: marked as done (regexp problem in ldap.el) Emacs bug Tracking System
2008-08-24 4:30 ` Emacs bug Tracking System
[not found] ` <1820-Sat09Aug2008170612+0900-manakagawa@manakagawa-debian2.asiapacific.hpqcorp.net>
2008-08-12 18:50 ` bug#678: " Emacs bug Tracking System
2008-08-24 4:30 ` Emacs bug Tracking System
[not found] ` <2817-Tue12Aug2008043902+0900-manakagawa@manakagawa-debian2.asiapacific.hpqcorp.net>
2008-08-12 18:50 ` bug#696: " Emacs bug Tracking System
2008-08-24 4:30 ` Emacs bug Tracking System
[not found] ` <8409-Mon11Aug2008191737+0900-manakagawa@manakagawa-debian2.asiapacific.hpqcorp.net>
2008-08-12 18:50 ` bug#693: " Emacs bug Tracking System
2008-08-24 4:30 ` Emacs bug Tracking System
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.