From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#687: marked as done (23.0.60; Mouse wheel should not trigger mouse avoidance) Date: Sat, 03 Jan 2009 15:10:04 +0000 Message-ID: References: <495F7DF1.9000705@gnu.org> <489F5659.8020801@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1230995404-21313-0" X-Trace: ger.gmane.org 1230996250 29409 80.91.229.12 (3 Jan 2009 15:24:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 3 Jan 2009 15:24:10 +0000 (UTC) To: Jason Rumney Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 03 16:25:18 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LJ8NI-0005LK-Bw for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Jan 2009 16:25:17 +0100 Original-Received: from localhost ([127.0.0.1]:39083 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LJ8M3-0007LQ-3I for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Jan 2009 10:23:59 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LJ8Lr-0007Db-1q for bug-gnu-emacs@gnu.org; Sat, 03 Jan 2009 10:23:47 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LJ8Lp-0007CO-W7 for bug-gnu-emacs@gnu.org; Sat, 03 Jan 2009 10:23:46 -0500 Original-Received: from [199.232.76.173] (port=59148 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LJ8Lp-0007C2-Me for bug-gnu-emacs@gnu.org; Sat, 03 Jan 2009 10:23:45 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:37362) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LJ8Lm-0001to-OL; Sat, 03 Jan 2009 10:23:43 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n03FNN7X025186; Sat, 3 Jan 2009 07:23:23 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n03FA4jw021414; Sat, 3 Jan 2009 07:10:04 -0800 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 687 X-Emacs-PR-Package: emacs,w32 X-Emacs-PR-Keywords: patch X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:23723 Archived-At: This is a multi-part message in MIME format... ------------=_1230995404-21313-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Sat, 03 Jan 2009 23:02:09 +0800 with message-id <495F7DF1.9000705@gnu.org> and subject line Re: bug#687: 23.0.60; Mouse wheel should not trigger mouse= avoidance has caused the Emacs bug report #687, regarding 23.0.60; Mouse wheel should not trigger mouse avoidance to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 687: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D687 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1230995404-21313-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.7 required=4.0 tests=AWL,BAYES_00,MIXEDBDN, MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 10 Aug 2008 20:58:13 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m7AKw9p2013982 for ; Sun, 10 Aug 2008 13:58:11 -0700 Received: from mx10.gnu.org ([199.232.76.166]:39588) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KSHyH-0001oA-Hr for emacs-pretest-bug@gnu.org; Sun, 10 Aug 2008 16:57:01 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KSHzJ-00052h-3Y for emacs-pretest-bug@gnu.org; Sun, 10 Aug 2008 16:58:08 -0400 Received: from ch-smtp02.sth.basefarm.net ([80.76.149.213]:35936) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KSHzI-00052P-Nw for emacs-pretest-bug@gnu.org; Sun, 10 Aug 2008 16:58:04 -0400 Received: from c83-254-151-176.bredband.comhem.se ([83.254.151.176]:65363 helo=[127.0.0.1]) by ch-smtp02.sth.basefarm.net with esmtp (Exim 4.68) (envelope-from ) id 1KSHzG-0006iG-8b for emacs-pretest-bug@gnu.org; Sun, 10 Aug 2008 22:58:03 +0200 Message-ID: <489F5659.8020801@gmail.com> Date: Sun, 10 Aug 2008 22:58:01 +0200 From: "Lennart Borgman (gmail)" User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: emacs-pretest-bug@gnu.org Subject: 23.0.60; Mouse wheel should not trigger mouse avoidance Content-Type: multipart/mixed; boundary="------------080400000408060308030903" X-Antivirus: avast! (VPS 080809-0, 2008-08-09), Outbound message X-Antivirus-Status: Clean X-Originating-IP: 83.254.151.176 X-Scan-Result: No virus found in message 1KSHzG-0006iG-8b. X-Scan-Signature: ch-smtp02.sth.basefarm.net 1KSHzG-0006iG-8b 60203ba265f4d0fad2be7a06278c90ae X-detected-kernel: by monty-python.gnu.org: Linux 2.6? (barebone, rare!) This is a multi-part message in MIME format. --------------080400000408060308030903 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit I noticed that mouse wheel events might trigger mouse avoidance. That seems inappropriate. The attached patch should fix that. Please notice that I am a bit unsure about what the event names could be. There are probably more event names than those I have entered. In keyboard.c there is the following code: static char *lispy_wheel_names[] = { "wheel-up", "wheel-down", "wheel-left", "wheel-right" }; In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600) of 2008-08-10 --------------080400000408060308030903 Content-Type: text/plain; name="avoid-wheel.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="avoid-wheel.diff" Index: avoid.el =================================================================== RCS file: /sources/emacs/emacs/lisp/avoid.el,v retrieving revision 1.47 diff -u -r1.47 avoid.el --- avoid.el 6 May 2008 07:57:26 -0000 1.47 +++ avoid.el 10 Aug 2008 20:42:26 -0000 @@ -289,7 +289,9 @@ (let ((modifiers (event-modifiers (car last-input-event)))) (or (memq (car last-input-event) '(mouse-movement scroll-bar-movement - select-window switch-frame)) + select-window switch-frame + wheel-down wheel-up double-wheel-up double-wheel-down + )) (memq 'click modifiers) (memq 'double modifiers) (memq 'triple modifiers) --------------080400000408060308030903-- ------------=_1230995404-21313-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 687-done) by emacsbugs.donarmstrong.com; 3 Jan 2009 15:02:41 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,RCVD_IN_SBLXBL,RCVD_IN_SBLXBL_CBL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ti-out-0910.google.com (ti-out-0910.google.com [209.85.142.190]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n03F2bZ9019319 for <687-done@emacsbugs.donarmstrong.com>; Sat, 3 Jan 2009 07:02:39 -0800 Received: by ti-out-0910.google.com with SMTP id b6so4982010tic.1 for <687-done@emacsbugs.donarmstrong.com>; Sat, 03 Jan 2009 07:02:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=cVqh0FuVr2V6BUKpNIbunZqzhmQZHG2SboKp+UkKDdM=; b=ioLJHvk5HZHrWjt216jDGqVf3ymPKoneUIOM3m0MFsh9fK1dOv74l1tzXazkc9delX qdi00tCqUW5mPlNL8kqiPnTQB3MoRIeyIuF3IvUUfJMf6/fDYAc897CDg0NOifF+JFP5 uYvNd5I/tnxQGAGlB6qjTc4IW4pzlnxIPrUpo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=QprtYJ9TohuV27sdlY2x98q9Ep494RhGkvdBtcOya07+ZeVAye0jCGSJ4PKlBc0rGC wRsq4WKWd5GSpz5DcNIQB/Wqb452M9NtdSnIVk/tg8/iDkYZh0dGT+8TzDnZOQGXuhml QCzjXw/LzLgVtxatSCvgj8RXnnwh6vx34mEgY= Received: by 10.110.11.7 with SMTP id 7mr22281036tik.8.1230994956735; Sat, 03 Jan 2009 07:02:36 -0800 (PST) Received: from ?192.168.249.26? ([124.13.5.7]) by mx.google.com with ESMTPS id 2sm12704769tif.19.2009.01.03.07.02.34 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 03 Jan 2009 07:02:35 -0800 (PST) Sender: Jason Rumney Message-ID: <495F7DF1.9000705@gnu.org> Date: Sat, 03 Jan 2009 23:02:09 +0800 From: Jason Rumney User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) MIME-Version: 1.0 To: 687-done@emacsbugs.donarmstrong.com CC: "Lennart Borgman (gmail)" , Chong Yidong Subject: Re: bug#687: 23.0.60; Mouse wheel should not trigger mouse avoidance References: <873alavzoc.fsf@stupidchicken.com> <48A1DC88.3080606@gmail.com> <87myjiukeh.fsf@stupidchicken.com> <48A1DF36.8000409@gmail.com> <87bpzyujxy.fsf@stupidchicken.com> <48A1E0C7.2010704@gmail.com> <87tzdqcadt.fsf@stupidchicken.com> <48A38328.3080608@f2s.com> <87k5eko19b.fsf@stupidchicken.com> <48A38AA8.8010000@f2s.com> In-Reply-To: <48A38AA8.8010000@f2s.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Jason Rumney wrote: > Chong Yidong wrote: >> I see. Can you verify that Lennart's patch works on W32? >> > > Lennart's patch works, but it might be better to make wheel events on > W32 set the appropriate click, double or triple modifier so that it is > caught by the conditions that follow. I have changed the code to make wheel events appear as click events (double and triple wheel events were already handled correctly). I am still confused about all the steps an event goes through to become a Lisp event, as the click modifier was being set on the wheel events, but wasn't returned by event-modifiers, which seems to ignore the modifiers and just use the base name of the event to regenerate them. Are the modifiers we set in C code that untrustworthy? ------------=_1230995404-21313-0--