bug#647: 23.0.60; NSInteger changes in nsterm.h break the GNUstep build

bug#647: 23.0.60; NSInteger changes in nsterm.h break the GNUstep build

[Yavor Doganov]

This change

2008-08-01  Adrian Robert  <Adrian.B.Robert@gmail.com>

        * nsterm.h (NSInteger, NSUInteger): Add defines for non-Leopard.


breaks the GNUstep build with GNUstep Base 1.16.1 on GNU/Linux:

In file included from nsterm.m:37:
nsterm.h:368: error: conflicting types for ‘NSInteger’
/usr/include/GNUstep/Foundation/NSObjCRuntime.h:40: error: previous declaration of ‘NSInteger’ was here
nsterm.h:369: error: conflicting types for ‘NSUInteger’
/usr/include/GNUstep/Foundation/NSObjCRuntime.h:41: error: previous declaration of ‘NSUInteger’ was here

,---- <Foundation/NSObjCRuntime.h> ----
| typedef gsaddr  NSInteger;
| typedef gsuaddr NSUInteger;
`--------------------------------------

Also,

2008-08-01  Chong Yidong  <cyd@stupidchicken.com>

        * nsterm.m (EmacsApp -application:openFiles:): GNUStep does not
        define NSApplicationDelegateReplySuccess.
        (EmacsView -converstationIdentifier): Use long instead of
        NSInteger for GNUStep, since it doesn't have NSInteger.
		      	       	     	^^^^^^^^^^^^^^^^^^^^^^

is not true as of Base 1.15.3 (unstable) and 1.16.0 (stable, released
on 15th Jun 2008):

2008-02-25  Richard Frith-Macdonald <rfm@gnu.org>

        * Headers/Foundation/NSObjCRuntime.h: Added NSInteger and NSUInteger
        for MacOSX compatibiulity.

bug#647: marked as done (23.0.60; NSInteger changes in nsterm.h break the GNUstep build)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 836 bytes --]


Your message dated Mon, 11 Aug 2008 01:05:25 +0300
with message-id <87vdy88r16.GNU's_Not_Unix!%yavor@gnu.org>
and subject line Fixed
has caused the Emacs bug report #647,
regarding 23.0.60; NSInteger changes in nsterm.h break the GNUstep build
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
647: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=647
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3898 bytes --]

From: Yavor Doganov <yavor@gnu.org>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.60; NSInteger changes in nsterm.h break the GNUstep build
Date: Mon, 04 Aug 2008 17:24:28 +0300
Message-ID: <874p60g8o3.GNU's_Not_Unix!%yavor@gnu.org>

This change

2008-08-01  Adrian Robert  <Adrian.B.Robert@gmail.com>

        * nsterm.h (NSInteger, NSUInteger): Add defines for non-Leopard.


breaks the GNUstep build with GNUstep Base 1.16.1 on GNU/Linux:

In file included from nsterm.m:37:
nsterm.h:368: error: conflicting types for ‘NSInteger’
/usr/include/GNUstep/Foundation/NSObjCRuntime.h:40: error: previous declaration of ‘NSInteger’ was here
nsterm.h:369: error: conflicting types for ‘NSUInteger’
/usr/include/GNUstep/Foundation/NSObjCRuntime.h:41: error: previous declaration of ‘NSUInteger’ was here

,---- <Foundation/NSObjCRuntime.h> ----
| typedef gsaddr  NSInteger;
| typedef gsuaddr NSUInteger;
`--------------------------------------

Also,

2008-08-01  Chong Yidong  <cyd@stupidchicken.com>

        * nsterm.m (EmacsApp -application:openFiles:): GNUStep does not
        define NSApplicationDelegateReplySuccess.
        (EmacsView -converstationIdentifier): Use long instead of
        NSInteger for GNUStep, since it doesn't have NSInteger.
		      	       	     	^^^^^^^^^^^^^^^^^^^^^^

is not true as of Base 1.15.3 (unstable) and 1.16.0 (stable, released
on 15th Jun 2008):

2008-02-25  Richard Frith-Macdonald <rfm@gnu.org>

        * Headers/Foundation/NSObjCRuntime.h: Added NSInteger and NSUInteger
        for MacOSX compatibiulity.



[-- Attachment #3: Type: message/rfc822, Size: 1820 bytes --]

From: Yavor Doganov <yavor@gnu.org>
To: 647-done@emacsbugs.donarmstrong.com
Subject: Fixed
Date: Mon, 11 Aug 2008 01:05:25 +0300
Message-ID: <87vdy88r16.GNU's_Not_Unix!%yavor@gnu.org>

This bug was fixed by Chong Yidong; closing.