bug#598: 23.0.60; frame size issue (--geometry or default-frame-alist) when using customized default face

bug#598: 23.0.60; frame size issue (--geometry or default-frame-alist) when using customized default face

[Tim Van Holder]

For a few weeks now (starting around the time of the fix for #47, which
may or may not be relevant), emacs no longer comes up with the correct
frame size.
I have it set (to 132x60) in default-frame-alist, but emacs end up with
varying frame sizes instead - while there seem to be a few that it
favors, I can't see any real pattern in it.
The same happens if I remove the width/height settings from
default-frame-alist and use --geometry instead.
"emacs -Q --geometry 132x60" does seem to work 100% of the time.

I tried erasing the font/foundry customization, but that made no
difference; changing the font height, however, did. Emacs seems to
default to a height of 116 while I have mine set to 135 (since with the
font I prefer to use (Terminus), 116 is too small to read comfortably).

So it looks like the frame size is being computed based on the wrong
font sizing.

A few things I noticed while testing this:
- customizing the size of the default font causes emacs to repain its
  frame, and quite often this messes up the scrollbars (which I have
  set to appear on the right). Sometimes there is a black border to
  their right, sometimes they disappear. In either case, manually
  sizing the frame makes them redraw in their correct place.
- after saving the default face with the font and foundry items
  unchecked (i.e. uncustomized), and restarting emacs, it shows the
  font and foundry as customized (using Bitstream Vera Sans Mono)
- the 'foundry' setting was also added fairly recently; how do I find
  out a font's foundry so that I can set it correctly when customizing
  a face? Is there perhaps a font picker available in emacs that would
  allow me to customize a face more effectively?

bug#598: marked as done (23.0.60; frame size issue (--geometry or default-frame-alist) when using customized default face)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 951 bytes --]


Your message dated Mon, 06 Oct 2008 12:27:07 -0400
with message-id <87k5clg04k.fsf@cyd.mit.edu>
and subject line Re: 23.0.60; frame size issue (--geometry or default-frame-alist) when using customized default face
has caused the Emacs bug report #598,
regarding 23.0.60; frame size issue (--geometry or default-frame-alist) when using customized default face
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
598: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=598
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 4111 bytes --]

From: Tim Van Holder <tim.vanholder@gmail.com>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.60; frame size issue (--geometry or default-frame-alist) when using customized default face
Date: Wed, 23 Jul 2008 10:18:02 +0200
Message-ID: <87k5fdvwsl.fsf@leeloo.anubex.internal>


For a few weeks now (starting around the time of the fix for #47, which
may or may not be relevant), emacs no longer comes up with the correct
frame size.
I have it set (to 132x60) in default-frame-alist, but emacs end up with
varying frame sizes instead - while there seem to be a few that it
favors, I can't see any real pattern in it.
The same happens if I remove the width/height settings from
default-frame-alist and use --geometry instead.
"emacs -Q --geometry 132x60" does seem to work 100% of the time.

I tried erasing the font/foundry customization, but that made no
difference; changing the font height, however, did. Emacs seems to
default to a height of 116 while I have mine set to 135 (since with the
font I prefer to use (Terminus), 116 is too small to read comfortably).

So it looks like the frame size is being computed based on the wrong
font sizing.

A few things I noticed while testing this:
- customizing the size of the default font causes emacs to repain its
  frame, and quite often this messes up the scrollbars (which I have
  set to appear on the right). Sometimes there is a black border to
  their right, sometimes they disappear. In either case, manually
  sizing the frame makes them redraw in their correct place.
- after saving the default face with the font and foundry items
  unchecked (i.e. uncustomized), and restarting emacs, it shows the
  font and foundry as customized (using Bitstream Vera Sans Mono)
- the 'foundry' setting was also added fairly recently; how do I find
  out a font's foundry so that I can set it correctly when customizing
  a face? Is there perhaps a font picker available in emacs that would
  allow me to customize a face more effectively?



[-- Attachment #3: Type: message/rfc822, Size: 1059 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Tim Van Holder <tim.vanholder@gmail.com>
Cc: 598-done@emacsbugs.donarmstrong.com
Subject: Re: 23.0.60; frame size issue (--geometry or default-frame-alist) when using customized default face
Date: Mon, 06 Oct 2008 12:27:07 -0400
Message-ID: <87k5clg04k.fsf@cyd.mit.edu>

I've checked in a fix that should solve this problem.

bug#598: 23.0.60; frame size issue (--geometry or default-frame-alist) when using customized default face

[Tim Van Holder]

On Mon, Oct 6, 2008 at 6:27 PM, Chong Yidong <cyd@stupidchicken.com> wrote:
> I've checked in a fix that should solve this problem.

Unfortunately, even after a maintainer-clean + make bootstrap, the issue is not
resolved for me.  In fact, the very first run of the new emacs
resulted in a frame that
was 168x61 instead of 132x57 (is that 132x60->132x57 as a result of
menu/toolbars
considered a bug or a feature?).

bug#598: 23.0.60; frame size issue (--geometry or default-frame-alist) when using customized default face

[martin rudalics]

 > Unfortunately, even after a maintainer-clean + make bootstrap, the issue is not
 > resolved for me.  In fact, the very first run of the new emacs
 > resulted in a frame that
 > was 168x61 instead of 132x57 (is that 132x60->132x57 as a result of
 > menu/toolbars
 > considered a bug or a feature?).

Could you try commenting out the code below from x_figure_window_size in
frame.c and tell whether and how the behavior changes?

   if (toolbar_p && FRAME_TOOL_BAR_LINES (f))
     {
       int margin, relief, bar_height;

       relief = (tool_bar_button_relief >= 0
		? tool_bar_button_relief
		: DEFAULT_TOOL_BAR_BUTTON_RELIEF);

       if (INTEGERP (Vtool_bar_button_margin)
	  && XINT (Vtool_bar_button_margin) > 0)
	margin = XFASTINT (Vtool_bar_button_margin);
       else if (CONSP (Vtool_bar_button_margin)
	       && INTEGERP (XCDR (Vtool_bar_button_margin))
	       && XINT (XCDR (Vtool_bar_button_margin)) > 0)
	margin = XFASTINT (XCDR (Vtool_bar_button_margin));
       else
	margin = 0;

       bar_height = DEFAULT_TOOL_BAR_IMAGE_HEIGHT + 2 * margin + 2 * relief;
       FRAME_LINES (f) += (bar_height + FRAME_LINE_HEIGHT (f) - 1) / FRAME_LINE_HEIGHT (f);
     }

martin

bug#598: 23.0.60; frame size issue (--geometry or default-frame-alist) when using customized default face

[Tim Van Holder]

On Tue, Oct 7, 2008 at 2:09 PM, martin rudalics <rudalics@gmx.at> wrote:
>> Unfortunately, even after a maintainer-clean + make bootstrap, the issue
>> is not
>> resolved for me.  In fact, the very first run of the new emacs
>> resulted in a frame that
>> was 168x61 instead of 132x57 (is that 132x60->132x57 as a result of
>> menu/toolbars
>> considered a bug or a feature?).
>
> Could you try commenting out the code below from x_figure_window_size
> in frame.c and tell whether and how the behavior changes?
>
>  [code snipped]

No behavior change - I get frames of 132x57 and 168x61.
Some printf()s added in that function show that the block is indeed
never entered - perhaps it is called before the info is set from one
of the frame alists?
In fact, even if I force FRAME_TOOLBAR_LINES(f) to 1 before that if,
I get:

[x_figure_window_size] before toolbar check [yes/1]
[x_figure_window_size] block entered
[x_figure_window_size] relief = 1
[x_figure_window_size] margin = 4
[x_figure_window_size] bar_height = 34
[x_figure_window_size] FRAME_LINES (before) = 40
[x_figure_window_size] FRAME_LINES (afte4r) = 43

and the frame still ends up at 132x57.

bug#598: 23.0.60; frame size issue (--geometry or default-frame-alist) when using customized default face

[Chong Yidong]

"Tim Van Holder" <tim.vanholder@gmail.com> writes:

> Unfortunately, even after a maintainer-clean + make bootstrap, the
> issue is not resolved for me.  In fact, the very first run of the new
> emacs resulted in a frame that was 168x61 instead of 132x57 (is that
> 132x60->132x57 as a result of menu/toolbars considered a bug or a
> feature?).

What window manager are you using?

Also, does the following change (which disables window manager size
hints) have any effect?

*** trunk/src/gtkutil.c.~1.140.~	2008-10-07 13:44:01.000000000 -0400
--- trunk/src/gtkutil.c	2008-10-08 18:46:33.000000000 -0400
***************
*** 925,930 ****
--- 925,932 ----
       long flags;
       int user_position;
  {
+   return;
+ 
    /* Don't set size hints during initialization; that apparently leads
       to a race condition.  See the thread at
       http://lists.gnu.org/archive/html/emacs-devel/2008-10/msg00033.html  */

bug#598: 23.0.60; frame size issue (--geometry or default-frame-alist) when using customized default face

[Tim Van Holder]

2008/10/9 Chong Yidong <cyd@stupidchicken.com>:
> "Tim Van Holder" <tim.vanholder@gmail.com> writes:
>
>> Unfortunately, even after a maintainer-clean + make bootstrap, the
>> issue is not resolved for me.  In fact, the very first run of the new
>> emacs resulted in a frame that was 168x61 instead of 132x57 (is that
>> 132x60->132x57 as a result of menu/toolbars considered a bug or a
>> feature?).
>
> What window manager are you using?

metacity (2.14.5)

> Also, does the following change (which disables window manager size
> hints) have any effect?

Yes.
Effects seen:
- there seems to be a little less resizing during startup
- no popup with the frame size when grabbing the border to resize
- resizing doesn't "snap" to character size (so when resizing it's possibly
  to get small black borders below the minibuffer and next to the scrollbar
- starts up with a 132x60 frame (checked by comparing with a frame from
  yesterday's build); after 20 runs it still hasn't shown a different size