From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: don@donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#577: marked as done (23.0.60; editing image files in non-X frames) Date: Wed, 30 Jul 2008 06:45:04 -0700 Message-ID: References: <87iqun8pgo.fsf@stupidchicken.com> <20080719113938.E934599A0AF@mt-computer.local> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1217425504-16128-0" X-Trace: ger.gmane.org 1217425682 15991 80.91.229.12 (30 Jul 2008 13:48:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 30 Jul 2008 13:48:02 +0000 (UTC) To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 30 15:48:44 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KOC2X-0001nw-NF for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Jul 2008 15:48:30 +0200 Original-Received: from localhost ([127.0.0.1]:46249 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KOC1d-0000Ak-8y for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Jul 2008 09:47:33 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KOC1V-0000AD-Rl for bug-gnu-emacs@gnu.org; Wed, 30 Jul 2008 09:47:25 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KOC1V-00009t-Ba for bug-gnu-emacs@gnu.org; Wed, 30 Jul 2008 09:47:25 -0400 Original-Received: from [199.232.76.173] (port=36466 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KOC1V-00009q-58 for bug-gnu-emacs@gnu.org; Wed, 30 Jul 2008 09:47:25 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:44624) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KOC1U-0000jI-KF for bug-gnu-emacs@gnu.org; Wed, 30 Jul 2008 09:47:24 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m6UDlK4g017295; Wed, 30 Jul 2008 06:47:22 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m6UDj4Tn016239; Wed, 30 Jul 2008 06:45:04 -0700 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: don@donarmstrong.com X-Emacs-PR-Message: closed 577 X-Emacs-PR-Package: emacs X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:18923 Archived-At: This is a multi-part message in MIME format... ------------=_1217425504-16128-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Wed, 30 Jul 2008 09:35:19 -0400 with message-id <87iqun8pgo.fsf@stupidchicken.com> and subject line Re: 23.0.60; editing image files in non-X frames has caused the Emacs bug report #577, regarding 23.0.60; editing image files in non-X frames to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact don@donarmstrong.com immediately.) --=20 577: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D577 Emacs Bug Tracking System Contact don@donarmstrong.com with problems ------------=_1217425504-16128-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-5.6 required=4.0 tests=AWL,BAYES_00,IMPRONONCABLE_2, MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 19 Jul 2008 11:40:14 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m6JBe7k6010044 for ; Sat, 19 Jul 2008 04:40:08 -0700 Received: from mail.gnu.org ([199.232.76.166]:43027 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KKAmd-0003oM-VR for emacs-pretest-bug@gnu.org; Sat, 19 Jul 2008 07:39:28 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KKAnD-00035z-6b for emacs-pretest-bug@gnu.org; Sat, 19 Jul 2008 07:40:06 -0400 Received: from mail.gmx.net ([213.165.64.20]:33151) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1KKAnC-00035N-Mv for emacs-pretest-bug@gnu.org; Sat, 19 Jul 2008 07:40:03 -0400 Received: (qmail invoked by alias); 19 Jul 2008 11:40:00 -0000 Received: from chello062178240212.3.14.tuwien.teleweb.at (EHLO mt-computer.local) [62.178.240.212] by mail.gmx.net (mp011) with SMTP; 19 Jul 2008 13:40:00 +0200 X-Authenticated: #4064391 X-Provags-ID: V01U2FsdGVkX1+/meMMr8e/EZ6SC/tLIrqIJwuJ1PKhnMdwzsJ3Wj oE7NczW9fz3iQZ Received: by mt-computer.local (Postfix, from userid 502) id E934599A0AF; Sat, 19 Jul 2008 13:39:38 +0200 (CEST) From: Markus Triska To: emacs-pretest-bug@gnu.org Subject: 23.0.60; editing image files in non-X frames Message-Id: <20080719113938.E934599A0AF@mt-computer.local> Date: Sat, 19 Jul 2008 13:39:38 +0200 (CEST) X-Y-GMX-Trusted: 0 X-FuHaFi: 0.57 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) When I do "emacs -Q -nw sample.png", I cannot use C-n etc. on the image data. The following patch fixes this. 2008-07-19 Markus Triska * image-mode.el (image-mode): Set image-mode-text-map when image cannot be displayed. diff --git a/lisp/image-mode.el b/lisp/image-mode.el index 5ffbfe1..fb2eaf1 100644 --- a/lisp/image-mode.el +++ b/lisp/image-mode.el @@ -333,13 +333,14 @@ to toggle between display as an image and display as text." (image-mode-setup-winprops) (add-hook 'change-major-mode-hook 'image-toggle-display-text nil t) - (if (and (display-images-p) - (not (image-get-display-property))) - (image-toggle-display) - ;; Set next vars when image is already displayed but local - ;; variables were cleared by kill-all-local-variables - (use-local-map image-mode-map) - (setq cursor-type nil truncate-lines t)) + (if (display-images-p) + (if (not (image-get-display-property)) + (image-toggle-display) + ;; Set next vars when image is already displayed but local + ;; variables were cleared by kill-all-local-variables + (use-local-map image-mode-map) + (setq cursor-type nil truncate-lines t)) + (use-local-map image-mode-text-map)) (run-mode-hooks 'image-mode-hook) (if (display-images-p) (message "%s" (concat ------------=_1217425504-16128-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-2.2 required=4.0 tests=AWL,BAYES_00, MURPHY_DRUGS_REL8,RCVD_IN_PBL,RCVD_IN_SORBS_DUL,RDNS_DYNAMIC autolearn=no version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 577-done) by emacsbugs.donarmstrong.com; 30 Jul 2008 13:35:28 +0000 Received: from furry (c-24-63-201-57.hsd1.ma.comcast.net [24.63.201.57]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m6UDZOT8014706 for <577-done@emacsbugs.donarmstrong.com>; Wed, 30 Jul 2008 06:35:26 -0700 Received: by furry (Postfix, from userid 1000) id A0413C054; Wed, 30 Jul 2008 09:35:19 -0400 (EDT) From: Chong Yidong To: Markus Triska Cc: 577-done@emacsbugs.donarmstrong.com Subject: Re: 23.0.60; editing image files in non-X frames Date: Wed, 30 Jul 2008 09:35:19 -0400 Message-ID: <87iqun8pgo.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > When I do "emacs -Q -nw sample.png", I cannot use C-n etc. on the > image data. The following patch fixes this. Checked in. Thanks. ------------=_1217425504-16128-0--