From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: don@donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#553: marked as done (23.0.60; Unknown button type `quail-keyboard-layout-button') Date: Fri, 5 Sep 2008 15:20:03 -0700 Message-ID: References: <871vzyjl39.fsf@cyd.mit.edu> <87d4likbd1.fsf@jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1220653203-31261-0" X-Trace: ger.gmane.org 1220653702 25419 80.91.229.12 (5 Sep 2008 22:28:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 5 Sep 2008 22:28:22 +0000 (UTC) To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 06 00:29:17 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KbjnQ-0001Hr-5M for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Sep 2008 00:28:52 +0200 Original-Received: from localhost ([127.0.0.1]:57491 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KbjmQ-0006vG-8a for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Sep 2008 18:27:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KbjmC-0006n8-42 for bug-gnu-emacs@gnu.org; Fri, 05 Sep 2008 18:27:36 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KbjmA-0006mG-Jw for bug-gnu-emacs@gnu.org; Fri, 05 Sep 2008 18:27:34 -0400 Original-Received: from [199.232.76.173] (port=35376 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KbjmA-0006mC-BE for bug-gnu-emacs@gnu.org; Fri, 05 Sep 2008 18:27:34 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:48646) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KbjmA-0003mI-Bf for bug-gnu-emacs@gnu.org; Fri, 05 Sep 2008 18:27:34 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m85MRViM001845; Fri, 5 Sep 2008 15:27:32 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m85MK3sx031282; Fri, 5 Sep 2008 15:20:03 -0700 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: don@donarmstrong.com X-Emacs-PR-Message: closed 553 X-Emacs-PR-Package: emacs X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:20214 Archived-At: This is a multi-part message in MIME format... ------------=_1220653203-31261-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Fri, 05 Sep 2008 18:15:22 -0400 with message-id <871vzyjl39.fsf@cyd.mit.edu> and subject line Re: 23.0.60; Unknown button type `quail-keyboard-layout-bu= tton' has caused the Emacs bug report #553, regarding 23.0.60; Unknown button type `quail-keyboard-layout-button' to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact don@donarmstrong.com immediately.) --=20 553: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D553 Emacs Bug Tracking System Contact don@donarmstrong.com with problems ------------=_1220653203-31261-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.1 required=4.0 tests=AWL,BAYES_00, RCVD_IN_DNSWL_MED,SUBJECT_FUZZY_TION autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 12 Jul 2008 22:05:44 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m6CM5ZG9013045 for ; Sat, 12 Jul 2008 15:05:36 -0700 Received: from mx10.gnu.org ([199.232.76.166]:38362) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KHnDE-0002Ak-Vi for emacs-pretest-bug@gnu.org; Sat, 12 Jul 2008 18:05:05 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KHnDf-0002Tr-9E for emacs-pretest-bug@gnu.org; Sat, 12 Jul 2008 18:05:34 -0400 Received: from relay03.kiev.sovam.com ([62.64.120.201]:57026) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KHnDe-0002Tj-Pz for emacs-pretest-bug@gnu.org; Sat, 12 Jul 2008 18:05:31 -0400 Received: from [83.170.232.243] (helo=smtp.svitonline.com) by relay03.kiev.sovam.com with esmtp (Exim 4.67) (envelope-from ) id 1KHnDd-000Ozo-3J for emacs-pretest-bug@gnu.org; Sun, 13 Jul 2008 01:05:29 +0300 From: Juri Linkov To: emacs-pretest-bug@gnu.org Subject: 23.0.60; Unknown button type `quail-keyboard-layout-button' Organization: JURTA Date: Sun, 13 Jul 2008 01:04:42 +0300 Message-ID: <87d4likbd1.fsf@jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Scanner-Signature: 8fcfa5a562f326ba64a474cd1db6e25e X-DrWeb-checked: yes X-SpamTest-Envelope-From: juri@jurta.org X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Trusted X-SpamTest-Info: Profiles 4292 [July 12 2008] X-SpamTest-Info: {received from trusted relay: common white list} X-SpamTest-Info: {HEADERS: header Content-Type found without required header Content-Transfer-Encoding} X-SpamTest-Method: white ip list X-SpamTest-Rate: 10 X-SpamTest-Status: Trusted X-SpamTest-Status-Extended: trusted X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0278], KAS30/Release X-detected-kernel: by monty-python.gnu.org: FreeBSD 6.x (1) 1. `emacs -Q' 2. `M-: (require 'help-mode) RET' or run any Help command that loads this mode 3. Activate an input method by C-\ 4. Click `mouse-3' on the input method's indicator on the mode-line It fills the *Help* buffer with the text only until it tries to create a button, and fails with the error "make-text-button: Unknown button type `quail-keyboard-layout-button'". This is because `quail-help-init' fails to define new button types. It currently has the form: (defun quail-help-init () (unless (featurep 'help-mode) (require 'help-mode) (define-button-type 'quail-keyboard-layout-button :supertype 'help-xref 'help-function '(lambda (layout) (help-setup-xref `(quail-keyboard-layout-button ,layout) nil) (quail-show-keyboard-layout layout)) 'help-echo (purecopy "mouse-2, RET: show keyboard layout")) (define-button-type 'quail-keyboard-customize-button :supertype 'help-customize-variable 'help-echo (purecopy "mouse-2, RET: customize keyboard layout")))) So it doesn't define two button types if `help-mode' is already loaded. I guess it was done to define them only once, and not redefine on next invocations. Instead of checking for (featurep 'help-mode) it could check if these buttons were already defined. I can't find a function like `button-defined-p' to do this. But the following check seems to work: (get 'quail-keyboard-layout-button 'button-category-symbol) -- Juri Linkov http://www.jurta.org/emacs/ ------------=_1220653203-31261-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-3.7 required=4.0 tests=AWL,BAYES_00, SUBJECT_FUZZY_TION autolearn=no version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 553-done) by emacsbugs.donarmstrong.com; 5 Sep 2008 22:12:47 +0000 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m85MCiuK029318 for <553-done@emacsbugs.donarmstrong.com>; Fri, 5 Sep 2008 15:12:45 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id D5FD257E18A; Fri, 5 Sep 2008 18:15:22 -0400 (EDT) From: Chong Yidong To: Juri Linkov Cc: 553-done@emacsbugs.donarmstrong.com Subject: Re: 23.0.60; Unknown button type `quail-keyboard-layout-button' Date: Fri, 05 Sep 2008 18:15:22 -0400 Message-ID: <871vzyjl39.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > I don't know the reason of writing quail-help-init this way, but it > seems it was to not load `help-mode' after loading `quail.el'. > `help-mode' is not necessary for quail's operations, so its loading > should be postponed for rare cases when the user needs to see the help > buffer with keyboard layouts. I don't think it's a big deal to just load help-mode, so I changed quail.el to do that. ------------=_1220653203-31261-0--