From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: bug-gnu-emacs@gnu.org (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#5211: marked as done (Color escape codes in the output of vc-git-print-log) Date: Mon, 28 Dec 2009 02:49:02 +0000 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1261968542-16339-0" X-Trace: ger.gmane.org 1261969700 9812 80.91.229.12 (28 Dec 2009 03:08:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Dec 2009 03:08:20 +0000 (UTC) Cc: emacs-bug-tracker@debbugs.gnu.org To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 28 04:08:12 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NP5xr-0006mN-Mu for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Dec 2009 04:08:12 +0100 Original-Received: from localhost ([127.0.0.1]:44663 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NP5xr-0007xA-VI for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Dec 2009 22:08:11 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NP5xm-0007ww-SR for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2009 22:08:06 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NP5xd-0007vL-1f for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2009 22:08:06 -0500 Original-Received: from [199.232.76.173] (port=32811 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NP5xT-0007uQ-1A; Sun, 27 Dec 2009 22:07:47 -0500 Original-Received: from [140.186.70.43] (port=59100 helo=debbugs.gnu.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NP5xS-00055s-QN; Sun, 27 Dec 2009 22:07:46 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NP5fK-0004FZ-28; Sun, 27 Dec 2009 21:49:02 -0500 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: closed 5211 X-Emacs-PR-Package: emacs,vc X-Emacs-PR-Keywords: patch X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:33789 Archived-At: This is a multi-part message in MIME format... ------------=_1261968542-16339-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Mon, 28 Dec 2009 03:47:52 +0100 with message-id and subject line Re: bug#5211: Color escape codes in the output of vc-git-p= rint-log has caused the Emacs bug report #5211, regarding Color escape codes in the output of vc-git-print-log to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact bug-gnu-emacs@gnu.org immediately.) --=20 5211: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D5211 Emacs Bug Tracking System Contact bug-gnu-emacs@gnu.org with problems ------------=_1261968542-16339-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 14 Dec 2009 16:14:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.9 required=4.0 tests=AWL,GMAIL,HAS_PACKAGE, IMPRONONCABLE_2,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nBEGE3VO003306 for ; Mon, 14 Dec 2009 08:14:04 -0800 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NKDYe-0007ew-Tf for bug-gnu-emacs@gnu.org; Mon, 14 Dec 2009 11:14:01 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NKDYW-0007dQ-Vk for bug-gnu-emacs@gnu.org; Mon, 14 Dec 2009 11:13:57 -0500 Received: from [199.232.76.173] (port=52002 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NKDYV-0007dB-1t for bug-gnu-emacs@gnu.org; Mon, 14 Dec 2009 11:13:51 -0500 Received: from mail-bw0-f215.google.com ([209.85.218.215]:37628) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NKDYU-0000Ss-PR for bug-gnu-emacs@gnu.org; Mon, 14 Dec 2009 11:13:50 -0500 Received: by bwz7 with SMTP id 7so2262901bwz.26 for ; Mon, 14 Dec 2009 08:13:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:from:date:message-id :subject:to:content-type; bh=c/LStbBJxx8vX6VGzxnP+l3kD+R53fJxepihqgX/UuM=; b=pYqzqAaAHxZzWzBfsAzg8UBtZaZ//ZPa9kdBENl7RX+Imr2VDXhx2/wxQCjEn6q9iU BBYV8sawKJ+a7fq9KnJ0dDwrPHk8nQ4ofo7tvv6/4F7FZXYBQOvEHaft7/aZBYB83Yqh qXGK/HMMtJtqgeDMeld+2IsWvvJtjPyd3P84o= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=I5Z1ETs2UaOsw6kRt/mYQQGTls3rX6R3deptP4S3G7q5ym9z4kO5f/YOim+z/ggSmT ZApFqFgq0GEX+B6Q/Cl1Tr6EDz2QcotndHc2XoadDtQAvFdap/jFkCoYx7SAdMWjQM99 ycxaKmsZZKmCGhfD3MOnVXNQBanr4M+Im/tFs= MIME-Version: 1.0 Received: by 10.204.153.220 with SMTP id l28mr2921996bkw.86.1260807229688; Mon, 14 Dec 2009 08:13:49 -0800 (PST) From: Juanma Barranquero Date: Mon, 14 Dec 2009 17:12:24 +0100 Message-ID: Subject: Color escape codes in the output of vc-git-print-log To: Bug-Gnu-Emacs Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Package: emacs,vc Tags: patch Version: 23.1.90 Severity: minor Depending of your setting of color.diff, color is used for log output, and vc-print-log shows garbage (OK, escape codes for color): ^[[33mcommit 43a3bf88e5e495ad048b3a6d3cf852e1e7a02f1c^[[m Author: xxx Date: 2009-12-14 17:11:35 +0200 blah blah blah As color in *vc-change-log* buffers is an issue for font-locking, and not for git log, the command should be called with --no-color. OK to the following patch? Juanma 2009-12-14 Juanma Barranquero * vc-git.el (vc-git-print-log): Pass --no-color to `git log'. === modified file 'lisp/vc-git.el' --- lisp/vc-git.el 2009-12-08 15:56:57 +0000 +++ lisp/vc-git.el 2009-12-14 16:08:54 +0000 @@ -555,7 +555,7 @@ (apply 'vc-git-command buffer 'async files (append - '("log") + '("log" "--no-color") (when shortlog '("--graph" "--decorate" "--date=short" "--pretty=format:%d%h %ad %s" "--abbrev-commit")) ------------=_1261968542-16339-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 5211-done) by debbugs.gnu.org; 28 Dec 2009 02:48:19 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NP5ec-0004FJ-LK for submit@debbugs.gnu.org; Sun, 27 Dec 2009 21:48:18 -0500 Received: from mail-bw0-f216.google.com ([209.85.218.216]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NP5eb-0004FD-59 for 5211-done@debbugs.gnu.org; Sun, 27 Dec 2009 21:48:17 -0500 Received: by bwz8 with SMTP id 8so6580981bwz.39 for <5211-done@debbugs.gnu.org>; Sun, 27 Dec 2009 18:48:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=VHo5TXZl0OP8nyV0TbuNYQ7A+PlYO4dxDgPX629SuWo=; b=M4w0ajAKOh8Kl370HRc5Bfp834R7OKpJ5377juQutnUPO613dVTn35uFb26zQRT1p5 dCEUnZ5wyxeBwcMZ4UWdlLhAXOgX6l52/4DHznnLASwcKhV2Wedjzgjq1aGz6lD7Ajg8 dnSd+lJAlQPnbaDVpvRRm4eDiBr8E2F5afhK4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=V29P/bnKiK1XUhj5w5abbuTONT+9OcYvU80XzU9tFitoMAC0sni0vfuNaSEOy0scZf Ok8Piw0EciGthQI48ql/Mp6EDRkRla8pmofEMfNI+xa7QtliAK1wm3r2f1Iwx6bvUs/n RFjjsIkvHRwExCTbgHD+96tfOuM829imwfQDk= MIME-Version: 1.0 Received: by 10.204.33.139 with SMTP id h11mr403725bkd.149.1261968492812; Sun, 27 Dec 2009 18:48:12 -0800 (PST) In-Reply-To: References: <200912151457.nBFEvUT3007406@godzilla.ics.uci.edu> From: Juanma Barranquero Date: Mon, 28 Dec 2009 03:47:52 +0100 Message-ID: Subject: Re: bug#5211: Color escape codes in the output of vc-git-print-log To: Andreas Schwab Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 5211-done Cc: 5211-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.4 (-) On Wed, Dec 16, 2009 at 00:57, Juanma Barranquero wrote: > So --no-color was first included in a release of 2006-08-13. Is that > old enough? (git 1.0.0 is from 2005-12-21, barely eight months > earlier, so 1.4.2 is quite old indeed). I've committed this change (with the acquiescence of Chong Yidong). Juanma ------------=_1261968542-16339-0--