From: bug-gnu-emacs@gnu.org (Emacs bug Tracking System)
To: Juanma Barranquero <lekktu@gmail.com>
Cc: emacs-bug-tracker@debbugs.gnu.org
Subject: bug#5211: marked as done (Color escape codes in the output of vc-git-print-log)
Date: Mon, 28 Dec 2009 02:49:02 +0000 [thread overview]
Message-ID: <handler.5211.D5211.126196849916328.ackdone@debbugs.gnu.org> (raw)
In-Reply-To: f7ccd24b0912140812jfe0104ek67d91233840138a7@mail.gmail.com
[-- Attachment #1: Type: text/plain, Size: 894 bytes --]
Your message dated Mon, 28 Dec 2009 03:47:52 +0100
with message-id <f7ccd24b0912271847j7f282733y358910002b582b49@mail.gmail.com>
and subject line Re: bug#5211: Color escape codes in the output of vc-git-print-log
has caused the Emacs bug report #5211,
regarding Color escape codes in the output of vc-git-print-log
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact bug-gnu-emacs@gnu.org
immediately.)
--
5211: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5211
Emacs Bug Tracking System
Contact bug-gnu-emacs@gnu.org with problems
[-- Attachment #2: Type: message/rfc822, Size: 3832 bytes --]
From: Juanma Barranquero <lekktu@gmail.com>
To: Bug-Gnu-Emacs <bug-gnu-emacs@gnu.org>
Subject: Color escape codes in the output of vc-git-print-log
Date: Mon, 14 Dec 2009 17:12:24 +0100
Message-ID: <f7ccd24b0912140812jfe0104ek67d91233840138a7@mail.gmail.com>
Package: emacs,vc
Tags: patch
Version: 23.1.90
Severity: minor
Depending of your setting of color.diff, color is used for log output,
and vc-print-log shows garbage (OK, escape codes for color):
^[[33mcommit 43a3bf88e5e495ad048b3a6d3cf852e1e7a02f1c^[[m
Author: xxx <yyy@zzz>
Date: 2009-12-14 17:11:35 +0200
blah blah blah
As color in *vc-change-log* buffers is an issue for font-locking, and
not for git log, the command should be called with --no-color.
OK to the following patch?
Juanma
2009-12-14 Juanma Barranquero <lekktu@gmail.com>
* vc-git.el (vc-git-print-log): Pass --no-color to `git log'.
=== modified file 'lisp/vc-git.el'
--- lisp/vc-git.el 2009-12-08 15:56:57 +0000
+++ lisp/vc-git.el 2009-12-14 16:08:54 +0000
@@ -555,7 +555,7 @@
(apply 'vc-git-command buffer
'async files
(append
- '("log")
+ '("log" "--no-color")
(when shortlog
'("--graph" "--decorate"
"--date=short" "--pretty=format:%d%h %ad %s" "--abbrev-commit"))
[-- Attachment #3: Type: message/rfc822, Size: 3470 bytes --]
From: Juanma Barranquero <lekktu@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: 5211-done@debbugs.gnu.org
Subject: Re: bug#5211: Color escape codes in the output of vc-git-print-log
Date: Mon, 28 Dec 2009 03:47:52 +0100
Message-ID: <f7ccd24b0912271847j7f282733y358910002b582b49@mail.gmail.com>
On Wed, Dec 16, 2009 at 00:57, Juanma Barranquero <lekktu@gmail.com> wrote:
> So --no-color was first included in a release of 2006-08-13. Is that
> old enough? (git 1.0.0 is from 2005-12-21, barely eight months
> earlier, so 1.4.2 is quite old indeed).
I've committed this change (with the acquiescence of Chong Yidong).
Juanma
prev parent reply other threads:[~2009-12-28 2:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f7ccd24b0912271847j7f282733y358910002b582b49@mail.gmail.com>
2009-12-14 16:12 ` bug#5211: Color escape codes in the output of vc-git-print-log Juanma Barranquero
2009-12-15 4:27 ` Stefan Monnier
2009-12-15 4:31 ` Juanma Barranquero
2009-12-15 5:36 ` Eli Zaretskii
2009-12-15 11:15 ` Juanma Barranquero
2009-12-15 13:01 ` Eli Zaretskii
2009-12-15 13:09 ` Juanma Barranquero
2009-12-15 14:57 ` Dan Nicolaescu
2009-12-15 15:42 ` Juanma Barranquero
2009-12-15 18:32 ` Andreas Schwab
2009-12-15 18:36 ` Juanma Barranquero
2009-12-15 23:34 ` Andreas Schwab
2009-12-15 23:57 ` Juanma Barranquero
2009-12-28 2:49 ` Emacs bug Tracking System [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=handler.5211.D5211.126196849916328.ackdone@debbugs.gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=emacs-bug-tracker@debbugs.gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.