From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: bug-gnu-emacs@gnu.org (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#5148: marked as done (Lossage in comint history) Date: Fri, 01 Jan 2010 18:46:02 +0000 Message-ID: References: <87y6kh8y0j.fsf@stupidchicken.com> <87iqcjeq45.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1262371562-29378-0" X-Trace: ger.gmane.org 1262371798 8123 80.91.229.12 (1 Jan 2010 18:49:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 1 Jan 2010 18:49:58 +0000 (UTC) Cc: emacs-bug-tracker@debbugs.gnu.org To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 01 19:49:51 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NQmZH-0002Sg-Eq for geb-bug-gnu-emacs@m.gmane.org; Fri, 01 Jan 2010 19:49:47 +0100 Original-Received: from localhost ([127.0.0.1]:51042 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NQmZH-0007f5-Tn for geb-bug-gnu-emacs@m.gmane.org; Fri, 01 Jan 2010 13:49:47 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NQmZ0-0007Th-Rv for bug-gnu-emacs@gnu.org; Fri, 01 Jan 2010 13:49:30 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NQmYu-0007Ot-8m for bug-gnu-emacs@gnu.org; Fri, 01 Jan 2010 13:49:29 -0500 Original-Received: from [199.232.76.173] (port=38333 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NQmYj-0007Ht-QS; Fri, 01 Jan 2010 13:49:13 -0500 Original-Received: from [140.186.70.43] (port=50443 helo=debbugs.gnu.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NQmYj-000557-E8; Fri, 01 Jan 2010 13:49:13 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NQmVe-0007ds-BO; Fri, 01 Jan 2010 13:46:02 -0500 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: closed 5148 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:33829 Archived-At: This is a multi-part message in MIME format... ------------=_1262371562-29378-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Fri, 01 Jan 2010 13:45:32 -0500 with message-id <87y6kh8y0j.fsf@stupidchicken.com> and subject line Re: Lossage in comint history has caused the Emacs bug report #5148, regarding Lossage in comint history to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact bug-gnu-emacs@gnu.org immediately.) --=20 5148: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D5148 Emacs Bug Tracking System Contact bug-gnu-emacs@gnu.org with problems ------------=_1262371562-29378-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 7 Dec 2009 17:33:01 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.2 required=4.0 tests=AWL,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nB7HWxEH022069 for ; Mon, 7 Dec 2009 09:33:00 -0800 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NHhSE-0004DU-SC for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2009 12:32:58 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NHhS9-00046g-BT for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2009 12:32:57 -0500 Received: from [199.232.76.173] (port=60832 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NHhS9-00046S-4r for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2009 12:32:53 -0500 Received: from smtp-out3.starman.ee ([85.253.0.5]:46781 helo=mx1.starman.ee) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NHhS9-00063f-8j for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2009 12:32:53 -0500 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (82.131.97.43.cable.starman.ee [82.131.97.43]) by mx1.starman.ee (Postfix) with ESMTP id A0C823F429C for ; Mon, 7 Dec 2009 19:32:45 +0200 (EET) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: Lossage in comint history Organization: JURTA Date: Mon, 07 Dec 2009 19:27:34 +0200 Message-ID: <87iqcjeq45.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Using M-x shell in Emacs causes lossage in .bash_history. I set HISTFILESIZE and HISTSIZE to large values in .bashrc to not truncate the history file but comint.el disregards my settings and truncates the history file used by bash. The following patch make `comint-input-ring-size' customizable. The type should be `integer' because this value is used by `make-ring' to create the history ring. The default value increased to 500 to be the same as the default value of HISTFILESIZE and HISTSIZE. Index: lisp/comint.el =================================================================== RCS file: /sources/emacs/emacs/lisp/comint.el,v retrieving revision 1.402 diff -c -r1.402 comint.el *** lisp/comint.el 1 Dec 2009 20:32:00 -0000 1.402 --- lisp/comint.el 7 Dec 2009 17:27:08 -0000 *************** *** 309,317 **** :type 'integer :group 'comint) ! ;; FIXME: this should be defcustom ! (defvar comint-input-ring-size 150 ! "Size of input history ring.") (defvar comint-input-ring-separator "\n" "Separator between commands in the history file.") --- 309,319 ---- :type 'integer :group 'comint) ! (defcustom comint-input-ring-size 500 ! "Size of input history ring." ! :type 'integer ! :group 'comint ! :version "23.2") (defvar comint-input-ring-separator "\n" "Separator between commands in the history file.") -- Juri Linkov http://www.jurta.org/emacs/ ------------=_1262371562-29378-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 5148-done) by debbugs.gnu.org; 1 Jan 2010 18:45:38 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NQmVG-0007dZ-HZ for submit@debbugs.gnu.org; Fri, 01 Jan 2010 13:45:38 -0500 Received: from pantheon-po29.its.yale.edu ([130.132.50.124]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NQmVF-0007dT-At for 5148-done@debbugs.gnu.org; Fri, 01 Jan 2010 13:45:37 -0500 Received: from furry (dhcp128036014103.central.yale.edu [128.36.14.103]) (authenticated bits=0) by pantheon-po29.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o01IjW6C029207 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 1 Jan 2010 13:45:32 -0500 Received: by furry (Postfix, from userid 1000) id D6819C05D; Fri, 1 Jan 2010 13:45:32 -0500 (EST) From: Chong Yidong To: Juri Linkov Subject: Re: Lossage in comint history Date: Fri, 01 Jan 2010 13:45:32 -0500 Message-ID: <87y6kh8y0j.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 5148-done Cc: 5148-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.3 (-) > Using M-x shell in Emacs causes lossage in .bash_history. > > I set HISTFILESIZE and HISTSIZE to large values in .bashrc > to not truncate the history file but comint.el disregards > my settings and truncates the history file used by bash. > > The following patch make `comint-input-ring-size' customizable. The > type should be `integer' because this value is used by `make-ring' to > create the history ring. The default value increased to 500 to be the > same as the default value of HISTFILESIZE and HISTSIZE. Looks reasonable enough to me. Checked in, thanks. ------------=_1262371562-29378-0--