bug#4857: 23.1; tar-mode "C" tar-copy not working

bug#4857: 23.1; tar-mode "C" tar-copy not working

[Kevin Ryde]

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

Visiting the file foo.tar below

    emacs -Q foo.tar

and trying to `tar-copy' the first entry to a file "zzz"

    C
    zzz

gets an error

    tar-copy: Args out of range: 513, 723

On a tar with a lot of files, the first of which is small, the command
succeeds, but the contents written are the text of the directory
listing, not the tar file.

I see tar-copy does a `widen' apparently to get at the data.  Does it
have to look in tar-data-buffer these days?



[-- Attachment #2: foo.tar --]
[-- Type: application/x-tar, Size: 10240 bytes --]

[-- Attachment #3: Type: text/plain, Size: 1076 bytes --]



In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5)
 of 2009-09-14 on raven, modified by Debian
configured using `configure  '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS=''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_AU
  value of $XMODIFIERS: nil
  locale-coding-system: iso-latin-1-unix
  default-enable-multibyte-characters: t

bug#4857: 23.1; tar-mode "C" tar-copy not working

[Stefan Monnier]

> I see tar-copy does a `widen' apparently to get at the data.  Does it
> have to look in tar-data-buffer these days?

Yes,


        Stefan

bug#4857: marked as done (23.1; tar-mode "C" tar-copy not working)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 868 bytes --]

Your message dated Sat, 07 Nov 2009 13:20:43 -0500
with message-id <87k4y2ci2s.fsf@stupidchicken.com>
and subject line Re: 23.1; tar-mode "C" tar-copy not working
has caused the Emacs bug report #4857,
regarding 23.1; tar-mode "C" tar-copy not working
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
4857: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4857
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 17901 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 466 bytes --]

Visiting the file foo.tar below

    emacs -Q foo.tar

and trying to `tar-copy' the first entry to a file "zzz"

    C
    zzz

gets an error

    tar-copy: Args out of range: 513, 723

On a tar with a lot of files, the first of which is small, the command
succeeds, but the contents written are the text of the directory
listing, not the tar file.

I see tar-copy does a `widen' apparently to get at the data.  Does it
have to look in tar-data-buffer these days?



[-- Attachment #2.1.2: foo.tar --]
[-- Type: application/x-tar, Size: 10240 bytes --]

[-- Attachment #2.1.3: Type: text/plain, Size: 1076 bytes --]



In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5)
 of 2009-09-14 on raven, modified by Debian
configured using `configure  '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS=''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_AU
  value of $XMODIFIERS: nil
  locale-coding-system: iso-latin-1-unix
  default-enable-multibyte-characters: t

[-- Attachment #3: Type: message/rfc822, Size: 1708 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Kevin Ryde <user42@zip.com.au>
Cc: 4857-done@emacsbugs.donarmstrong.com
Subject: Re: 23.1; tar-mode "C" tar-copy not working
Date: Sat, 07 Nov 2009 13:20:43 -0500
Message-ID: <87k4y2ci2s.fsf@stupidchicken.com>

>     emacs -Q foo.tar
>     C
>     zzz
>     tar-copy: Args out of range: 513, 723
>
> On a tar with a lot of files, the first of which is small, the command
> succeeds, but the contents written are the text of the directory
> listing, not the tar file.

I've checked in a fix.  Thanks.