From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#4725: marked as done (23.1; doc of misearch-* commands (commands?)) Date: Mon, 30 Nov 2009 19:55:07 +0000 Message-ID: References: <87r5rflrvx.fsf@mail.jurta.org> <18FECACAE8904F2A9A26016A02CCA5F0@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1259610907-19291-0" X-Trace: ger.gmane.org 1259612391 13639 80.91.229.12 (30 Nov 2009 20:19:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 30 Nov 2009 20:19:51 +0000 (UTC) To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 30 21:19:44 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NFCij-0003Pp-LJ for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Nov 2009 21:19:42 +0100 Original-Received: from localhost ([127.0.0.1]:59820 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NFCij-000790-5p for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Nov 2009 15:19:41 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NFCX0-0000YC-6g for bug-gnu-emacs@gnu.org; Mon, 30 Nov 2009 15:07:34 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NFCWt-0000Oi-Aj for bug-gnu-emacs@gnu.org; Mon, 30 Nov 2009 15:07:33 -0500 Original-Received: from [199.232.76.173] (port=60643 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NFCWs-0000NX-On for bug-gnu-emacs@gnu.org; Mon, 30 Nov 2009 15:07:26 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:54590) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NFCWr-0005U1-WD for bug-gnu-emacs@gnu.org; Mon, 30 Nov 2009 15:07:26 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAUK7Nrt021103; Mon, 30 Nov 2009 12:07:24 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id nAUJt7Jc019336; Mon, 30 Nov 2009 11:55:07 -0800 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 4725 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:33083 Archived-At: This is a multi-part message in MIME format... ------------=_1259610907-19291-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Mon, 30 Nov 2009 21:44:18 +0200 with message-id <87r5rflrvx.fsf@mail.jurta.org> and subject line Re: bug#4725: 23.1; doc of misearch-* commands (commands?) has caused the Emacs bug report #4725, regarding 23.1; doc of misearch-* commands (commands?) to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 4725: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D4725 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1259610907-19291-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 14 Oct 2009 20:50:11 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.3 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9EKo9SQ032719 for ; Wed, 14 Oct 2009 13:50:10 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MyAnQ-0003EH-Un for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2009 16:50:08 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MyAnM-0003Dk-Cr for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2009 16:50:08 -0400 Received: from [199.232.76.173] (port=41529 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MyAnM-0003Dh-83 for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2009 16:50:04 -0400 Received: from rcsinet12.oracle.com ([148.87.113.124]:17320 helo=rgminet12.oracle.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MyAnK-0008Br-31 for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2009 16:50:03 -0400 Received: from rgminet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rgminet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n9EKnbgw019791 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 14 Oct 2009 20:49:38 GMT Received: from acsmt353.oracle.com (acsmt353.oracle.com [141.146.40.153]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n9EG5pQb016632 for ; Wed, 14 Oct 2009 20:49:58 GMT Received: from abhmt012.oracle.com by acsmt358.oracle.com with ESMTP id 20409917021255553386; Wed, 14 Oct 2009 15:49:46 -0500 Received: from dradamslap1 (/141.144.160.48) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 14 Oct 2009 13:49:46 -0700 From: "Drew Adams" To: Subject: 23.1; doc of misearch-* commands (commands?) Date: Wed, 14 Oct 2009 13:49:52 -0700 Message-ID: <18FECACAE8904F2A9A26016A02CCA5F0@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcpND+DuBHS9nYUNRI2+oHs0IMISKw== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: acsmt353.oracle.com [141.146.40.153] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090203.4AD63975.0120:SCFMA4539814,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) emacs -Q In NEWS it says: ** The package misearch.el has been added. It allows Isearch to search through multiple buffers. A variable `multi-isearch-next-buffer-function' defines the function to call to get the next buffer to search in the series of multiple buffers. Top-level commands `multi-isearch-buffers', `multi-isearch-buffers-regexp', `multi-isearch-files' and `multi-isearch-files-regexp' accept a single argument that specifies a list of buffers/files to search for a string/regexp. But this is false. The functions `multi-isearch-buffers', `multi-isearch-buffers-regexp', `multi-isearch-files' and `multi-isearch-files-regexp', defined in misearch.el, are not defined as commands. 1. Shouldn't they be commands? I.e., this is the first bug. Or else change the NEWS item. 2. I find no explanation of using Isearch with multiple buffers or files anywhere, including in the Emacs manual. This needs to be documented somewhere. Logically, this should be explained in a new section of the Isearch chapter of the Emacs manual. It is even the case that multi-isearch is handled, in its essentials, in isearch.el (not in misearch.el). So this is really an integral part of Isearch. It needs to be properly documented as such. That means at least (1) in the Emacs manual and (2) in the file Commentary of isearch.el. I would even say that it should be documented how to use the multi-isearch framework to set up multiple buffers etc. for searching. It's not obvious (1) that you can do that or (2) how to do that. There is no reason not to let Emacs-Lisp programmers know about this. This is provided out of the box as part of Isearch, and it should be well documented. In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600) of 2009-07-29 on SOFT-MJASON Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.4)' ------------=_1259610907-19291-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4725-done) by emacsbugs.donarmstrong.com; 30 Nov 2009 19:45:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.7 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx2.starman.ee (smtp-out4.starman.ee [85.253.0.6]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAUJj2lh018085 for <4725-done@emacsbugs.donarmstrong.com>; Mon, 30 Nov 2009 11:45:03 -0800 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.52.137.cable.starman.ee [82.131.52.137]) by mx2.starman.ee (Postfix) with ESMTP id AE03A3F411E; Mon, 30 Nov 2009 21:44:55 +0200 (EET) From: Juri Linkov To: "Drew Adams" Cc: 4725-done@emacsbugs.donarmstrong.com Subject: Re: bug#4725: 23.1; doc of misearch-* commands (commands?) Organization: JURTA References: <18FECACAE8904F2A9A26016A02CCA5F0@us.oracle.com> <878wfdvdtu.fsf@mail.jurta.org> <200BE6E2E4C04E0CB402FC249FD0F66E@us.oracle.com> <87my3s2vko.fsf@mail.jurta.org> <3D28EDE8022C470E8A8A37C632BF89C9@us.oracle.com> Date: Mon, 30 Nov 2009 21:44:18 +0200 In-Reply-To: <3D28EDE8022C470E8A8A37C632BF89C9@us.oracle.com> (Drew Adams's message of "Thu, 15 Oct 2009 15:49:21 -0700") Message-ID: <87r5rflrvx.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> What is missing now and candidates to be implemented are >> 8 analogous commands: >> >> multi-isearch-buffers >> multi-isearch-buffers-regexp >> multi-isearch-buffers-matching >> multi-isearch-buffers-regexp-matching >> multi-isearch-files >> multi-isearch-files-regexp >> multi-isearch-files-matching >> multi-isearch-files-regexp-matching > > I'd suggest having just simple commands that let you enter buffer/file names, as > I said above. > > Anyway, do whatever you want in this regard. I agree that it's good for users to > be able to both (a) choose files/buffers by name individually, and (b) choose > them by regexp matching. I agree 8 commands is too much. So I left the number of commands unchanged. Now interactively `multi-isearch-buffers' and `multi-isearch-buffers-regexp' read buffer names to search, one by one, ended with RET. With a prefix argument, they ask for a regexp, and search in buffers whose names match the specified regexp. Interactively `multi-isearch-files' and `multi-isearch-files-regexp' read file names to search, one by one, ended with RET. With a prefix argument, they ask for a wildcard, and search in file buffers whose file names match the specified wildcard. (PS: Some new reading functions duplicate some code from other existing functions with subtle differences, and I see no way to use existing functions as is, so I added comments that point to original code). -- Juri Linkov http://www.jurta.org/emacs/ ------------=_1259610907-19291-0--