From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: don@donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#469: marked as done (pgg-gpg.el - pgg-gpg-process-region timing problem) Date: Sat, 2 Aug 2008 12:15:06 -0700 Message-ID: References: <873aln2q1d.fsf@stupidchicken.com> <87r6ao8rty.fsf@ambire.localdomain> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1217704506-31730-2" X-Trace: ger.gmane.org 1217705350 2105 80.91.229.12 (2 Aug 2008 19:29:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 2 Aug 2008 19:29:10 +0000 (UTC) To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 02 21:30:00 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KPMnO-000498-VB for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Aug 2008 21:29:43 +0200 Original-Received: from localhost ([127.0.0.1]:51682 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KPMmU-0007vJ-70 for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Aug 2008 15:28:46 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KPMlJ-0006cN-AX for bug-gnu-emacs@gnu.org; Sat, 02 Aug 2008 15:27:33 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KPMlG-0006Zy-IP for bug-gnu-emacs@gnu.org; Sat, 02 Aug 2008 15:27:30 -0400 Original-Received: from [199.232.76.173] (port=34423 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KPMlD-0006YF-Jv for bug-gnu-emacs@gnu.org; Sat, 02 Aug 2008 15:27:27 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:59576) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KPMlC-0003u8-Ap for bug-gnu-emacs@gnu.org; Sat, 02 Aug 2008 15:27:27 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m72JRLT7003316; Sat, 2 Aug 2008 12:27:23 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m72JF69b031805; Sat, 2 Aug 2008 12:15:06 -0700 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: don@donarmstrong.com X-Emacs-PR-Message: closed 469 X-Emacs-PR-Package: emacs X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:18972 Archived-At: This is a multi-part message in MIME format... ------------=_1217704506-31730-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Sat, 02 Aug 2008 15:08:30 -0400 with message-id <873aln2q1d.fsf@stupidchicken.com> and subject line Re: pgg-gpg.el - pgg-gpg-process-region timing problem has caused the Emacs bug report #465, regarding pgg-gpg.el - pgg-gpg-process-region timing problem to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact don@donarmstrong.com immediately.) --=20 465: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D465 Emacs Bug Tracking System Contact don@donarmstrong.com with problems ------------=_1217704506-31730-2 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.0 required=4.0 tests=BAYES_00,GMAIL, MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 23 Jun 2008 08:46:07 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m5N8k220021867 for ; Mon, 23 Jun 2008 01:46:04 -0700 Received: from mail.gnu.org ([199.232.76.166]:40256 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KAhgT-0000Lz-JU for emacs-pretest-bug@gnu.org; Mon, 23 Jun 2008 04:45:57 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KAhgT-0004zt-ND for emacs-pretest-bug@gnu.org; Mon, 23 Jun 2008 04:46:00 -0400 Received: from [151.61.141.75] (port=33978 helo=ambire.localdomain) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KAhgS-0004yL-Hy; Mon, 23 Jun 2008 04:45:57 -0400 Received: from ttn by ambire.localdomain with local (Exim 4.63) (envelope-from ) id 1KAhdh-0001aU-4g; Mon, 23 Jun 2008 10:43:05 +0200 From: Thien-Thi Nguyen To: "ken manheimer" Cc: wilde@sha-bang.de, emacs-pretest-bug@gnu.org, ueno@unixuser.org, emacs-devel Subject: Re: pgg-gpg.el - pgg-gpg-process-region timing problem References: <2cd46e7f0806221037h6d16839bp567eb5b901313375@mail.gmail.com> <87zlpc8t00.fsf@ambire.localdomain> Date: Mon, 23 Jun 2008 10:43:05 +0200 In-Reply-To: <87zlpc8t00.fsf@ambire.localdomain> (Thien-Thi Nguyen's message of "Mon, 23 Jun 2008 10:17:51 +0200") Message-ID: <87r6ao8rty.fsf@ambire.localdomain> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-Greylist: delayed 1512 seconds by postgrey-1.27 at monty-python; Mon, 23 Jun 2008 04:45:54 EDT ChangeLog entry: Use process sentinel to monitor gpg subprocess status. * pgg-gpg.el (pgg-gpg-process-region): Fix omission bug: Use process sentinel to update process status and exit-status. Reported by ken manheimer . patch: *** pgg-gpg.el 6 May 2008 07:57:46 -0000 1.27 --- pgg-gpg.el 23 Jun 2008 08:40:50 -0000 *************** *** 70,111 **** ,@pgg-gpg-extra-args ,@args)) (output-buffer pgg-output-buffer) (errors-buffer pgg-errors-buffer) ! (orig-mode (default-file-modes)) ! (process-connection-type nil) ! (inhibit-redisplay t) ! process status exit-status ! passphrase-with-newline ! encoded-passphrase-with-new-line) (with-current-buffer (get-buffer-create errors-buffer) (buffer-disable-undo) (erase-buffer)) (unwind-protect ! (progn (set-default-file-modes 448) ! (let ((coding-system-for-write 'binary)) ! (setq process ! (apply #'start-process "*GnuPG*" errors-buffer ! program args))) ! (set-process-sentinel process #'ignore) (when passphrase ! (setq passphrase-with-newline (concat passphrase "\n")) ! (if pgg-passphrase-coding-system ! (progn ! (setq encoded-passphrase-with-new-line (encode-coding-string ! passphrase-with-newline ! (coding-system-change-eol-conversion ! pgg-passphrase-coding-system 'unix))) ! (pgg-clear-string passphrase-with-newline)) ! (setq encoded-passphrase-with-new-line passphrase-with-newline ! passphrase-with-newline nil)) ! (process-send-string process encoded-passphrase-with-new-line)) (process-send-region process start end) (process-send-eof process) ! (while (eq 'run (process-status process)) (accept-process-output process 5)) - (setq status (process-status process) - exit-status (process-exit-status process)) (delete-process process) (with-current-buffer (get-buffer-create output-buffer) (buffer-disable-undo) --- 70,104 ---- ,@pgg-gpg-extra-args ,@args)) (output-buffer pgg-output-buffer) (errors-buffer pgg-errors-buffer) ! (inhibit-redisplay t)) (with-current-buffer (get-buffer-create errors-buffer) (buffer-disable-undo) (erase-buffer)) (unwind-protect ! (let* ((coding-system-for-write 'binary) ! (process (let ((orig (default-file-modes))) (set-default-file-modes 448) ! (prog1 (apply #'start-process "*GnuPG*" ! errors-buffer program args) ! (set-default-file-modes orig)))) ! (status (process-status process)) ! exit-status) ! (set-process-sentinel ! process (lambda (process reason) ! (setq status (process-status process) ! exit-status (process-exit-status process)))) (when passphrase ! (process-send-string ! process (if pgg-passphrase-coding-system (encode-coding-string ! passphrase ! pgg-passphrase-coding-system) ! passphrase)) ! (process-send-string process "\n")) (process-send-region process start end) (process-send-eof process) ! (while (eq 'run status) (accept-process-output process 5)) (delete-process process) (with-current-buffer (get-buffer-create output-buffer) (buffer-disable-undo) *************** *** 120,134 **** (error "%s exited abnormally: '%s'" program exit-status)) (if (= 127 exit-status) (error "%s could not be found" program)))) - (if passphrase-with-newline - (pgg-clear-string passphrase-with-newline)) - (if encoded-passphrase-with-new-line - (pgg-clear-string encoded-passphrase-with-new-line)) - (if (and process (eq 'run (process-status process))) - (interrupt-process process)) (if (file-exists-p output-file-name) ! (delete-file output-file-name)) ! (set-default-file-modes orig-mode)))) (defun pgg-gpg-possibly-cache-passphrase (passphrase &optional key notruncate) (if (and passphrase --- 113,120 ---- (error "%s exited abnormally: '%s'" program exit-status)) (if (= 127 exit-status) (error "%s could not be found" program)))) (if (file-exists-p output-file-name) ! (delete-file output-file-name))))) (defun pgg-gpg-possibly-cache-passphrase (passphrase &optional key notruncate) (if (and passphrase ------------=_1217704506-31730-2 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-3.1 required=4.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 465-done) by emacsbugs.donarmstrong.com; 2 Aug 2008 19:08:23 +0000 Received: from cyd (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m72J8K08030048 for <465-done@emacsbugs.donarmstrong.com>; Sat, 2 Aug 2008 12:08:21 -0700 Received: by cyd (Postfix, from userid 1000) id C100F57E337; Sat, 2 Aug 2008 15:08:30 -0400 (EDT) From: Chong Yidong To: 465-done@emacsbugs.donarmstrong.com Subject: Re: pgg-gpg.el - pgg-gpg-process-region timing problem Date: Sat, 02 Aug 2008 15:08:30 -0400 Message-ID: <873aln2q1d.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii I've checked in a fix for this (verified by Ken Manheimer via private email). This fix is in pgg-gpg.el, which I think was calling accept-process-output in a slightly incorrect way. ------------=_1217704506-31730-2--