From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#4578: marked as done ([PATCH] Emacs CVS: ispell.el (ispell-get-decoded-string): signal an error if no slot found) Date: Sat, 17 Oct 2009 03:20:12 +0000 Message-ID: References: <87k4zjwb6s.fsf@jondo.cante.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1255749613-3274-0" X-Trace: ger.gmane.org 1255750073 21451 80.91.229.12 (17 Oct 2009 03:27:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 17 Oct 2009 03:27:53 +0000 (UTC) To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 17 05:27:42 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MyzxB-0005RL-Rq for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Oct 2009 05:27:38 +0200 Original-Received: from localhost ([127.0.0.1]:39289 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MyzxB-0004oX-6C for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Oct 2009 23:27:37 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Myzww-0004g1-Ot for bug-gnu-emacs@gnu.org; Fri, 16 Oct 2009 23:27:22 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Myzws-0004ee-Ak for bug-gnu-emacs@gnu.org; Fri, 16 Oct 2009 23:27:22 -0400 Original-Received: from [199.232.76.173] (port=57559 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Myzwr-0004eZ-Uy for bug-gnu-emacs@gnu.org; Fri, 16 Oct 2009 23:27:18 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:40659) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Myzwo-0006Ia-96; Fri, 16 Oct 2009 23:27:14 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9H3RBXr004301; Fri, 16 Oct 2009 20:27:12 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n9H3KDJX003382; Fri, 16 Oct 2009 20:20:13 -0700 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 4578 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: patch X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:32025 Archived-At: This is a multi-part message in MIME format... ------------=_1255749613-3274-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Fri, 16 Oct 2009 23:10:38 -0400 with message-id and subject line Re: Bug#4578: ispell.el (ispell-get-decoded-string): signa= l an error if no slot found has caused the Emacs bug report #4578, regarding [PATCH] Emacs CVS: ispell.el (ispell-get-decoded-string): signal = an error if no slot found to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 4578: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D4578 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1255749613-3274-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 28 Sep 2009 11:39:11 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.6 required=4.0 tests=AWL,IMPRONONCABLE_2, MURPHY_DRUGS_REL8,SARE_MLB_Stock6 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from emh06.mail.saunalahti.fi (emh06.mail.saunalahti.fi [62.142.5.116]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8SBd9Fn018474 for ; Mon, 28 Sep 2009 04:39:10 -0700 Received: from saunalahti-vams (vs3-10.mail.saunalahti.fi [62.142.5.94]) by emh06-2.mail.saunalahti.fi (Postfix) with SMTP id 8BE47C818C for ; Mon, 28 Sep 2009 14:39:08 +0300 (EEST) Received: from emh03.mail.saunalahti.fi ([62.142.5.109]) by vs3-10.mail.saunalahti.fi ([62.142.5.94]) with SMTP (gateway) id A047D2884F5; Mon, 28 Sep 2009 14:39:08 +0300 Received: from jondo.cante.net (a91-155-187-216.elisa-laajakaista.fi [91.155.187.216]) by emh03.mail.saunalahti.fi (Postfix) with ESMTP id 78255158A63 for ; Mon, 28 Sep 2009 14:39:07 +0300 (EEST) From: Jari Aalto To: submit@emacsbugs.donarmstrong.com Subject: [PATCH] Emacs CVS: ispell.el (ispell-get-decoded-string): signal an error if no slot found Date: Mon, 28 Sep 2009 14:39:07 +0300 Message-ID: <87k4zjwb6s.fsf@jondo.cante.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Antivirus: VAMS --=-=-= Tags: patch If the empty slot is not checked, the spell checking breaks in myterious errors. E.g. flyspell-get-casechars returns nil, which breaks all of flyspell. 2009-09-28 Jari Aalto * textmodes/ispell.el (ispell-get-decoded-string): signal an error if no matching slot is found from `ispell-current-dictionary' --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-lisp-textmodes-ispell.el-ispell-get-decoded-string-s.patch >From b301e76fdf3e83de88101891a3cd7ea13f5fba14 Mon Sep 17 00:00:00 2001 From: Jari Aalto Date: Mon, 28 Sep 2009 14:35:21 +0300 Subject: [PATCH] lisp/textmodes/ispell.el: (ispell-get-decoded-string): signal an error if no slot found Signed-off-by: Jari Aalto --- lisp/textmodes/ispell.el | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/lisp/textmodes/ispell.el b/lisp/textmodes/ispell.el index 6d02cf9..729122b 100644 --- a/lisp/textmodes/ispell.el +++ b/lisp/textmodes/ispell.el @@ -1289,7 +1289,8 @@ Protects against bogus binding of `enable-multibyte-characters' in XEmacs." (defun ispell-get-decoded-string (n) (let* ((slot (or (assoc ispell-current-dictionary ispell-local-dictionary-alist) - (assoc ispell-current-dictionary ispell-dictionary-alist))) + (assoc ispell-current-dictionary ispell-dictionary-alist) + (error "No slot match in ispell-current-dictionary"))) (str (nth n slot))) (when (and (> (length str) 0) (not (multibyte-string-p str))) -- 1.6.3.3 --=-=-=-- ------------=_1255749613-3274-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4578-done) by emacsbugs.donarmstrong.com; 17 Oct 2009 03:10:40 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-7.4 required=4.0 tests=AWL,HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9H3Ads7002242 for <4578-done@emacsbugs.donarmstrong.com>; Fri, 16 Oct 2009 20:10:40 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1Myzgk-0004Tl-Oa; Fri, 16 Oct 2009 23:10:38 -0400 From: Glenn Morris To: 4578-done@emacsbugs.donarmstrong.com Subject: Re: Bug#4578: ispell.el (ispell-get-decoded-string): signal an error if no slot found References: <87k4zjwb6s.fsf@jondo.cante.net> X-Spook: MIT-LL digicash Syria Treasury USDOJ Noriega Bush Wired X-Ran: W2VNBU'?0'N+q]]OPq_:;P*QHjrz}>trON'2XbSzlq[EG8Pbo0x7%4/SuZ4-bwO4k6e8HC X-Hue: magenta X-Debbugs-No-Ack: yes X-Attribution: GM Date: Fri, 16 Oct 2009 23:10:38 -0400 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Thanks; applied. ------------=_1255749613-3274-0--