From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#4531: marked as done (23.1; browse-url with unknown func in browse-url-browser-function) Date: Fri, 02 Oct 2009 07:20:06 +0000 Message-ID: References: <87r5tya202.fsf@blah.blah> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1254468006-24619-0" X-Trace: ger.gmane.org 1254468615 24194 80.91.229.12 (2 Oct 2009 07:30:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 2 Oct 2009 07:30:15 +0000 (UTC) To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 02 09:30:08 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Mtcac-0003cI-Lp for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Oct 2009 09:30:07 +0200 Original-Received: from localhost ([127.0.0.1]:38759 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mtcab-0005hI-G4 for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Oct 2009 03:30:05 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MtcaO-0005cH-Js for bug-gnu-emacs@gnu.org; Fri, 02 Oct 2009 03:29:52 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MtcaL-0005af-4Y for bug-gnu-emacs@gnu.org; Fri, 02 Oct 2009 03:29:52 -0400 Original-Received: from [199.232.76.173] (port=43107 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MtcaK-0005aZ-Ir for bug-gnu-emacs@gnu.org; Fri, 02 Oct 2009 03:29:48 -0400 Original-Received: from mx20.gnu.org ([199.232.41.8]:41555) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MtcaG-0008Eu-Dn; Fri, 02 Oct 2009 03:29:44 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MtcaF-00035q-LA; Fri, 02 Oct 2009 03:29:43 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n927R7o9025826; Fri, 2 Oct 2009 00:27:08 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n927K6uF024707; Fri, 2 Oct 2009 00:20:06 -0700 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 4531 X-Emacs-PR-Package: emacs X-detected-operating-system: by mx20.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31631 Archived-At: This is a multi-part message in MIME format... ------------=_1254468006-24619-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Fri, 02 Oct 2009 03:11:17 -0400 with message-id and subject line Re: bug#4531: 23.1; browse-url with unknown func in browse= -url-browser-function has caused the Emacs bug report #4531, regarding 23.1; browse-url with unknown func in browse-url-browser-function to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 4531: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D4531 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1254468006-24619-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 23 Sep 2009 01:23:02 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.9 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8N1N0Ii011165 for ; Tue, 22 Sep 2009 18:23:01 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MqGZP-0002Da-RD for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2009 21:22:59 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MqGZK-0002B4-LR for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2009 21:22:59 -0400 Received: from [199.232.76.173] (port=52475 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MqGZK-0002B1-IS for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2009 21:22:54 -0400 Received: from mailout2-14.pacific.net.au ([125.255.80.141]:34880 helo=mailout2.pacific.net.au) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MqGZJ-0006a3-R8 for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2009 21:22:54 -0400 Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.2.162]) by mailout2.pacific.net.au (Postfix) with ESMTP id 24F3B190D10 for ; Wed, 23 Sep 2009 11:22:46 +1000 (EST) Received: from blah.blah (ppp2FD6.dyn.pacific.net.au [61.8.47.214]) by mailproxy1.pacific.net.au (Postfix) with ESMTP id 3D1718C2D for ; Wed, 23 Sep 2009 11:22:45 +1000 (EST) Received: from gg by blah.blah with local (Exim 4.69) (envelope-from ) id 1MqGZ3-0006I8-Nw for bug-gnu-emacs@gnu.org; Wed, 23 Sep 2009 11:22:37 +1000 From: Kevin Ryde To: bug-gnu-emacs@gnu.org Subject: 23.1; browse-url with unknown func in browse-url-browser-function Date: Wed, 23 Sep 2009 11:22:37 +1000 Message-ID: <87r5tya202.fsf@blah.blah> User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) --=-=-= If browse-url-browser-function is an unknown symbol the error from browse-url isn't very helpful. Eg. M-: (setq browse-url-browser-function 'FOOBAR-browse-url) M-x browse-url http://www.gnu.org => Wrong type argument: listp, FOOBAR-browse-url I hoped it would say the problem is the symbol is unbound, not that it's supposed to be a list. (The value can be a list of course, but if the value is a symbol then it's surely meant to be the name of a function.) Sending symbols down the `apply' leg of `browse-url' would give => Symbol's function definition is void: FOOBAR-browse-url which I think is a much better. 2009-09-23 Kevin Ryde * net/browse-url.el (browse-url): Pass any symbol in browse-url-browser-function to `apply', since if you've mistakenly put an unbound symbol then the error from apply is much clearer that the function you wanted is not available. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=browse-url.el.symbolp.diff --- browse-url.el.~1.80.~ 2009-09-23 11:08:37.000000000 +1000 +++ browse-url.el 2009-09-23 11:16:22.000000000 +1000 @@ -778,7 +778,11 @@ ;; which may not even exist any more. (if (stringp (frame-parameter (selected-frame) 'display)) (setenv "DISPLAY" (frame-parameter (selected-frame) 'display))) - (if (functionp browse-url-browser-function) + ;; send any symbol to `apply', not just fboundp ones, since + ;; void-function from apply is clearer than wrong-type-argument + ;; from dolist + (if (or (symbolp browse-url-browser-function) + (functionp browse-url-browser-function)) (apply browse-url-browser-function url args) ;; The `function' can be an alist; look down it for first match ;; and apply the function (which might be a lambda). --=-=-= In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5) of 2009-08-03 on raven, modified by Debian configured using `configure '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS='' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_AU value of $XMODIFIERS: nil locale-coding-system: iso-latin-1-unix default-enable-multibyte-characters: t --=-=-=-- ------------=_1254468006-24619-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4531-done) by emacsbugs.donarmstrong.com; 2 Oct 2009 07:11:19 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-7.5 required=4.0 tests=AWL,HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n927BHi4023797 for <4531-done@emacsbugs.donarmstrong.com>; Fri, 2 Oct 2009 00:11:19 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1MtcIP-0000uc-6q; Fri, 02 Oct 2009 03:11:17 -0400 From: Glenn Morris To: 4531-done@emacsbugs.donarmstrong.com Subject: Re: bug#4531: 23.1; browse-url with unknown func in browse-url-browser-function References: <87r5tya202.fsf@blah.blah> X-Spook: anarchy Defcon John Kerry red noise bullion ANDVT X-Ran: MRJ;&^2o0n.W3od#RF<6vS4xG}g[l)jd`;l=Fm4|P0R48qHAb%-63-k#'V}x(:CX6W~uqZ X-Hue: yellow X-Debbugs-No-Ack: yes X-Attribution: GM Date: Fri, 02 Oct 2009 03:11:17 -0400 In-Reply-To: <87r5tya202.fsf@blah.blah> (Kevin Ryde's message of "Wed, 23 Sep 2009 11:22:37 +1000") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Thanks; applied. ------------=_1254468006-24619-0--