From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#4510: marked as done (23.1; Separate help-argument-face from downcasing) Date: Thu, 24 Sep 2009 19:30:04 +0000 Message-ID: References: <49ADA31DA6A342CCB1E5FF47158A498A@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1253820604-11036-0" X-Trace: ger.gmane.org 1253821663 8697 80.91.229.12 (24 Sep 2009 19:47:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 24 Sep 2009 19:47:43 +0000 (UTC) To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 24 21:47:36 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MquHs-0001Xt-QP for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Sep 2009 21:47:33 +0200 Original-Received: from localhost ([127.0.0.1]:36639 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MquHs-0007Vc-Dv for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Sep 2009 15:47:32 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MquHb-0007Q3-7h for bug-gnu-emacs@gnu.org; Thu, 24 Sep 2009 15:47:15 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MquHW-0007OH-Bi for bug-gnu-emacs@gnu.org; Thu, 24 Sep 2009 15:47:14 -0400 Original-Received: from [199.232.76.173] (port=47680 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MquHV-0007O7-WE for bug-gnu-emacs@gnu.org; Thu, 24 Sep 2009 15:47:10 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:50117) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MquHU-0007FF-SU for bug-gnu-emacs@gnu.org; Thu, 24 Sep 2009 15:47:09 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8OJl4lK013522; Thu, 24 Sep 2009 12:47:05 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n8OJU4nM011043; Thu, 24 Sep 2009 12:30:04 -0700 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 4510 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31471 Archived-At: This is a multi-part message in MIME format... ------------=_1253820604-11036-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Thu, 24 Sep 2009 21:25:22 +0200 with message-id and subject line Re: bug#4510: 23.1; Separate help-argument-face from downc= asing has caused the Emacs bug report #4510, regarding 23.1; Separate help-argument-face from downcasing to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 4510: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D4510 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1253820604-11036-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 21 Sep 2009 21:35:12 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.4 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8LLZATf026968 for ; Mon, 21 Sep 2009 14:35:12 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MpqXO-0000fp-4t for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2009 17:35:10 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MpqXI-0000eA-FX for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2009 17:35:09 -0400 Received: from [199.232.76.173] (port=47714 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MpqXI-0000dx-7r for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2009 17:35:04 -0400 Received: from acsinet11.oracle.com ([141.146.126.233]:25110) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MpqXH-0008WL-PT for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2009 17:35:04 -0400 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by acsinet11.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n8LLaFKn028873 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 21 Sep 2009 21:36:16 GMT Received: from abhmt012.oracle.com (abhmt012.oracle.com [141.146.116.21]) by acsinet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n8LLZRIA007701 for ; Mon, 21 Sep 2009 21:35:27 GMT Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 21 Sep 2009 14:34:58 -0700 From: "Drew Adams" To: Subject: 23.1; Separate help-argument-face from downcasing Date: Mon, 21 Sep 2009 14:35:00 -0700 Message-ID: <49ADA31DA6A342CCB1E5FF47158A498A@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: Aco7A18aOl2tGDhiRMCwXNdODwMFfQ== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt012.oracle.com [141.146.116.21] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090209.4AB7F182.01E3:SCFSTAT5015188,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Emacs 22 introduced face `help-argument-name' and function `help-default-arg-highlight'. The Emacs 22 NEWS says this: To change the default, customize face `help-argument-name' or redefine the function `help-default-arg-highlight'. The problem is that function `help-default-arg-highlight' couples (a) the use of a face to highlight the arguments with (b) downcasing the arguments. These two should be separated, so users can highlight without downcasing (or downcase without highlighting). I, for instance, find lowercase italics (the default, starting with Emacs 22) to be much less readable than uppercase non-italics (the default before Emacs 22). But I would really prefer uppercase italics. There is no way to get this, short of redefining the function `help-default-arg-highlight'. That should not be the only alternative for users. Users should not be expected to redefine basic functions in order to customize such appearances. And in any case, it makes no sense for the face and the letter case to be hard-code-coupled. This is the definition of `help-default-arg-highlight': (defun help-default-arg-highlight (arg) "Default function to highlight arguments in *Help* buffers. It returns ARG in face `help-argument-name'; ARG is also downcased if it displays differently than the default face (according to `face-differs-from-default-p')." (propertize (if (face-differs-from-default-p 'help-argument-name) (downcase arg) arg) 'face 'help-argument-name)) If face `help-argument-name' is different from the default face, then the args are downcased. The logic should simply be to apply the face systematically: if it is the same as the default, then the face would have no effect. And then provide a separate option to control upcasing/downcasing. In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600) of 2009-07-29 on SOFT-MJASON Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.4)' ------------=_1253820604-11036-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4510-done) by emacsbugs.donarmstrong.com; 24 Sep 2009 19:25:50 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.2 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=unavailable version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-bw0-f223.google.com (mail-bw0-f223.google.com [209.85.218.223]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8OJPmeb010684; Thu, 24 Sep 2009 12:25:49 -0700 Received: by bwz23 with SMTP id 23so1782142bwz.1 for ; Thu, 24 Sep 2009 12:25:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=qWCzoZ3I6JM5n3KC9s7XqDYmNWx1/91EVp8If/k/vTA=; b=LHKZjstdn+8CCgUzHWir6pJuHd+EVn5+3+caP9LQm4vQ9LktbnJr/fGxDhZx9sTlWV tSLRRhetq+zU0Ef/2Ogoy8BBd7njhVG5wuajo8HVZe+3XxQkFcuw/OXDRTfJl4hUOgc2 6jPz6X6xmS34GyiqbflQ0surRUV67bt3r0NfI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=Eo6A+hPj9nVhqViZ8pi46lCxB4wMCMdJmDTQaoCGeM6VYzjO/8j8r0IGPbAGabiFn0 QAcsASKOdpeWeCRmxkefes42tsRqQpAKLW3Lhj6nbjDYtD5w1pD9RkfKnTJi6SZy5ifi g8cgJvHJNaF1/Ruotbn2rDLOgw8zPc6R1ybJA= MIME-Version: 1.0 Received: by 10.239.168.153 with SMTP id k25mr304379hbe.68.1253820342151; Thu, 24 Sep 2009 12:25:42 -0700 (PDT) In-Reply-To: References: <49ADA31DA6A342CCB1E5FF47158A498A@us.oracle.com> <6C58CFFF6FFE46968BA790F764525B8A@us.oracle.com> From: Juanma Barranquero Date: Thu, 24 Sep 2009 21:25:22 +0200 Message-ID: Subject: Re: bug#4510: 23.1; Separate help-argument-face from downcasing To: Drew Adams , Dan Nicolaescu Cc: 4510-done@emacsbugs.donarmstrong.com, 4520-done@emacsbugs.donarmstrong.com Content-Type: text/plain; charset=UTF-8 I've installed the patch, defaulting `help-downcase-arguments' to nil as per Dan's request in bug#4520. If someone objects to the change in the default appearance of argument names we'll know soon enough... Juanma ------------=_1253820604-11036-0--